Code Monkey home page Code Monkey logo

mod-duel-reset's Introduction

logo AzerothCore

DuelReset

DuelReset

  • Latest DuelReset build status with azerothcore:

Build Status

This is a module for AzerothCore that adds some duel reset features.

Current features:

  • Health/mana reset: when duel starts it sets the health/mana of the player to the MAX, when the duel ends it restores the health/mana values that the player had before the duel
  • Cooldown reset: when duel starts it resets the player cooldowns
  • Cooldown age: sets the required age of a cooldown to be reset in order to prevent the feature from being abused
  • Reset zones/areas: specify the zones and areas where the resets actually apply

Requirements

Duel Reset module currently requires:

AzerothCore v1.0.1+

How to install

1) Simply place the module under the modules folder of your AzerothCore source folder.

You can do clone it via git under the azerothcore/modules directory:

cd path/to/azerothcore/modules

git clone https://github.com/azerothcore/mod-duelreset.git

or you can manually download the module, unzip the DuelReset folder and place it under the azerothcore/modules directory.

2) Re-run cmake and launch a clean build of AzerothCore

That's it.

(Optional) Edit module configuration

If you need to change the module configuration, go to your server configuration folder (e.g. etc), copy duelreset.conf.dist to duelreset.conf and edit it as you prefer.

License

This module is released under the GNU AGPL license.

mod-duel-reset's People

Contributors

bytesgalore avatar francescoborzi avatar gozzim avatar helias avatar locus313 avatar nefertumm avatar pangolp avatar ultranix avatar winfidonarleyan avatar yehonal avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

mod-duel-reset's Issues

TODO list

  • add module base with configuration
  • add health/mana script
  • added a temporary basic cooldown reset
  • move health/mana reset core APIs to script
  • convert the cooldowns reset script

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Suggestion: improved cooldown reset

  • Improved cooldown reset: when duel starts it resets the player cooldowns, when duel ends it restores the cooldowns that the player had before the duel

feature: Config flags for zone/map limitations

It is currently it is possible to make use of the duel-reset anywhere in the world, which makes it easily abusable. This could be solved by setting certain zones/maps to be whitelisted.
There should be either

  • hardcoded zones where this feature works and a config flag to toggle the check for these
  • or config flags for allowed zones/maps

mod-duel-reset DC in all players

I am reporting a problem that is occurring when you have the cd reset module on the server.

the problem is this, when it resets the DC server several times in all logged in accounts, there players need to log in again, this only occurs when you have multiple accounts logged in.

module: https://github.com/azerothcore/mod-duel-reset

Azerothcore rev. fa9638a1b1f+ 2019-05-29 Master (branch ) (win64, Release)

Players can summon multiple Mechanical Dragonlings using the engineering trinket and /duel

Originally reported: chromiecraft/chromiecraft#874

WHAT CLIENT DO YOU PLAY ON?

  • enGB
  • enUS
  • other (specify)
FACTION
  • Alliance
  • Horde
CONTENT PHASE:
  • Generic
  • 1-19
  • 20-29
  • 30-39
  • 40-49
  • 50-59
CURRENT BEHAVIOUR:

Players can summon a lot of Mechanical Dragonlings by /dueling and /forfeit right after trinket usage, the npc does not disappear after using the trinket again, it just summons another one, this can lead to abuse from players against open world pve fights.
The reason this is happening is that /duel resets all your cooldowns, so the same thing might happen for all the ''summon X npc to assist you in battle'' type of trinkets.

EXPECTED BLIZZLIKE BEHAVIOUR:

The guardian that is summoned after using Mechanical Dragonling should disappear and a new one should take its place.

SOURCE: Doesn't need source, it's obvious that it's a bug.
STEPS TO REPRODUCE THE PROBLEM:
  1. get engineering and Mechanical Dragonling trinket
  2. duel someone and use the trinket
  3. /forfeit
  4. repeat step 2 and 3.
EXTRA NOTES:

Item link: https://www.wowhead.com/item=4396/mechanical-dragonling
Screenshot_9

AC HASH/COMMIT:

chromiecraft/azerothcore-wotlk@34da0cd

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:
OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Duelling outside SW does not reset mana while in druid's feral form.

When duelling someone outside of Stormwind as a druid and you're in a feral form (cat/bear), the mana is not reset to its maximum value. Health is reset normally. Mana is reset on duel start while in human form.

I did not test boomkin / tree form as I don't have those readily available as of now.

Compile warning after last core update.

Warnings in complilation after core last update.
/home/wow/azerothcore/modules/mod-premium/src/premium.cpp:120:10: warning: 'OnGossipSelect' overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
void OnGossipSelect(Player* player, Item* item, uint32 /sender/, uint32 action)

/home/wow/azerothcore/modules/mod-premium/src/premium.cpp:311:31: warning: unused variable 'trainer' [-Wunused-variable]
Creature* trainer = player->SummonCreature(HMAGE, player->GetPositionX(), player->GetPositionY(), player->GetPosition...
^
/home/wow/azerothcore/modules/mod-premium/src/premium.cpp:317:31: warning: unused variable 'trainer' [-Wunused-variable]
Creature* trainer = player->SummonCreature(APALADIN, player->GetPositionX(), player->GetPositionY(), player->GetPosit..

and many others.
sorry for my english , native language spanish

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.