The rocksdb-python from aymenjd

aymenjd / rocksdb-python Goto Github PK

View Code? Open in Web Editor NEW

Easy-to-use asynchronous rocksdb client for python.

License: MIT License

CMake 5.41% Python 33.72% C++ 60.88%

rocksdb-python's People

Contributors

Stargazers

Watchers

rocksdb-python's Issues

support value in bytes

@AYMENJD
this is a great job. but I need to put value in bytes, so I changed the source code as follows.

@@ -143,7 +144,7 @@ class RocksDB:

         return await future

-    async def put(self, options: WriteOptions, key: str, value: str) -> Response:
+    async def put(self, options: WriteOptions, key: str, value: str | bytes) -> Response:
         """Set the database entry for `key` to `value`

         Args:
@@ -166,8 +167,8 @@ class RocksDB:

         if not isinstance(key, str):
             raise TypeError("key must be str")
-        elif not isinstance(value, str):
-            raise TypeError("value must be str")
+        elif not isinstance(value, (str, bytes)):
+            raise TypeError("value must be str | bytes")
         elif not isinstance(options, WriteOptions):
             raise TypeError(f"Invalid class '{type(options).__name__}'")

can you update the source code to support value in bytes?
thanks.