ayesh / wordpress-oembed-plus Goto Github PK

Hi,

I tried to set up the plugin/create a FB app to get the keys as instruced here, but I could not add the oEmbed Product. Has this changed on Facebook's side over the years?

Thanks,
Alex

Instagram has "disable caption" / "include caption" feature for sharing embedded content.
Can you add this feature to this plugin?

You can see the SS below when want to get embedded code from the web version of Instagram.

There are two instances of values from the Database needing to be escaped:

https://github.com/Ayesh/WordPress-oEmbed-Facebook-Instagram/blob/master/src/Settings.php#L64
https://github.com/Ayesh/WordPress-oEmbed-Facebook-Instagram/blob/master/src/Settings.php#L68

I would wrap esc_attr() around the option.

Is there a way to set the App ID and App Secret network-wide on a Multisite installation? There seems to be no Settings > Writing network admin screen. I tried setting up in wp-config.php, but upon testing, it's not working on individual sites on the network.

Not a huge deal but wanted to make a note! :)

In this function:
https://github.com/Ayesh/WordPress-oEmbed-Facebook-Instagram/blob/master/src/Settings.php#L40-L45

The sanitization filter could be prone to human error.
For example, the value of AAA1938BBBB914979 would be sanitized as 1938914979 which is an integer, but maybe not what the user was expecting.

Even though most browsers are pretty good about validating the input first, it might be better to cast a type to the string like this:
return (int) $string;

Instead of:

return filter_var($string, FILTER_SANITIZE_NUMBER_INT);

That way the return value would be 0, and the user would see that something they entered was not right.

I know the app key/secret need to be saved into wp_options, but it strikes me as less secure that they are visible in cleartext. Should/could those fields (at least the secret) be marked as a password in some way in settings so it's not visible from someone seeing the screen?

Facebook alerted us that oEmbed Read is replacing oEmbed with a new app review need, amongst other changes.

Is the plugin ready for this or any updates needed?

https://developers.facebook.com/docs/plugins/oembed/

.. so that each subsite can enter their own credentials.

Sometimes embeds from Instagram and Facebook fail without a clear reason.

When checking the postmeta, there is no html in the postmeta, just {{unknown}}. When deleting all the _oembed_* values from the postmeta and trying again, the embed sometimes works and valid html is showing in the postmeta.

I suspect the API is returning an unknown response, but this is not visible anywhere. Can you give some guidance on how to debug this? For example enable a 'debug' mode that shows the api response. Thanks!

e.g. '#https?://fb.watch/*#i'=> ['https://graph.facebook.com/v8.0/oembed_video', true],

Hey there!

My instagram oembed is working with your plugin + acf but facebook posts are not showing up.

If you try to embed an Instagram Reels URL (like https://www.instagram.com/reel/CTuakCmAhU5/) you get an error message "Sorry, this content could not be embedded." but if you do a traditional Instagram post it works fine.

The AJAX call specifically returns this value: "{"code":"oembed_invalid_url","message":"Not Found","data":{"status":404}}"

Thanks for the plugin.

If I attempt to embed a video with a url of the format https://www.facebook.com/watch/?v=xxx , it does not work. (It didn't work in the past either).

Can you please add this as a valid provider - it's valid on Facebook's side, just not matched in WordPress.

Hi @Ayesh,

We're considering recommending this plugin for customers of WordPress VIP and in my review I found a problem with Instagram Embeds:

On this line:
https://github.com/Ayesh/WordPress-oEmbed-Facebook-Instagram/blob/master/oembed-plus.php#L22

There's a check for https://graph.facebook.com/v8.0/oembed_ and since Instagram is using the instagram_oembed the check fails and so the Instagram Embeds never load.

I think adding a check for the Instagram embed would fix this:

if (strpos($provider_url, 'https://graph.facebook.com/v8.0/oembed_') === false 
		|| strpos($provider_url, 'https://graph.facebook.com/v8.0/instagram_oembed') === false) {
		return $provider_url;
	}

Firstly thanks for your plugin!

Updated to wordpress 6.0 yesterday and since haven’t been able to embed any facebook videos.

Not sure if this plugin is still maintained but has really useful functionality.

Wasn't sure if it was best to post here or here, so have done both.

Thanks in advance,

Plugin does not work to embed a Facebook page in a Wordpress site. More importantly, the documentation at https://php.watch/articles/wordpress-facebook-instagram-oembed is not (now) correct. It claims "the new self-plug WordPress plugin oEmbed Plus brings back the support for Facebook and Instagram oEmbed using Facebook's new API endpoints" but if you go to Facebook, you learn that there is no longer an oembed option from Facebook "The oEmbed product has been replaced with the oEmbed Read feature. If you implemented the oEmbed product before June 8, 2021, you have until September 7, 2021 to complete App Review for the oEmbed Read feature. If you have not been approved for the oEmbed Read feature by September 7, 2021, your oEmbed implementations will fail to load."

The information on what to do to setup a Facebook App is incorrect - there is no option for "For Everything Else" and of course, no "Add Oembed" or even "Add OembedRead" option. No idea if there is any way to correct, anyone else have an idea?

@Ayesh in @mikeyarce's code sample in issue #1 , the code is:

(strpos($provider_url, 'https://graph.facebook.com/v8.0/oembed_') === false || strpos($provider_url, 'https://graph.facebook.com/v8.0/instagram_oembed') === false)

with both being ===

but in the actual plugin (see 87fc123#diff-54825a668a335a7e9908af19652bb263R24 ), it is:

strpos($provider_url, 'https://graph.facebook.com/v8.0/oembed_') === false || strpos($provider_url, 'https://graph.facebook.com/v8.0/instagram_oembed') !== false

with the === for oembed, and !== for instagram.

Is this intentionally different? Just want to confirm which is correct.