axelnennker / firefox_credentials Goto Github PK

As a website developer I want to create a new PasswordCredential object by writing e.g.:

var credential = new PasswordCredential("JaneDoe98","MfPeRQq5P3yVry68Q4KZMMhB");

Please note the difference to the current spec which requires an objects as parameter:

var credential = new PasswordCredential({
  "id": "JaneDoe98",
  "password": "MfPeRQq5P3yVry68Q4KZMMhB"
});

This is not possible with the current WebIDL.

Mozilla's WebIDL.py barfs on this constructor
http://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-credential-types-passwordcredential

WebIDL.WebIDLError: error: Dictionary argument or union argument containing a dictionary not followed by a required argument must be optional, 
 [Constructor(PasswordCredentialData data), Exposed=Window]

I think that the spec for WEBIDL is too restrictive here but will change the constructor anyways (for now) to include just the parameters from the example.

[Constructor(DOMString id, DOMString password), Exposed=Window, JSImplementation="@mozilla.org/credentials/passwordcredential;1"]
interface PasswordCredential {
  Promise<Response> send(USVString url);
};

From a cursory glance over the spec, it doesn't appear to mention interaction with existing browser extensions for credential management. Do you know if that has been discussed at all?

I've been working on a pure-JS cross-browser extension which is file-format compatible with the popular 1Password extension. I think the experience could be much better on supported pages if it integrated with browser APIs for credential management.

This might become cumbersome if LoginManager has already asked the user whether to store the credentials or not.