Consider removing kinesis connection from 'start' about aws-fluent-plugin-kinesis HOT 11 CLOSED

@wryun

Thanks for your idea. I understand your situation. In my opinion, I think we should leave it as is, because if we cannot ensure connection with Kinesis Stream at initialization, we cannot guarantee even if Kinesis Stream exists or not. Please refer to S3 plugin

I know in some case, Kinesis does not respond to initial connection ensuring, however this is not often.

What do you think?

from aws-fluent-plugin-kinesis.

But say kinesis is really unreachable (this happened to us because of a bad network configuration). Don't we still want fluentd to buffer and send logs to other places?

(maybe this is more a problem with fluentd's handling of exception in 'start'...)

from aws-fluent-plugin-kinesis.

(it's also hard to detect failed starts in this situation in upstart, because it takes a long time to crash)

from aws-fluent-plugin-kinesis.

OK, so how about disabling it as configuration option?

from aws-fluent-plugin-kinesis.

That sounds like a great idea. Or even just document this as the failure behaviour (it surprised me).

from aws-fluent-plugin-kinesis.

@wryun

OK! I will do this in next week.

from aws-fluent-plugin-kinesis.

I will do this tonight.

from aws-fluent-plugin-kinesis.

I have left Amazon last week, so I need PR from this time.

from aws-fluent-plugin-kinesis.

Added a new option by #35. Thank you for the PR, @imaifactory !

from aws-fluent-plugin-kinesis.

Thanks very much, @imaifactory and @riywo :)

from aws-fluent-plugin-kinesis.

@riywo thanks for merging :)

from aws-fluent-plugin-kinesis.