Code Monkey home page Code Monkey logo

Comments (10)

simukappu avatar simukappu commented on June 21, 2024 6

I found that google-protobuf v3.12.1+ supports Ruby 2.3+. Only v3.12.0 requires Ruby 2.5+.
https://rubygems.org/gems/google-protobuf/versions/3.12.0-universal-darwin
https://rubygems.org/gems/google-protobuf/versions/3.12.1-universal-darwin

The latest v4.0.0.rc2 also supports Ruby 2.3+
https://rubygems.org/gems/google-protobuf/versions/4.0.0.rc.2-universal-darwin

Therefore, we will remove google-protobuf gem pinning for the next fluent-plugin-kinesis version release.

from aws-fluent-plugin-kinesis.

simukappu avatar simukappu commented on June 21, 2024 2

Thank you for your feedback. We've made this plugin v3.2.2 more strict gem pinning to deal with google-protobuf requiring Ruby 2.5+. See #199 for more details. I understand the issue but we have to remove Ruby 2.4 support to permit google-protobuf 3.13.0. We would appreciate any feedback.
Thanks!

from aws-fluent-plugin-kinesis.

mindw avatar mindw commented on June 21, 2024 2

It would seem Ruby 2.4 is no longer supported:
https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/

from aws-fluent-plugin-kinesis.

cosmo0920 avatar cosmo0920 commented on June 21, 2024 1

See #199 for more details. I understand the issue but we have to remove Ruby 2.4 support to permit google-protobuf 3.13.0. We would appreciate any feedback.

Ah, please wait to drop Ruby 2.4 support.
One of the our Fluentd support service customer wants to use #208 on td-agent 3 series (which runs on Ruby 2.4).

from aws-fluent-plugin-kinesis.

haidvo avatar haidvo commented on June 21, 2024 1

I can confirm that it works with Ruby 2.7 and fluentd 1.11.4.
Thanks! πŸ‘

from aws-fluent-plugin-kinesis.

cosmo0920 avatar cosmo0920 commented on June 21, 2024

google-protobuf supported Ruby 2.7 on 3.13.0:
https://github.com/awslabs/aws-fluent-plugin-kinesis/blob/master/fluent-plugin-kinesis.gemspec#L58
I have no idea why this plugin does not permit google-protobuf 3.13.0.

from aws-fluent-plugin-kinesis.

haidvo avatar haidvo commented on June 21, 2024

Hi,

Thanks for replying!
Are there plans to drop Ruby 2.4 support?

from aws-fluent-plugin-kinesis.

cosmo0920 avatar cosmo0920 commented on June 21, 2024

Our new td-agent package which is td-agent version 4 uses Ruby 2.7 not Ruby 2.4.
And td-agent 3 which uses Ruby 2.4 is now maintenance mode.

from aws-fluent-plugin-kinesis.

simukappu avatar simukappu commented on June 21, 2024

We've just published as v3.3.0.
https://rubygems.org/gems/fluent-plugin-kinesis/versions/3.3.0

@haidah01
The new v3.3.0 passes the test with Ruby 2.7. Can you try this plugin with fluentd 1.11.2 image with Ruby 2.7 again?

from aws-fluent-plugin-kinesis.

simukappu avatar simukappu commented on June 21, 2024

GreatπŸ‘ Closing this issue.
Thank you!

from aws-fluent-plugin-kinesis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.