Code Monkey home page Code Monkey logo

ocarina's People

Contributors

jinthislife avatar marcbouchenoire avatar markseltenrijch avatar renssies avatar thierrybucco avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ocarina's Issues

Can't fetch twitter metadata

Hello Ocarina.

I would like to fetch metadata from twitter url but it doesn't work as I expected.
I was able to only get faviconURL which seems to be kind of broken and most other information was not fetched.
I would like to know if I am missing something here or some fix should be done for this library.
I tried out the code below.

     let url = URL(string: "https://twitter.com/qldhealthnews/status/1326368544985059331?s=20")

     url?.oca.fetchInformation(completionHandler: { (information, error) in
     if let information = information {
         print("Title     : \(String(describing: information.title))")
         print("URL       : \(String(describing: information.url))")
         print("imageURL  : \(String(describing: information.imageURL))")
         print("imageSize : \(String(describing: information.imageSize))")
         print("faviconURL: \(String(describing: information.faviconURL))")
         print(information)
      } else if let error = error {
         print(String(describing: error))
       }
    })

Then, I got logs below

Title     : nil
URL       : https://twitter.com/qldhealthnews/status/1326368544985059331?s=20
imageURL  : nil
imageSize : nil
faviconURL: Optional(//abs.twimg.com/favicons/twitter.ico -- https://twitter.com/qldhealthnews/status/1326368544985059331?s=20)
Ocarina.URLInformation

Swift package support

Hi there! ๐Ÿ‘‹

Thanks so much for the great work on this project! It solved a big issue I was facing getting metadata for some links. One thing I'd like to see is Swift package support, so I wanted to see if that is a possibility.

I'd also e more than happy to contribute this on a PR as well ๐Ÿ˜„

Thanks!

Tag latest release

By tagging HEAD with with something like v1.1, consumers of this library will be able to pull down the Swift 5 updates through services like Carthage.

Not pulling the data from certain websites

Hi,

I've been trying out Ocarina on different news sites but on this one website, weirdly, it doesn't pull the og:description and other details. It only has url and originalUrl to the best of my knowledge.

https://www.philstar.com/other-sections/news-commentary/2021/07/16/2112975/necropolitics-death-and-politics-usual

which does have the headers

Screen Shot 2021-07-17 at 12 13 33 AM

yet I always get nil.

Other sites I've tried has worked so far pulling the data.

Would you know why this is and if there's a fix?

thanks,

I can not implement Ocarina into my project

I see this lib great, however I can not implement into my project

At first I try to make Ocarina framework, than drag into my objective C project. However, I can not import URL+URLInformation

Than I try to do exactly as the instruction, as I drag the Ocarina.xcodeproj into my swift project. But still error: "Value of type '(UnsafePointer?, UnsafePointer?) -> Int32' has no member 'oca'"

Can you please help me. At best, can you help me to create the framework than I can pull into my objectiveC project ? Thank you

Swift 5 update

Any chance you can update it to Swift 5 so it can be used int he latest Xcode?

404 status code does not give a failure

In OcarinaManager in taskDidComplete receiving a 404 statusCode will not execute failure block.

if let response = response, response.statusCode < 200 && response.statusCode >= 300 {

it should be response.statusCode < 200 || response.statusCode >= 300

Also it would be nice to expose HTTPURLResponse in error.UserInfo

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.