awesomes4everyone / libdivsufsort Goto Github PK

What steps will reproduce the problem?
1. download fresh svn trunk,
2. build it,
3. look at the library filename.

What is the expected output? What do you see instead?

Expected: libdivsufsort.so.3.0.1 (that's what 2.0.1 gives) or newer
Got: libdivsufsort.so.3.0.0 (like 2.0.0)

What steps will reproduce the problem?
1. Take a large file
2. Try to build a suffix array on it.

What version of the product are you using? On what operating system?
2.0.1. On Linux 2.6.18.

Is it planned to manage more than 2^31 characters in future releases of the 
software ?

Thanks.

could you add ${LIB_SUFFIX} to your lib specs ?  this seems to be the standard 
cmake way for handling multilib setups.  simple patch attached.

What steps will reproduce the problem?
1. 32-bit OS, with 2 Gb RAM or more
2. Take a file with size>=1Gb i.e. (1<<30) bytes
3. Run libdivsufsort-lite.exe BIGFILE

What is the expected output? What do you see instead?

Expected behaviour:
> sufcheck: Done.
It simply crashes instead.

What version of the product are you using? On what operating system?

libdivsufsort-lite 2.0.0 on Windows XP with 3 GB RAM.

Please provide any additional information below.

It crashes because of overflow in suftest.c , line 163:

>  SA = (int *)malloc((size_t)n * sizeof(int));

if (sizeof(size_t)==4 && sizeof(int)==4 && n>=(1<<30))
then ((size_t)n * sizeof(int))==((n&4)&((1<<32)-1))