Critical bug: AIOSEO initialize $wp_roles global variable prematurely and broke wordpress role management about all-in-one-seo-pack HOT 4 CLOSED

@congkun-ck thank you for reporting this. I agree that this isn't the best way to do things and I've already developed a fix for this.

The reason why this is currently isn't causing too many issues I think is because most WordPress sites store roles in the database and therefore they would already be accessible when we create that instance of the WP_Roles class. But it is possible to prevent the WP_Roles class from pulling data from the database and instead only use what's dynamically registered.

In any case, I wanted to check if you would like a beta build for this? If so, I'll generate one and post it here down below.

from all-in-one-seo-pack.

@arnaudbroes thanks for the quick response, Arnaud.
I made a quick mitigation on my website with a small plugin which just resets $current_user on setup_theme, so I am now not blocked. However I am happy to help try the beta fix.

from all-in-one-seo-pack.

@congkun-ck I've made some other changes but to fix this I basically just assigned our instance to a variable instead of the global like this -

	public function getUserRoles() {
		global $wp_roles;

		$wpRoles = $wp_roles;
		if ( ! is_object( $wpRoles ) ) {
			// Don't assign this to the global because otherwise WordPress won't override it.
			$wpRoles = new \WP_Roles();
		}

		$roleNames = $wpRoles->get_names();
		asort( $roleNames );

		return $roleNames;
	}

from all-in-one-seo-pack.

@congkun-ck we fixed this some months ago in version 4.1.5 so I'll close the issue now.

from all-in-one-seo-pack.