awesomemotive / all-in-one-seo-pack Goto Github PK

Avoid unused local variables such as '$wp_version'.

https://codeclimate.com/github/mrtorbert/all-in-one-seo-pack/modules/aioseop_sitemap.php#issue_56d398d289f28d000110e25a

For WooCommerce customers, they should get a notice like:

"we've detected you are running woo commerce... Upgrade to pro for increased SEO compatibility with your woo commerce products"

Please add a crawl-delay option to the Rule Type dropdown in the Robots.txt module so that users can add a directive like the example below using our module:

User-agent: bingbot
Crawl-delay: 10

This was first requested here - https://wordpress.org/support/topic/robotstxt-file-is-not-updating-correctly-in-multisite

When you try to activate Pro and Free at the same time you should get this warning:

All in One SEO Pack detected a conflict; please deactivate the plugin located in /home/internal/public_html/smortiboy/wp-content/plugins/all-in-one-seo-pack-pro/.

We need to make this warning more friendly and helpful and we need to verify it's working correctly.

Make all of the plugin admin screens responsive so that they look better on mobile.

It should be obvious that these fields are for AIOSEOP and not built into WP or from another plugin. related to #40

We have a ton of overlapping but separate functions to handle notices. Consolidate these so all notices are using the newer and better stuff instead of our custom legacy notice system of functions. Make sure there are enough arguments for dismissible, type (warning, updated, etc)...

Update all the languages from translate.wordpress.org before going live

add tracking to the link so we know if semperplugins customers have clicked on it

Considering that register_activation_hook doesn't run on upgrade, move things out of there that need to run on upgrade.

This was first reported here - https://wordpress.org/support/topic/twitter-meta-twittercreator-should-filter-out-protocol-and-host

We use the Twitter field in the user profile (Users, Your Profile) to add the twitter:creator tag. However, most people paste the URL for their Twitter profile in that field like so https://twitter.com/wpsmort

This results in the meta tag being created as this:

We need to strip the first part of the URL so that the meta tag looks like this:

See screenshot.

Improve the labels on github

When you enable Free or Pro the Edit link disappears from every plugin in the Plugins screen. See before and after screenshots here:

Before -

After -

Remove the option and just have them show up for everyone. related to #39

Unnecessary semicolon.

https://codeclimate.com/github/mrtorbert/all-in-one-seo-pack/js/quickedit_functions.js#issue_56d398c5f018f80001119bf5

tests fixing via commit

The option under Advanced Settings for Never Shorten Long Descriptions doesn't seem to apply to Pages but it does work for Posts and CPTs. It also doesn't work when you select the Avoid Using the Excerpt option.

For details see: https://wordpress.org/support/topic/last-update-is-broke

When the open_basedir and include_path directives are both in use in the php.ini configuration, there is the possibility of filename conflicts between local and system files. The conditions are:

• Both the include_path and open_basedir directives are in use
• A file is found in an include_path dir which conflicts with a local filename
• The dir containing the conflicting file is not part of the open_basedir directory list

Under these conditions, PHP will search for include or require files in the include_dir paths before it tries local files. This does not happen if open_basedir is not enabled.

Pinterest want the article:author tag to be a name, whereas OGP and Facebook state it should be a profile (URL). We need to test and see whether changing this to accommodate both with work.

See these forum posts -
https://wordpress.org/support/topic/ogauthor-not-showing
https://wordpress.org/support/topic/questions-about-the-open-graph-meta-propertyarticleauthor-tag-in-jetpack-28

-Add ability (autodetect? button?) to migrate pre-4.4 custom taxonomy term meta over to built-in 4.4 taxonomy term meta...
-maybe make requirement for tax term meta functionality 4.4? or should we use the old method for pre-4.4?
because we're currently checking for the existence of the tax term meta functions first, any tax term meta entered pre-4.4 will probably no longer be showing up post upgrade to 4.4

Review what we need to do to add support for the new Google Analytics 360 Suite.

If we're going to improve helptext, we should do it in enough time before going live with the next release, so we can push the changed strings to trunk on .org so the translators start working on them while still in dev.

Add sitemap support for pages created using the AMP plugin - https://wordpress.org/plugins/amp/

Pages created using this plugin should be listed in our XML sitemap.

we need to fix that broken thing

When you select the WooCommerce Shop page as the home page under Settings, Reading, the Title tag is taken from the latest product, not the Title setting for that page.

Add a hook so that people with custom tables or whatever source of information can programatically add URLs to the sitemap.

this is to test closing an issue

Have some sort of logging priority from Level 1 - Log Important Things through Level 10 - Log All the Things

Auto-generated meta description doesn't always work well with Chinese, because of the lack of spaces (see trim_excerpt_without_filters)... it would be near if we could rewrite this to give us 160 characters (including chinese charactors) similar to wp_trim_words but with characters

In certain situations the WooCommerce notification returns when you dismiss it and visit another admin screen. This only happens on rare occasions and needs to be tested thoroughly.

We've had two forum posts about Bad Bot Blocker blocking bots that are not in our list and that should not be blocked. Please refer to these forum posts -

https://wordpress.org/support/topic/bad-bot-blocker-a-few-questions
http://semperplugins.com/support/troubleshooting-all-in-one-seo-pack-pro/bad-bot-blocker-blocking-stripe-merchant-processor-requests/

In the cases above, Bad Bot Blocker appears to be blocking the user agents DoCoMo/2.0 and Stripe/1.0. The first one is a valid GoogleBot and the second is for Stripe Payment Gateway. In both cases the users report that deactivating our Bad Bot Blocker module resolves the problem.

We need a code review of the Bad Bot Blocker to ensure that we're not unintentionally blocking bots.

The preview snippet's URL doesn't update with the permalink until the post is published

The character counter is showing the number of characters for HTML codes in the Site Title rather than the number of characters for that character (i.e. & shows as 5 characters when & is only one character)

The screenshot below shows an & in my Site Title:

The screenshot below shows the character counter thinks the site title is 33 characters instead of 28:

Adjust the wording to whatever you like on the new importer feature.
It's all located in admin/meta_import.php

We should store this better so that we can eventually have lots of notices.

We can remove some options and just have that functionality enabled by default for everyone. If needed, we can make an API hook to remove them.

See #39 and #40

Update the blue admin pointer to have a general message if we don't have anything good to add.
Put the code for it somewhere easy to get to so that it can be easily edited for a new release.
Make each sentence/thought localized separately, so that the entire thing doesn't have to be retranslated.

The class AIOSEOP_CommonStrings is not named in CamelCase.

https://codeclimate.com/github/mrtorbert/all-in-one-seo-pack/inc/commonstrings.php#issue_56d398cbf018f80001119d02

Avoid unused parameters such as '$location'.

https://codeclimate.com/github/mrtorbert/all-in-one-seo-pack/modules/aioseop_feature_manager.php#issue_56d398cef018f80001119da6

The video sitemap module should be represented on free, but marked as pro-only with an upgrade link

Notification messages that don't have a Dismiss link are appearing thinner than they should. See screenshot below.

This is because the content in the notification div is usually wrapped in a paragraph tag so that the following CSS gets applied:

.form-table td .notice p, .notice p, .notice-title, div.error p, div.updated p {
margin: .5em 0;
padding: 2px;
}

Currently this CSS rule isn't getting applied because the content inside these messages is not contained in a paragraph. Wrapping the text in a paragraph tag will resolve this issue.

Avoid unused local variables such as '$module_name'.

https://codeclimate.com/github/mrtorbert/all-in-one-seo-pack/modules/aioseop_feature_manager.php#issue_56d398ce89f28d000110e1b0

Add a filter to outgoing pro version upgrade links so that 3rd party platforms can add their affiliate URL.
Do we want the entire link filterable or just make it so they can append their affiliate URL?

When on an AIOSEOP menu page, ALL notifications have our update image... this should be narrowed down to only show up when appropriate

instead it's capitalizing everything

https://wordpress.org/support/topic/fatal-error-add_cap-on-a-non-object-in-v-231?replies=3#post-8100416

https://make.wordpress.org/core/2010/10/27/plugin-activation-hooks-no-longer-fire-for-updates/