aweber / aw-grid Goto Github PK

.aw-reverse can only be used on a row. Reduce the specificity from .aw-row.aw-reverse so that .aw-reverse can be used on non-row elements.

aw-container should have width: 100%; set so that it is full-width by default. Without it, containers will only be as wide as their contents, which is not expected functionality.

The project needs to have a README file covering the basics:

• Introduction/Description
• Motivation
• Use
• Development guidelines
• Contribution

Is important to document the code in order to ease the developer contribution.

We are going to use SASSDoc to create the code documentation (read the docs):

• Install SASSDocs
• Document variables
• Document functions
• Document mixins
• Generate documentation files

AWeber FlexBox Grid needs a shiny demo website to show its awesome capabilities. We are going to use GitHub Pages for this so the website lives in the same repository and is easy to manage and simple enough to maintain.

• Design @jordangehman
• Set development platform
• Build and Deploy

***The following pixel values are calculated from a 16px base size.

Current breakpoints
xs > 0
sm ≥ 48em (768px)
md ≥ 64em (1024px)
lg ≥ 75em (1200px)

The span xs covers is too large. An additional breakpoint is needed to allow for more control over responsive designs.

Proposed breakpoints
xs > 0
sm ≥ 30em (480px)
md ≥ 48em (768px)
lg ≥ 64em (1024px)
xl ≥ 75em (1200px)

Currently elements whose first class begins with aw-col- are targeted by Gutter Modifier classes like so:

.aw-row--gutter-double > div[class^=aw-col-] {
  padding-left: 1rem;
  padding-right: 1rem;
}

However, when Display Utility classes are used, or if any class that does not begin with aw-col- is used, the element is not targeted. For example, class="display--xs-none display--md-block aw-col-md-3 aw-col-lg-2" would not be targeted by the current attribute selector.

To fix this, use the [attribute*="value"] like this: .aw-row--gutter-double > div[class*=aw-col-]

Also make sure this issue is not affecting other modifier classes.

The project should have a continuos integration process in charge of doing:

• Verify the PR code comply with the style rules
• Run the project's unit tests
• Build and create the distribution files
• Publish the distribution files on the CDN

There is several open source continuos integration services recommended by GitHub and we can start the discussion about which one suits better our needs (all of these offer free plans for Open Source projects).

• Travis CI
• AppVeyor
• CircleCI

We want AWeber FlexBox Grid to be available as an NPM module to ease the installation process in projects using Node to manage their dependencies.