Code Monkey home page Code Monkey logo

pulsarvoip's People

Contributors

avkpol avatar

Watchers

 avatar  avatar

Forkers

progval

pulsarvoip's Issues

Shell injection vulnerability

I think there is a shell injection vulnerability here:

openKeyGen = 'cd /etc/openvpn/ && openvpn --genkey --secret key_%s' %(req_user)
openKeyTest = 'cd /etc/openvpn/ && openvpn --test-crypto --secret key_%s' %(req_user)
if request.method == 'POST':
subprocess.Popen(openKeyGen, shell=True)
subprocess.Popen(openKeyTest, shell=True)

The user name is substituted in the command without any sanitization.
A possible fix is to rewrite the code this way:

    openKeyGen = ['openvpn', '--genkey', '--secret', 'key_' + req_user]
    openKeyTest = ['openvpn', '--test-crypto', '--secret', 'key_' +req_user]
    if request.method == 'POST':
         previousDir = os.getcwd()
        os.chdir('/etc/openvpn')
        try:
            subprocess.Popen(openKeyGen)
            subprocess.Popen(openKeyTest)
        finally:
            os.chdir(previousDir)

And similarily for the rest of the code (which is currently commented)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.