pulsarvoip's People
Forkers
progvalpulsarvoip's Issues
Shell injection vulnerability
I think there is a shell injection vulnerability here:
pulsarvoip/src/pulsarvpn/views/button_handler.py
Lines 23 to 27 in bd89283
The user name is substituted in the command without any sanitization.
A possible fix is to rewrite the code this way:
openKeyGen = ['openvpn', '--genkey', '--secret', 'key_' + req_user]
openKeyTest = ['openvpn', '--test-crypto', '--secret', 'key_' +req_user]
if request.method == 'POST':
previousDir = os.getcwd()
os.chdir('/etc/openvpn')
try:
subprocess.Popen(openKeyGen)
subprocess.Popen(openKeyTest)
finally:
os.chdir(previousDir)
And similarily for the rest of the code (which is currently commented)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.