avi-perl / hebrew Goto Github PK

I wish to add Gematria to this package.
Wonder where is the best place to do it?
From my point of view it should be in the Hebrew class.
what do you think?

Hey,

Is there a way to parse the taamin. For example

Hebrew(אָדָ֛ם).taam = 'Tevir'

Thanks,

Jordan

in there documentation it doesn't properly show how to remove geresh punctuation.

I quote:

# Do not add punctuation
hs2 = Hebrew.from_number(2, geresh=False)
print(hs2)  # ב

It should say:

# Do not add punctuation
hs2 = Hebrew.from_number(2, geresh=False, punctuate=False)
print(hs2)  # ב

Thanks!

Hi there!

Thank you for this awesome library. It is very useful! I'm currently using it to create a machine-learning model for automatic niqqud.

I looked at the method Hebrew.no_niqqud, and its current form is very misleading. This method strips all of the niqqud characters from the word, but this alone doesn't make the word without niqqud.

Here is an example:
Look at the word אֹהֶל (tent). If I want to write this word without niqqud I need to add the letter ו to the word: אוהל.
Currently, the function Hebrew.no_niqud will turn the word to אהל, which is an incorrect translation.

My suggestion:
Rename the method Hebrew.no_niqqud to Hebrew.strip_niqqud. This is a much more accurate name for the method that is less misleading.
After that, create a new function named Hebrew.ctiv_male (full writing) that removes niqqud smartly, adding ו and י (vav and yud) whenever needed.

Let me know what do you think about the idea!

Trying this:

hebrew_text = "\u05d1\u05b8\u05bc\u05a3\u05d8\u05b7\u05d7 \u05d1\u05b8\u05bc\u05ad\u05d4\u05bc \u05dc\u05b5\u05a3\u05d1 \u05d1\u05b7\u05bc\u05e2\u05b0\u05dc\u05b8\u0591\u05d4\u05bc \u05d5\u05b0\u059d\u05e9\u05b8\u05c1\u05dc\u05b8\u0597\u05dc \u05dc\u05b9\u05a3\u05d0 \u05d9\u05b6\u05d7\u05b0\u05e1\u05b8\u05bd\u05e8\u05c3"
print (hebrew_text)
hebrew_text2 = Hebrew.no_taamim(hebrew_text, False, False)
print (hebrew_text2)

Error is this:

בָּ֣טַח בָּ֭הּ לֵ֣ב בַּעְלָ֑הּ וְ֝שָׁלָ֗ל לֹ֣א יֶחְסָֽר׃
Traceback (most recent call last):
  File "C:\GitHub\GetBible\CommonTransliterate.py", line 74, in <module>
    hebrew_text2 = Hebrew.no_taamim(hebrew_text, False, False)
  File "C:\GitHub\GetBible\hebrew\hebrew_obj.py", line 169, in no_taamim
    string = self.no_maqaf().string if remove_maqaf else self.string
AttributeError: 'str' object has no attribute 'string'

Same with:
hebrew_text2 = Hebrew.no_taamim(hebrew_text)
hebrew_text2 = Hebrew.no_taamim(hebrew_text, True, True)

Are you planning on adding a transliteration function? I'm working on that now.

Thanks,
Neal