avajs / ava-files Goto Github PK

This question has been in my head for a long time. I don't understand what's the point/benefit of having makeTestMatcher and makeSourceMatcher, which return functions.

Take the following example from the readme:

const isTest = avaFiles.makeTestMatcher();

isTest(filePath);
//=> true or false

const isSource = avaFiles.makeSourceMatcher();

isSource(filePath);
//=> true or false

What we could have instead:

const isTest = avaFiles.isTest(filePath);
// true or false

const isSource = avaFiles.isSource(filePath);
// true or false

The API is simpler & nicer, does not make & return functions and can be used in filter or map the same way.

Patterns starting with ./, e.g. ./test/myTest.js should be treated as test/myTest.js. Otherwise they won't match change events from Chokidar, which ends up emitting the changed paths as test/myTest.js.

avajs/ava#925 mentions the code was extracted to "allow other tools (i.e. atom-ava, linter, etc) to have access to the file selection logic."

I don't see it in atom-ava's dependencies though.

Given the tight coupling I think it's easier if we can maintain this in AVA itself. We'll have to use TAP again for tests, so that sucks, but thinking about compatibility with current AVA releases sucks more IMHO.

@avajs/core?

See avajs/ava#1026.

It seems that if a user sets files as a glob with /**/*.js, it'll pick up and run the test files as well as the files under node_modules/, helpers/, and fixtures/.

AVA's readme says those are always ignored, so it's either misleading or a bug with this module.