autowarefoundation / autoware.core Goto Github PK

Checklist

• I've read the contribution guidelines.
• I've searched other issues and no duplicate issues were found.
• I'm convinced that this is not my fault but a bug.

Description

The ros2 message unit tests related to ament_cpplint fail with Category 'whitespace/line_length' errors.

Expected behavior

ament_cpplint shouldn't give line length errors for generated message files.

Actual behavior

I was trying to generate a new messages package named autoware_control_center_msgs.

https://github.com/autowarefoundation/autoware.core/actions/runs/3913282956/jobs/6688988149#step:7:926 fails.

To replicate it on my machine I ran:
colcon test --event-handlers console_cohesion+ --packages-select autoware_control_center_msgs --ctest-args -L ".*" --executor sequential --return-code-on-test-failure
And got the same result.

The following tests FAILED:
          2 - cpplint_rosidl_generated_c (Failed)
          5 - cpplint_rosidl_typesupport_fastrtps_c (Failed)
          8 - cpplint_rosidl_generated_cpp (Failed)
         11 - cpplint_rosidl_typesupport_fastrtps_cpp (Failed)
         14 - cpplint_rosidl_typesupport_introspection_c (Failed)
         17 - cpplint_rosidl_typesupport_c (Failed)
         20 - cpplint_rosidl_typesupport_introspection_cpp (Failed)
         23 - cpplint_rosidl_typesupport_cpp (Failed)
         26 - cpplint_rosidl_generated_py (Failed)

To test other packages, I tried it for already existing messages like autoware_planning_msgs or autoware_sensing_msgs and got the same test errors.

Then created a test PR on autoware_msgs to debug, they were successful.

In following PR, I tested with exactly same package, it passed the test.

https://github.com/autowarefoundation/autoware_msgs/actions/runs/3931108667/jobs/6721941355#step:7:870 is successful.

Steps to reproduce

1. Update your system?
2. colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_EXPORT_COMPILE_COMMANDS=1 --packages-select autoware_sensing_msgs
3. colcon test --event-handlers console_cohesion+ --packages-select autoware_sensing_msgs --ctest-args -L ".*" --executor sequential --return-code-on-test-failure

It should fail the test.

Versions

• OS: Ubuntu 22.04
• ROS2: humble
• Autoware: Core/Universe

Possible causes

Maybe some update was made in humble message generation or ament_cpplint.

Additional context

No response