Code Monkey home page Code Monkey logo

Comments (5)

patrickserrano avatar patrickserrano commented on July 28, 2024

I wonder if this is related to the upgrade/install issue I ran into last week using WSL1. I didn't finish debugging but it looked like the value of $SCRIPTDIR in install.sh wasn't being set correctly which was causing the install to look in $HOME/templates instead of temp_dir/templates.

from prompt.

sjk07 avatar sjk07 commented on July 28, 2024

@patrickserrano yup that was the exact problem 😄

PR fixes the issue. dunno if it causes problems for the other OSs

from prompt.

dmccaffery avatar dmccaffery commented on July 28, 2024

I will look at the CI logs, but it definitely seems to work just fine there. :)

from prompt.

dmccaffery avatar dmccaffery commented on July 28, 2024

🎉 This issue has been resolved in version 8.2.1-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from prompt.

dmccaffery avatar dmccaffery commented on July 28, 2024

@sjk07 / @patrickserrano : this was working in ci/cd because we are invoking install.sh directly:

prompt/hack/install.sh

Line 7 in 60b9f37

./install.sh $SHELL_NAME
and we're not relying on the temp dir -- basically, the bootstrap script isn't invoked as it would clone the upstream rather than whatever changes are included in the PR (until after its merged).

There is no temp dir in this scenario and thus the default (current script path) is used. There isn't any good way to test the bootstrap script itself while going through the real execution path.

from prompt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.