gcloud-install: sources bash completion in sh/zsh about prompt HOT 9 CLOSED

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from prompt.

This is still an issue; keep it open mr stale bot!

from prompt.

Removing stale label due to activity.

from prompt.

Is there a simple way to deal with this? or is this on glcloud side?

from prompt.

its an easy fix; just hasn't been a high priority as everyone I know is using either bash or zsh (rather than a POSIX shell)

from prompt.

script is now called : install-gcloud in v8

Im a little lost on the direction to fix this then. What would be the potential fix here?

from prompt.

All scripts in src/sh/scripts should be posix compliant as we don't know what shell will be used on the distro for "sh" -- on Ubuntu, it is dash, but on macOS and many other distributions it is bash.

The install-gcloud script tests for the existence of the bash completion script and sources it, which will fail on posix shells.

To fix, we need to remove the completion check from install-gcloud entirely. This is a left over from when we only supported bash.

We're doing the completion magic today in the respective shell gcloud-path scripts anyway (to detect gcloud installs that weren't necessarily done by the prompt install-gcloud script):

and

from prompt.

note: this has a side-effect of completion not being available until after the terminal is relaunched; but gcloud's own installer doesn't include completion by default (its always a manual-op), so I don't see an obvious downside to this. We could add a message in gcloud-install that tells the caller to restart their terminal to get completion.

Alternatively, we can duplicate the gcloud-install script in zsh/bash script-dirs with the appropriate sourcing.

Or, we could do some shell detection in the install-gcloud script and source the right one; but that's more complicated than its worth, IMHO.

Lastly, we could run the $AM_PROMPT_SHELL/eval/set-gcloud-path script from the gcloud-install script (if it exists), which simplifies detection -- I think $AM_PROMPT_SHELL is always available regardless of what shell is used to invoke.

from prompt.

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

from prompt.