Inquirer uses lodash, which is huge. We can accomplish everything we're using it for with:

• https://github.com/enquirer/prompt-password
• https://github.com/enquirer/prompt-confirm
• https://github.com/enquirer/prompt-list

This will reduce the size of our dependencies by about half. There's just one issue that needs to be resolved before we can switch enquirer/prompt-password#2

When we automatically detect the repo, we should look at all git remotes and use the first one that matches wpcomvip/*. This will resolve any issues where our repo is not the "origin".

Several users hit issues installing the CLI due to having the wrong version of Node installed. Can we detect an incompatible version and message the user to give them a path forward?

Right now we filter environment_name === 'production' out of the environment list for childEnvContext, but we should really filter out parent sites. There are some edge cases where parent sites have environment_name == 'testing'.

Running sudo npm install -g @automattic/vip ends with:

prebuild-install WARN install EACCES: permission denied, access '/Users/nickdaugherty/.npm'
gyp ERR! configure error
gyp ERR! stack Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/@automattic/vip/node_modules/keytar/build'
gyp ERR! System Darwin 17.4.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/lib/node_modules/@automattic/vip/node_modules/keytar
gyp ERR! node -v v8.0.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/@automattic/vip/node_modules/keytar):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] install: `prebuild-install || node-gyp rebuild`
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1

We should open a browser to the VIP Go Dashboard's new token interface and prompt the user to copy the token.

It doesn't look like npm enforces the node version we specify in engines.

As such, we should check the system version of node against the minimum supported version and fail appropriately: https://medium.com/@adambisek/how-to-check-minimum-required-node-js-version-4a78a8855a0f

$ vip sync --app 309
Could not find any child environments for ellaminnowpea-xyz

• Change "child" to "non-production"
• Prefix with "Error:"?
• Suffix with next steps: "To set up development environment, please contact VIP Support"

I can't easily reproduce this now (I think I was in a non-Go git repo), but flagging for investigation:

$ vip sync

  ✕  Please contact VIP Support with the following error:
  TypeError: Cannot delete property '0' of [object Array]
    at Array.pop (<anonymous>)
    at Args._args2.default.argv (~/.nvm/versions/node/v8.9.4/lib/node_modules/@automattic/vip/dist/lib/cli/command.js:214:42)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

Don't allow the CLI to be installed as root because it will cause problems down the line.

There's an early query on commands that have app context. The app object that's returned ends up being passed into the command. The problem is that every command needs different things. For example, the sync command needs syncProgress. We should be able to specify the query when we define the command.

I uninstalled the vip tool with npm uninstall -g @automattic/vip, then reinstalled with npm install -g @automattic/vip and was still logged in.

I think the tool should remove all config, tokens, etc, when uninstalled, leaving a clean slate.

Can we catch this and give the operator a useful path forward?

SWTBMBP:~ simonwheatley$ npm install -g @automattic/vip
module.js:557
    throw err;
    ^

Error: Cannot find module '../lib/utils/unsupported.js'
    at Function.Module._resolveFilename (module.js:555:15)
    at Function.Module._load (module.js:482:25)
    at Module.require (module.js:604:17)
    at require (internal/module.js:11:18)
    at /usr/local/lib/node_modules/npm/bin/npm-cli.js:19:21
    at Object.<anonymous> (/usr/local/lib/node_modules/npm/bin/npm-cli.js:92:3)
    at Module._compile (module.js:660:30)
    at Object.Module._extensions..js (module.js:671:10)
    at Module.load (module.js:573:32)
    at tryModuleLoad (module.js:513:12)

1. Enter vip sync --app $APP_ID
2. Hold down return quite hard 😆
3. Confirmation shows up and "yes" is filled, effectively bypassing the confirmation

Tricky to reproduce, but by holding/hitting return you can kind of accidentally skate through the environment selection and (more worrying) the confirm step.

Perhaps we should only accept "y" or "n" for the confirm, rather than having "return" map to "yes"?

• vip pull - Pulls the repo from the wpcomvip repo
• vip push - Pushes the repo to the wpcomvip repo

Use git locally to create commits and interact with the git tree.

For example, I see api in the list.

Mostly an issue for internal use right now, but since we don't have any specific support for non-WordPress sync, we should probably exclude them from the list.

This is a bit abrupt and unclear why I need an access token:

$ vip
 This will open https://ui.go-vip.co/me/cli/2 in your web browser. Follow the instructions there to acquire an access token. Continue? (Y/n)

The vip app <app> command is not super discoverable. Usage examples should help with this.

If you're in a VIP Go repo, we'll automatically figure out what apps you might be actioning. If there's only one app, we'll assume you want to action that unless you set --app. For any destructive actions, we'll prompt for confirmation unless you set --force which requires --app.

The build process is already in place, we just need to port all the code.

https://flow.org

We have promises wrapping some async functions. It would be nice to simplify that with util.promisify. The keychain code comes to mind.

If a sync is attempted with no config it is likely there will be no good outcome, particularly for WordPress multisite. We should detect when a sync is attempted with no config, and direct the user to documentation to create some (for now, ideally we'd be much more helpful).

It turns out npm install is not great. It would be helpful to compile the CLI to a single binary so we can offer an alternative way to install it.

https://github.com/pmq20/node-packer

We should explore a fully compiled version, i.e. including V8 and maybe just building the JavaScript to a single file. In the first case, node wouldn’t even need to be installed to run it. That could become a big download and may be unnecessary though.

The dependency on node-keytar means we need a C compiler in order to install this package. Ideally we can distribute binaries of node-keytar to remove the need for a compiler.

If the network disconnects during a vip sync, there's an uncaught error. We should catch that and gracefully hide the sync progress.

What fields are important in the app list?

Apps:

• ID
• app name
• repo

Envs:

• environment name
• datacenter?
• branch? is branch different from environment name?
• current deploy?

$ vip sync --env
 Which app?
[some apps in a list]
(Move up and down to reveal more choices)

This seems unexpected, should we reject the command if no value is supplied for the parameter?

We need to ensure the libs all (except the ones specifically for CLI) work for browsers.

VIP CLi should fail if the current version is older than the n-1 version.

My test account has read access to the wpcomvip/vip-go-test-03 repo (site 103). Running sync without params throws an error instead of the environment list.

$ vip sync
Error: GraphQL error: Unauthorized

Running sync --app 103 gives the following output (unsure if related to permissions or sync issues on the site):

$ vip sync --app 103
===================================
+ app: test-03
+ environment: staging
===================================
 Are you sure you want to sync from production? Yes
Note: Someone recently ran a data sync on this site
Note: Please wait a few minutes before trying again

  syncing: test-03
     from: PRODUCTION
       to: staging


✓ Data Sync is finished for test-03

• If there are multiple apps and none is specified for the current repo, show a selection dialogue
• If the user has access to multiple apps and none is specified, show a selection dialogue
• If there are multiple environment options and none is specified, show a selection dialogue

$ vip sync --env testing
 Which app?
[some apps in a list]
(Move up and down to reveal more choices)

Should I expect the list of apps to only be those apps which have a testing environment?

This broke the auto-login stuff

https://github.com/Automattic/vip/blob/master/src/lib/cli/command.js#L21-L24

We should allow commands to define a description of what will happen during the confirmation prompt. For example, data syncs would be something like:

Syncing data from production
app: vip-test
environment: preprod

• vip app
• app context commands

When I type vip blah which is not a registered command, we output usage instructions. This is not super helpful as it doesn't really tell me what I'm doing wrong.

It would be better to show an error instead, similar to wp-cli:

$ wp blah
Error: 'blah' is not a registered wp command. See 'wp help'.

We're using inquirer for dropdowns, but it also supports confirm, password, auto-complete, and custom types. Would be good to standardize and also remove an unnecessary dependency.