automattic / themes Goto Github PK
View Code? Open in Web Editor NEWFree WordPress themes made by Automattic for WordPress.org and WordPress.com.
Home Page: https://themeshaper.com
License: GNU General Public License v2.0
Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
Home Page: https://themeshaper.com
License: GNU General Public License v2.0
Activate WooCommerece plugin and add some products.
Make sure the products have the featured or product image set.
Add one of the following shortcodes in the page a page to display: [product id="XXX"] [products]
The product image or the featured images of the product or missing. Screenshot of the issue.
Single product shortcode: http://cld.wthms.co/JPHgzb
Multiple products shortcode: http://cld.wthms.co/CLCynd
It should display product images on the page. Like this screenshot taken using the TwentySeventeen theme: http://cld.wthms.co/Faw5RP
This issue was originally reported by @SiobhyB in 4372-wpcom-themes:
The header/featured image on individual posts/pages noticeably resize upon page load.
You can see an example of this by visiting this post from the theme's demo site:
https://piquedemo.wordpress.com/2015/11/12/where-does-coffee-come-from/
The following gif is taken from loading the above page in the latest version of Chrome on macOS Sierra:
This looks to be caused by the fact that a height is set inline on the header element as well as in the theme's CSS:
@tavilla61 added a second user report:
Activate WordAds on a site + Rebalance theme
Screenshot from user's site:
https://cloudup.com/c9g4ZNqb2Tf
Will also report to adopsp2 incase issue is with them.
This was originally reported by @liviopv in 4875-wpcom-themes:
Currently, Rebalance displays the WordPress.com attribution on the left of the Footer widget area.
While this looks great when the user has only a handful of widgets (like the theme demo), it creates some unsettling white space on the left when the site has multiple or big widgets, especially when using the WordPress.com logo option for the attribution.
By pushing the attribution to the bottom of the footer and displaying the widgets across a 3-column grid, we would also be aligning the theme with the behavior found on other theme's footers.
Some P2s are configured with a fixed font, such as 14px
. I noticed this on some internal Automattic P2s. For example:
This setting ignores a user's browser font preferences, and delivers what could be a small font for users who prefer larger text.
Changing the default font-size
setting to something like em
or rem
should improve accessibility for users who prefer larger font sizing.
The gallery will show up at 30% of the expected size.
Screenshot: https://cldup.com/MxU0owmtfM.png
The gallery should fill all the space in the widget area:
Screenshot: https://cldup.com/PgNVwmhd-9.png
Checking the CSS, I noticed that this is might be caused by the fact that the class being used in the CSS of the Gallery Widget .widget-gallery
is different than the one referenced in the HTML widget_media_gallery
.
I added the CSS below to the user's site as a workaround:
.widget_media_gallery {
flex-basis: 100% !important;
}
Originally reported by @julsyd in 4844-wpcom-themes.
The slideshow generated by the [presentation] shortcode is correctly displayed on the child page.
The slideshow is not displayed correctly in the panel on the parent page using the Panel Page Template. An "This slideshow could not be started. Try refreshing the page or viewing it in another browser." error is shown instead.
The slideshow generated by the [presentation] shortcode to appear in the panel on the parent page using the Panel Page Template.
This was reproduced on a test site.
This issue was originally reported by @chad1008 in 4354-wpcom-themes:
On Gazette's home page, posts are displayed with the_content()
if there is a More Tag in use, and then the_excerpt()
if there is no More Tag:
From content.php
:
<div class="entry-summary">
<?php
if ( strpos( $post->post_content, '<!--more' ) ) {
the_content( sprintf(
/* translators: %s: Name of current post. */
wp_kses( __( 'Continue reading %s', 'gazette' ), array( 'span' => array( 'class' => array() ) ) ),
the_title( '<span class="screen-reader-text">"', '"</span>', false )
) );
} else {
the_excerpt();
}
?>
</div><!-- .entry-summary -->
In addition, images in post summaries (for the times when the_content()
is used) are hidden by the theme's CSS:
.entry-summary img {
display: none;
}
So, theoretically, if the_content()
is used, images are CSS'd away. If the_excerpt()
is used, they wouldn't be displayed anyway. There shouldn't be any images on the homepage.
The above rules do not account for images with captions, which get wrapped in <figure>
elements. Those images appear on the front page just fine.
This can be confusing for a user who uses a lot of captions, then suddenly notices a missing image when they don't caption (example forum posting).
The other issue - if an image has a caption, it will be displayed when a More tag is used. On Image and Gallery post formats, that doesn't looks so great, due to the background images that are used (I suspect this is partially why images were being hidden in the first place?)
Example of a Gallery post, with a captioned image and a More Tag on the home page:
On the original ticket, @thomasguillot commented:
It's a tricky one now... Because I'd be inclined to add
.entry-summary figure { display: none; }
to the css. But if I do that it'd affect the users already using a caption in their content...I'm not sure what we can do here apart from making the caption more readable on Gallery post format
This issue was originally reported by @chad1008 in 4202-wpcom-themes:
The Like buttons appear on the Panel Page templates in spite of page settings, except on the front page.
Originally reported by @rantoncuadrado in 4553-wpcom-themes:
Apply Dara theme to a website Under Settings, change language to Spanish.
There is theme information on the footer:
"BLOG DE WORDPRESS.COM. TEMA: DARA POR AUTOMATTIC."
There is no theme information on the footer, like when the site is using English.
This was reported for a couple themes using Dara:
It's also happening with this theme on sites set to French (reported by @rwaynick):
This was originally reported by @SiobhyB in 4867-wpcom-themes:
If you activate Pique on any WordPress.com site then add a site title and tagline, you'll notice that the tagline is hidden when viewing the site on mobile.
This is due to the following in the theme's style.css:
@media (max-width: 767px) {
.site-logo-link + .site-title, .site-description {
display: none;
}
}
The site owner loves the theme but the tagline is very important to them and they don't want it to be hidden on mobile. They want the option to display the tagline on mobile without having to upgrade or switch themes.
The Full-Width Footer widget does not render full-width unless the Page designated as the homepage is set to the "Full-Width" Page Template.
User's site was set to "Default Template"
The Full-Width Footer widget seemed to take on a narrower width and align to the left when the homepage Page template was set to "Default".
The Full-Width Footer widget should be rendered full-width regardless of the applicable Page Template for the homepage Page. Either that or this requirement should be documented in the theme guide and widget configuration settings.
Originally reported by @gpmw in 4805-wpcom-themes:
User was asked to deactivate a few of their plugins and the results were the same. The issue is now present on the demos site on mobile: https://darademo.wordpress.com/
The user has added a JavaScript workaround; they've disabled this script on a test page so the issue is still visible (linked below).
@sixhours had this feedback on the original ticket:
It looks like Photon is only requesting the smaller image size when the page first loads. The image URL:
Note the dimensions in the URL, which doesn't change until the page is refreshed:&resize=397%2C146 means 397x146 is the size requested for smaller screens initially.
(moving from 5021-wpcom-themes)
When you click "load more" on the user site, some of images stack on top of each other. Replicated in Chrome 65.0/Mac High Sierra. The issue was also discussed in this thread: pNEWy-9cT-p2
This was originally reported by @ehti in 4948-wpcom-themes:
If you view a product category page (need Woo for this) and have infinite scroll turned on, the products are duplicated/shown again when the page changes from 1 to 2, and so on.
To replicate, you need to install Woo, add some products to a category, turn on infinite scroll and then open + scroll down on that category page.
In the original ticket, @sixhours commented:
I suspect this has to do with having two separate posts_per_page counts for Infinite Scroll and WooCommerce products.
This was originally reported by @ehti in 4130-wpcom-themes:
User has embedded Pinterest boards in their posts for a certain category. As you scroll down the category page, they show up for each post.
However, as you reach page 2 on the category page, the boards stop showing up. They're still embedded in the posts, but just don't show up. Probably on other archive pages too.
Here's a gif where page 2 starts with "Brand Research: Gucci" post.
This issue was originally reported by @krutidugade in 8015-wpcom:
<ul> <li>
tagsWhen you create a list in comment, the bullets aren't displayed as theme Nucleare has this CSS
comment-list li { list-style: none; }
This CSS should be fixed in Nucleare theme so that the bullet points are visible in comments.
When a custom font is selected for the body copy on a site using the Gateway theme, and the user selects either the "small" or "tiny" font size, the layout of the posts page (blog page) appears broken, with post title breaking awkwardly, and the excerpt no longer floating to the right.
Screencast video at this link: https://cloudup.com/cSQi9WxXwsN
Same layout, with a smaller font size. Larger font sizes work as expected.
(Opening this here rather than core since it's related to one of our widgets.)
On hover, there's no contrast between the icons and the background, and there's an increased bottom border on the circles, which makes them look pretty funky:
https://cloudup.com/c7tulLdkMS0
Better contrast between the icon and background, without the extra bottom border.
No user report or follow-up required, noticed on my own as I was looking at a customer site:
Add the following code to a Custom HTML widget:
<div id="amzn-assoc-ad-97baaf2c-dea5-4d47-a1cc-e300259d271f"></div><script async src="//z-na.amazon-adsystem.com/widgets/onejs?MarketPlace=US&adInstanceId=97baaf2c-dea5-4d47-a1cc-e300259d271f"></script>
Nothing displays.
The console shows warnings The SSL certificate used to load resources from <URL> will be distrusted in M<XX>. Once distrusted, users will be prevented from loading these resources. See <URL> for more information.
with this and other themes.
Page source shows the code as it was added.
A list of Amazon products appears.
With other themes, the Page Source shows the links converted into product data.
Originally reported by @senff in 4348-wpcom-themes:
The Featured Image on the home page is being cropped inconsistently. On page load it is cropped, but when switching to iPad view, and then back to normal view, it is not cropped anymore. Even after a refresh, it stays uncropped.
Go here: https://jswbaileylaw.com/
The Featured Image is a bit cropped (you can not see the boats at the bottom of the image, first screenshot). Refreshing the page will not change this.
I tried to replicate this on a test site, but I can not seem to reproduce it. So I'm not sure if it's a bug or just a quirky edge case. Also, it only appears on Chrome/Windows, no issues on Mac.
This was originally reported by @chad1008 in 4642-wpcom-themes:
Shoreditch loads the logo image at the exact size it gets displayed (max width of 240px) which leads to a blurring effect on retina displays:
Non-retina (thunderbolt display):
Might it be possible to load the image file at a larger size and allow the existing CSS to scale it down?
Reporting user has since switched themes.
This issue was originally reported by @SiobhyB in 4975-wpcom-themes:
In the following screenshot, you can see that the following five products are repeated:
The products are still duplicated with infinite scroll turned off.
It also only seems to happen on Business sites, and doesn't happen on self-hosted sites.
I expected for all the products that I'd added to display on the Shop page, and didn't expect them to display more than once.
This is similar to #10.
This issue was originally reported by @SiobhyB in 3965-wpcom-themes:
The content width for large images on portfolio pages is overridden with Photon is active.
A similar issue was previously reported in 2720-wpcom-themes.
I was able to replicate on my test site. The code for the image was as follows with Photon disabled:
<img class="alignnone wp-image-1023 size-full image-big" src="https://bambi.mystagingwebsite.com/wp-content/uploads/2013/03/soworthloving-wallpaper.jpg" alt="I Am Worth Loving Wallpaper" width="1920" height="1200" srcset="https://bambi.mystagingwebsite.com/wp-content/uploads/2013/03/soworthloving-wallpaper.jpg 1920w, https://bambi.mystagingwebsite.com/wp-content/uploads/2013/03/soworthloving-wallpaper-300x188.jpg 300w, https://bambi.mystagingwebsite.com/wp-content/uploads/2013/03/soworthloving-wallpaper-768x480.jpg 768w, https://bambi.mystagingwebsite.com/wp-content/uploads/2013/03/soworthloving-wallpaper-1024x640.jpg 1024w" sizes="(max-width: 1920px) 100vw, 1920px">
Here's the code when Photon was enabled:
<img class="alignnone wp-image-1023 size-full" src="https://i2.wp.com/bambi.mystagingwebsite.com/wp-content/uploads/2013/03/soworthloving-wallpaper.jpg?resize=1100%2C688&ssl=1" alt="I Am Worth Loving Wallpaper" srcset="https://i2.wp.com/bambi.mystagingwebsite.com/wp-content/uploads/2013/03/soworthloving-wallpaper.jpg?w=1920&ssl=1 1920w, https://i2.wp.com/bambi.mystagingwebsite.com/wp-content/uploads/2013/03/soworthloving-wallpaper.jpg?resize=300%2C188&ssl=1 300w, https://i2.wp.com/bambi.mystagingwebsite.com/wp-content/uploads/2013/03/soworthloving-wallpaper.jpg?resize=768%2C480&ssl=1 768w, https://i2.wp.com/bambi.mystagingwebsite.com/wp-content/uploads/2013/03/soworthloving-wallpaper.jpg?resize=1024%2C640&ssl=1 1024w" sizes="(max-width: 1920px) 100vw, 1920px" width="840" height="525">
The image-big class is removed when Photon is enabled, which means that the following CSS doesn't work correctly:
@media screen and (min-width: 1220px) {
.portfolio-entry .size-full.image-big {
margin-left: -130px;
max-width: 1100px;
}
}
The above CSS class is added via illustratr.js.
This issue was originally reported by @dcoleonline in 4698-wpcom-themes:
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque a interdum nisl, non hendrerit elit. Orci varius natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Donec vestibulum, lacus et cursus vestibulum, neque nisl fermentum purus, ut interdum ligula felis blandit dui. Duis placerat fermentum tristique. Nullam rhoncus libero id sollicitudin sollicitudin. In congue placerat auctor. Etiam porttitor justo libero, in porta turpis porta eu. Duis mattis ullamcorper tellus ullamcorper vulputate. Vivamus eget velit pretium, ultricies mi a, efficitur ex. Maecenas id viverra neque. Ut ut auctor urna. Cras aliquam commodo quam. Sed sollicitudin tempor semper. Aliquam faucibus malesuada mi vel varius.
Vestibulum a nulla sed ante vestibulum tincidunt in a turpis. Praesent pulvinar elit justo, ut dignissim nulla tincidunt sit amet. Quisque ac volutpat dolor. Sed a massa purus. Ut at massa felis. Nulla dapibus fringilla lorem eget rutrum. Nullam at ligula pretium, blandit velit a, euismod metus. Nunc imperdiet nibh risus, viverra malesuada quam ultricies sit amet. Duis dictum elit sit amet sodales porttitor.
https://www.youtube.com/watch?v=oFgIBZO_T9k
div.jetpack-video-wrapper
element is being positioned somewhere other than where the video is displayed. Here is a screenshot to illustrate this:This is only happening in Safari and can't be reproduced in Chrome or Firefox. It still happens in v11.0.2, and "fixes" itself when you resize the browser window. It doesn't happen on every page load.
The user likes how the "anchor menu" in Theme Options takes visitors to panels on the main page, however he doesn't like that this excludes a traditional "Home" button to take you to the very top of the site (not just a Home panel near the top of the site).
We worked on a workaround in Slack that amounts to re-creating the menu using custom links to each of the panel items and a custom link for the Home button. The user wasn't satisfied with this workaround and wanted to request that the feature be available to have a traditional Home menu button in conjunction with the anchor menu setting.
Thanks for hearing the suggestion, Theam!
Slack discussion with KP: p1520893893000437-slack
This ticket was originally filed by @KokkieH in 4630-wpcom-themes:
In the featured content section, featured image thumbnails are off-centre, which is inconsistent with featured image thumbnails of posts in the main feed, and the single-post view. It's more noticeable with bigger featured images, it seems.
Steps to reproduce:
Result: forms come out looking pretty crappy/poorly designed/laid out, especially where radio buttons are involved.
Seen at https://design5279.wordpress.com/contact-form-test/ (Dara theme) using Firefox 58.0.2 on macOS 10.13.3
/hat tip 🤠 @beaulebens for reporting this issue at p4k3M4-2uX-p2. #dogfooding #painpoint
This appears to be a one-off instance, a couple of us couldn't replicate.
Ideally,
Add logo in Customizer
Logo appears in Live Preview and live site
Dance of joy begins.
Unfortunately, the logo is added to the customizer panel, but does not appear in preview or live.
Expected the logo to be previewed in the theme and posted live.
This issue was originally reported by @rossanafmenezes in 4994-wpcom-themes:
The user was trying to display more items on his page https://multihatclub.com/shop/ Which is only displaying 6 out of 7 at the moment.
Switching the theme to Argent fixed the issue.
@danieldudzic investigated and found the following:
This issue occurs in multiple themes and is not exclusive to Shoreditch.
I believe it happens when a theme:
- Includes the duplicate products fix:
shoreditch_woocommerce_jetpack_duplicate_products
function (Automattic/jetpack#1135)- Overrides number of products per page in Jetpack infinite scroll:
shoreditch_woocommerce_jetpack_products_per_page
- Overrides the number of products per page:
shoreditch_woocommerce_products_per_page
Shoreditch sets the number of products per page to 6.
But you can test this with Karuna for example. Karuna overrides the number of products per page to 12.
Make sure you have:
- 13 products
- Set Reading Settings > Blog pages show at most to 13
- Infinite scroll enabled
You should be able to replicate, Karuna only loading 12 products, and failing to load the 13th one.
I've tried a number of things, but wasn't able to find a solution.
I suspect that the issue might have to do with the code in
karuna_woocommerce_jetpack_duplicate_products
but definitely need a second pair of eyes on this.
Originally reported by @jenlynnemc in #4794-wpcom-themes:
Set a site to use the theme Pique, and change the language to French.
The footer credit now includes theme information.
The footer credit would not include theme information, like it does when the site is set to English.
Note: The credit is currently being hidden with Custom CSS as a work-around.
Steps to replicate:
Result: Featured page box overlaps menu and overflows its container at the bottom.
Expected: Featured page box should not overlap menu or overflow container.
Originally reported by @donalirl in 4825-wpcom-themes:
The footer credit still displays.
The footer credit should be hidden like it is when the site's in English.
The footer credit is currently being hidden using Custom CSS.
Gallery styles in the post content are overwritten when multiple images are added in place of a single featured image.
View the post and a set of featured images should be displayed in place of a featured image. Click “Edit” and then add a second gallery underneath the first:
A set of images to be displayed in place of a single featured image, with a tiled mosaic gallery underneath.
The tiled mosaic gallery is output in the same format as the set of photos above. This also happens with other gallery display options, such as “Square tiles”.
In the editor (two separate display styles):
On the post (same display style):
This behaviour doesn't appear to be browser specific.
The like button does not load. Instead you see the following text in its place: Wczytywanie.... This is Polish for "Loading...".
You can switch to another language to see the button load correctly.
The browser console also includes the following error:
Uncaught Error: No locale meta information provided. at Jed.dcnpgettext (s0.wp.com/:689) at Chain.fetch (s0.wp.com/:581) at Object.updatePostFeedback (s0.wp.com/:2722) at displayPostLikeWidget (s0.wp.com/:3029) at Object.wpLikes.displayWidget [as success] (s0.wp.com/:3014) at Object.ajax (s0.wp.com/:2205) at Object.success (s0.wp.com/:2946) at s0.wp.com/:2219 at Deferred.execute (s0.wp.com/:1511) at Deferred.resolve (s0.wp.com/:1514)
I expected the button to load correctly.
I can't actually replicate this, but:
For the user, this: https://www.flickr.com/photos/127668302@N04/40695242261/in/dateposted-public/
Verified by myself and another HE, before we turned ads off. Reenabling ads makes the issue come right back. Sorry if this isn't actually a theme issue - I can't think what else it could be!
Ads showing up without blocking content.
Currently, users can't randomize their testimonials on the front page. We're using the menu order as a way to make them appear, but there's no way to make them shuffle on each new visit to the website.
Sela already has a Customize > Testimonials area, so we could also add a Randomize posts in the front page option in there.
Marking this as an enhancement for the future.
While continuing WooCommerce integration reviews I have stumbled upon a few more CSS bugs.
For the sake of consistency and general niceness, it would be beneficial to fix the following:
List of themes needing the fix:
List of themes needing the fix:
I am not sure if this should be submitted as a bug or as an enhancement request. When looking at the featured content for the Canard theme, I can only see a Category displayed beside the title. The author info (and tags and date) aren't displayed - http://cld.wthms.co/TN2MEy
If this is an expected behavior and the aforementioned are only supposed to be displayed on single posts, then this can be an enhancement request! If not, this is a bug. Tagging with needs testing so that we can determine that. Thanks!
Bringing this back over from Automattic/jetpack#6968 since this is now a core issue rather than a Jetpack issue.
This used to be an issue with Jetpack Tiled Galleries, so they added a filter to override the theme's $content_width
, however, since migrating to core's gallery widget, that filter no longer applies. There does not appear to be a similar filter in the core version of the widget, so we'll have to find another workaround.
Note the gallery does not take up the full width of the footer; it only expands as far as the theme's default $content_width
The tiled gallery should expand to the full width of the footer area.
This happens in multiple themes:
User info for follow-up:
User report: 2034075-hc
User's site: akayindustries.nl
/cc @pauljacobson
A user has gotten in touch unable to make changes to their Header Text Color
permanently save through the Customizer.
Header Text Color
is #ffffff
##3f3f3f
. The change registers in live preview mode + Inspect Element area as element style {color: rgb(63, 63, 63); }
header color
is still set to ##3f3f3f
, however, the live preview has reverted to #ffffff
and the Inspect Element area is now showing .site-title a { color: #3f3f3f; }
as crossed out.The change to the header text color did not save. But it did register when inspecting the element.
The change to the header text color to save.
For the meantime, I've sent the following to allow the user to change the color manually:
#masthead .site-title a {
color: #fff;
}
Moving from 5020-wpcom-themes /cc @Piyopiyo-Kitsune
When you have a sublinks for this theme, they cannot be clicked while on a tablet because clicking the parent link to unveil the sublinks takes you to that parent link's page.
Workarounds: Make the parent link a custom link with # for the URL.
Ideally, you can tap once on the parent link to display the sublinks and then navigate to those.
The bug was reported by a user whose site is: faribaalai.blog
I was able to replicate this on my test site: wp20170811.com
Steps for reproduction:
Originally reported by @donalirl :
A Personal plan user wanted to remove this text from the footer:
RADCLIFFE 2 PAR ANDERS NORÉN
from their site: https://julierakot.com
In the customizer, the footer is set to “WordPress.com logo” so THÈME : RADCLIFFE 2 PAR ANDERS NORÉN.
should be hidden.
Screenshot: http://cld.wthms.co/ZW8PZh
Also reported by @gugaalves :
Another site with the same issue, just have a chat with that site owner: quercypierresechefr.wordpress.com
Originally reported in 4502-wpcom-themes:
A user requested we add video header support to Lodestar.
I think it's worth investigating, and given the theme's similarities under the hood to Twenty Seventeen (being the base for that theme) it seems like it'd be relatively straightforward.
Originally reported by @brandonpayton in 4807-wpcom-themes:
The footer credit would disappear.
The footer credit still reads "von Automattic".
User noticed that footer widget area was missing and a black bar appeared on their site only when they were logged out. When inspecting the bar in dev tools, it appears to be part of the missing footer showing. The black bar is the background color of the footer.
Here it is on user's site: http://cld.wthms.co/KtJin8
It also appears when you open the customizer to view the site. The issue is not appearing on mobile/tablet size screens and is happening in different browsers (chrome, firefox, safari).
This issue was originally reported by @notnownikki in 4390-wpcom-themes:
Some category pages don't load all of the posts when you're using the Toujours theme and infinite scroll.
(Kudos to @kristarella for the detailed steps)
If infinite scroll is checked:
If infinite scroll is NOT checked:
So it seems like in this scenario, the only circumstances where the More Posts button appears and works is when the posts don't have the featured tag, or the option to show the featured tag in all listings is on.
In the initial report, https://yandsfood.com/category/luxury/ is the affected page. Clicking on Older Posts doesn't return any more posts, even though there are three posts total - one more should have appeared.
The bug was reproduced by replicating the request, using curl.
Here's a curl command that uses the same form data as the theme sends, and returns no posts:
curl -X POST -H "Content-Type application/x-www-form-urlencoded" -d 'action=infinite_scroll&page=1¤tday=01.02.17&order=DESC&styles%5B%5D=wpcom-smileys&styles%5B%5D=follow_css&styles%5B%5D=hover-bubbles&styles%5B%5D=dashicons&styles%5B%5D=thickbox&styles%5B%5D=jetpack_likes&styles%5B%5D=wordads-global&styles%5B%5D=theme-menu&styles%5B%5D=the-neverending-homepage&styles%5B%5D=wpcom-admin-bar&styles%5B%5D=noticons&styles%5B%5D=wpcom-core-compat-playlist-styles&styles%5B%5D=mp6hacks&styles%5B%5D=wpcom-bbpress2-staff-css&styles%5B%5D=toujours-style&styles%5B%5D=genericons&styles%5B%5D=toujours-wpcom&styles%5B%5D=jetpack-social-menu&styles%5B%5D=wpcom_instagram_widget&styles%5B%5D=notes-admin-bar-rest&styles%5B%5D=geo-location-flair&styles%5B%5D=reblogging&styles%5B%5D=tos-report-form&styles%5B%5D=super-admin-bar&styles%5B%5D=a8c-global-print&styles%5B%5D=wpcom-masterbar-css&styles%5B%5D=wpcom-actionbar-bar&styles%5B%5D=h4-global&styles%5B%5D=widget-achievements&styles%5B%5D=jetpack-responsive-videos-style&styles%5B%5D=jetpack-carousel&styles%5B%5D=tiled-gallery&styles%5B%5D=jetpack-carousel-ie8fix&query_args%5Bcategory_name%5D=luxury&query_args%5Berror%5D=&query_args%5Bm%5D=&query_args%5Bp%5D=0&query_args%5Bpost_parent%5D=&query_args%5Bsubpost%5D=&query_args%5Bsubpost_id%5D=&query_args%5Battachment%5D=&query_args%5Battachment_id%5D=0&query_args%5Bname%5D=&query_args%5Bstatic%5D=&query_args%5Bpagename%5D=&query_args%5Bpage_id%5D=0&query_args%5Bsecond%5D=&query_args%5Bminute%5D=&query_args%5Bhour%5D=&query_args%5Bday%5D=0&query_args%5Bmonthnum%5D=0&query_args%5Byear%5D=0&query_args%5Bw%5D=0&query_args%5Btag%5D=&query_args%5Bcat%5D=106159&query_args%5Btag_id%5D=&query_args%5Bauthor%5D=&query_args%5Bauthor_name%5D=&query_args%5Bfeed%5D=&query_args%5Btb%5D=&query_args%5Bpaged%5D=0&query_args%5Bmeta_key%5D=&query_args%5Bmeta_value%5D=&query_args%5Bpreview%5D=&query_args%5Bs%5D=&query_args%5Bsentence%5D=&query_args%5Btitle%5D=&query_args%5Bfields%5D=&query_args%5Bmenu_order%5D=&query_args%5Bembed%5D=&query_args%5Bposts_per_page%5D=2&query_args%5Bignore_sticky_posts%5D=false&query_args%5Bsuppress_filters%5D=false&query_args%5Bcache_results%5D=false&query_args%5Bupdate_post_term_cache%5D=true&query_args%5Blazy_load_term_meta%5D=true&query_args%5Bupdate_post_meta_cache%5D=true&query_args%5Bpost_type%5D=&query_args%5Bnopaging%5D=false&query_args%5Bcomments_per_page%5D=50&query_args%5Bno_found_rows%5D=false&query_args%5Border%5D=DESC&last_post_date=2017-02-01+16%3A31%3A36' https://yandsfood.com/?infinity=scrolling
Further investigation revealed that any attempt to filter using the 'luxury' category (either by name or by ID) brings back nothing.
curl -X POST -H "Content-Type application/x-www-form-urlencoded" -d 'action=infinite_scroll&page=1¤tday=01.02.17&order=DESC&styles%5B%5D=wpcom-smileys&styles%5B%5D=follow_css&styles%5B%5D=hover-bubbles&styles%5B%5D=dashicons&styles%5B%5D=thickbox&styles%5B%5D=jetpack_likes&styles%5B%5D=wordads-global&styles%5B%5D=theme-menu&styles%5B%5D=the-neverending-homepage&styles%5B%5D=wpcom-admin-bar&styles%5B%5D=noticons&styles%5B%5D=wpcom-core-compat-playlist-styles&styles%5B%5D=mp6hacks&styles%5B%5D=wpcom-bbpress2-staff-css&styles%5B%5D=toujours-style&styles%5B%5D=genericons&styles%5B%5D=toujours-wpcom&styles%5B%5D=jetpack-social-menu&styles%5B%5D=wpcom_instagram_widget&styles%5B%5D=notes-admin-bar-rest&styles%5B%5D=geo-location-flair&styles%5B%5D=reblogging&styles%5B%5D=tos-report-form&styles%5B%5D=super-admin-bar&styles%5B%5D=a8c-global-print&styles%5B%5D=wpcom-masterbar-css&styles%5B%5D=wpcom-actionbar-bar&styles%5B%5D=h4-global&styles%5B%5D=widget-achievements&styles%5B%5D=jetpack-responsive-videos-style&styles%5B%5D=jetpack-carousel&styles%5B%5D=tiled-gallery&styles%5B%5D=jetpack-carousel-ie8fix' https://yandsfood.com/?infinity=scrolling
... bring back posts, but ...
curl -X POST -H "Content-Type application/x-www-form-urlencoded" -d 'action=infinite_scroll&page=1¤tday=01.02.17&order=DESC&styles%5B%5D=wpcom-smileys&styles%5B%5D=follow_css&styles%5B%5D=hover-bubbles&styles%5B%5D=dashicons&styles%5B%5D=thickbox&styles%5B%5D=jetpack_likes&styles%5B%5D=wordads-global&styles%5B%5D=theme-menu&styles%5B%5D=the-neverending-homepage&styles%5B%5D=wpcom-admin-bar&styles%5B%5D=noticons&styles%5B%5D=wpcom-core-compat-playlist-styles&styles%5B%5D=mp6hacks&styles%5B%5D=wpcom-bbpress2-staff-css&styles%5B%5D=toujours-style&styles%5B%5D=genericons&styles%5B%5D=toujours-wpcom&styles%5B%5D=jetpack-social-menu&styles%5B%5D=wpcom_instagram_widget&styles%5B%5D=notes-admin-bar-rest&styles%5B%5D=geo-location-flair&styles%5B%5D=reblogging&styles%5B%5D=tos-report-form&styles%5B%5D=super-admin-bar&styles%5B%5D=a8c-global-print&styles%5B%5D=wpcom-masterbar-css&styles%5B%5D=wpcom-actionbar-bar&styles%5B%5D=h4-global&styles%5B%5D=widget-achievements&styles%5B%5D=jetpack-responsive-videos-style&styles%5B%5D=jetpack-carousel&styles%5B%5D=tiled-gallery&styles%5B%5D=jetpack-carousel-ie8fix&query_args%5Bcategory_name%5D=luxury' https://yandsfood.com/?infinity=scrolling
... does not.
@sixhours commented:
The user has a Featured Content tag, top, which is set in Customize -> Featured Content.
"Display tag content in all listings." in this section is unchecked, so it's likely one of the posts in the Luxury category also has the "top" tag set. This appears to be true, the Plane post has the "top" tag: https://yandsfood.wordpress.com/wp-admin/edit.php?category_name=luxury
So checking "Display tag content in all listings." will fix the issue for this user, but it doesn't explain why the wrong post is missing from the listings; it should be the Plane post missing, but it's the Hotel post (the last post in the category) instead. This is likely a Jetpack Featured Content / Infinite Scroll bug, not specific to the theme.
And in another comment:
I recall hearing about an issue with Jetpack Social Menu from a premium theme shop when I was working on their review...
Normally we'd check to see if a social menu was active before turning infinite scroll off, but the Jetpack social menu is implemented after the infinite scroll scripts have already run. I wonder if this is messing up the infinite scroll implementation in all these themes.
We also had a report of a similar issue in another theme: 1827-wpcom-premium-themes, and it is reproduceable in Shoreditch, Dyad and Sketch.
Nothing is actually broken here, but while submitting this theme to wporg, I got a warning about this custom shortcode that is not allowed in the theme. This custom [flexslider_gallery]
shortcode is used to replace slideshow galleries (specifically) with a full-width flexslider slideshow that appears above the post title on single posts.
After looking into this, it appears the same functionality can be achieved using a filter on post_gallery
. A filter is a much safer approach and less code is required to achieve the exact same result.
I should note that the custom [flexslider_gallery]
shortcode is not publicly mentioned anywhere, since only the theme use it to replace the default [gallery]
shortcode when the slideshow type is selected. No users would know it even exists without digging into the code. Removing it in favor of a more wporg-friendly filter will not cause any disruption for wpcom users.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.