Code Monkey home page Code Monkey logo

Comments (7)

pbiron avatar pbiron commented on September 22, 2024 2

I've thought about it but as of this moment I'm not planning on it. One reason for that is that it doesn't have any specific support for multisite, which I think it should have before putting in the repo:

  • let admins specify default behavior network-wide
  • and override that default behavior on a site-by-site basis

from gutenberg-ramp.

dartiss avatar dartiss commented on September 22, 2024

The following code should remove the banner...

remove_action( 'try_gutenberg_panel', 'wp_try_gutenberg_panel' );

from gutenberg-ramp.

pbiron avatar pbiron commented on September 22, 2024

I just released a little plugin that gives site admins/agencies/hosting companies/etc more fine-grained control over who sees the Try Gutenberg callout (more fine-grained that the "shotgun approach" as in the comment above).

In particular, it lets site admins:

  • hide the callout for all users (i.e., the "shotgun approach")
  • hide the callout for all users that do not have edit_posts capability (see trac 41316#comment:182)
  • hide the callouot for specific users that do have edit_posts (i.e., only allow specific "trusted" users to see the callout)
  • disable Gutenberg for all users for whom the callout is hidden by the above settings

As it says in the README:

To prove to myself that showing/hiding the callout need not be an all or nothing proposition, I quickly threw together this little plugin.

I'd be happy to work with you to integrate these use-cases into Ramp...once we get 4.9.8 out the door, of course.

from gutenberg-ramp.

pyronaur avatar pyronaur commented on September 22, 2024

The direction that Gutenberg Ramp is aiming at is to eventually allow Gutenberg to be enabled for everyone, so I'm not entirely convinced it's the place for Ramp to disable any notifications at all.

The purpose of Ramp is to allow people to gradually start using Gutenberg. I don't think that removing notifications is going to facilitate that.

I do understand that people might have different workflows and intentions for how the admin UI is supposed to look like for their site. I'm happy that @pbiron made a plugin to control exactly that for people who don't want to write their own conditional to remove the notification through the filter.

We should probably test if the labels make sense though when Gutenberg is enabled through Ramp. Maybe even customize the message to reflect the enabled Ramp settings? For example, what should the message look like if Gutenberg is enabled through Ramp on Posts and Pages but no other post type? cc @maevelander

from gutenberg-ramp.

pbiron avatar pbiron commented on September 22, 2024

The direction that Gutenberg Ramp is aiming at is to eventually allow Gutenberg to be enabled for everyone, so I'm not entirely convinced it's the place for Ramp to disable any notifications at all.

Completely understand. The reason I commented on this ticket is that @pento suggested I do so.

from gutenberg-ramp.

pyronaur avatar pyronaur commented on September 22, 2024

Thanks for that! I wasn't aware of that discussion going on about the callout. My response wasn't aimed directly at your comment but as a long coming response to the issue as a whole :)

By the way - have you considered submitting the plugin to .org? I think there is still a little time left until the 4.9.8 release?

from gutenberg-ramp.

pyronaur avatar pyronaur commented on September 22, 2024

4.9.8 has been out for a while now and we still haven't removed the notification by default, so I think we can leave it as is and close the issue :)

Thanks everyone for participating.

from gutenberg-ramp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.