In settings, improve checkbox UI for enabling custom post types about gutenberg-ramp HOT 6 CLOSED

@justnorris How about this?

Moved the sentence about the function up so we don't have little bits and pieces floating everywhere.

Used admin notice style to draw attention

from gutenberg-ramp.

Thanks for raising this @klasharr

A quick and easy fix would be to add some explanatory text:

Post types that are not compatible with Gutenberg do not appear here. Learn more.

A more advanced solution would be to actually check for post types that are incompatible and display a list of them. I'd propose a simple text based list, something like this:

The following post types were found but are not compatible with Gutenberg: [list of post types] Learn more.

@klasharr and @rogertheriault both suggested displaying the incompatible post types as greyed out... my concern with that is that we're already using that style to indicate a post type which IS compatible but which is controlled by the function gutenberg_ramp_load_gutenberg() in code (overriding the UI).

@justnorris Thoughts?

from gutenberg-ramp.

@justnorris

My mistake, custom post types created by Pods, do show in the Gutenberg Ramp settings when the REST API is indeed enabled for that Pods.

from gutenberg-ramp.

Any custom post types created by using Pods, do not show up in the Gutenberg Ramp settings.

from gutenberg-ramp.

Any custom post types created by using Pods, do not show up in the Gutenberg Ramp settings.

@lukecav Are you reporting that as a false negative? ie post types created by Pods ARE compatible but not showing? Or is it just illustrating the confusion?

from gutenberg-ramp.

@lukecav I installed Pods and created a custom post type called "Super Post" and Ramp does show that post type to me if the REST option is enabled in Pods as well.

To test this out further, I disabled Ramp completely and activated Gutenberg. If a post type in Pods doesn't have REST enabled - it doesn't support Gutenberg and falls back to TinyMCE (at least for now in WordPress 4.9.6) - so I don't think the issue you saw is Ramp related. If it is - please create a new issue with steps to reproduce so that I can debug it.

@maevelander I'm working on listing out the unsupported post types to avoid confusion.

from gutenberg-ramp.