Code Monkey home page Code Monkey logo

Comments (5)

sergiught avatar sergiught commented on July 4, 2024 1

Hey @m3talsmith 👋🏻

Thanks for taking the time to raise this! We can definitely improve the contributing guidelines and the test setup. One important thing we're missing there is the fact that we require a machine to machine application already created on the test tenant that has been authorized to request access tokens for the Management API and has all the required permissions. Only then we can leverage the client's credentials to authenticate through the Auth0 CLI.

We could also take this opportunity to uniform the env var naming to AUTH0_DOMAIN, AUTH0_CLIENT_ID and AUTH0_CLIENT_SECRET so it's aligned with some of our other repos, for example: https://github.com/auth0/terraform-provider-auth0/blob/main/CONTRIBUTING.md#running-the-tests. This would make switching projects and running tests easier.

A further improvement would be the addition of another make command that would only run a single/subset of the integration tests, for example: commander test --verbose --filter "016" test/integration/users-test-cases.yaml, commander being the utility we use for our integration tests.

These combined would make for a much more improved CONTRIBUTING guidelines. Happy to know your thoughts on this and discuss further.

from auth0-cli.

m3talsmith avatar m3talsmith commented on July 4, 2024

The error is spawned from the suite run script.

This may be able to be fixed by exporting those variables in the makefile before running the script.

from auth0-cli.

m3talsmith avatar m3talsmith commented on July 4, 2024

I appreciate the sensitivity of these env variables. Perhaps we could change the CONTRIBUTING doc to reflect steps on setting them personally, avoiding the need to generate them.

from auth0-cli.

m3talsmith avatar m3talsmith commented on July 4, 2024

Thanks @sergiught ! I think we are both on the same page here. There were some minor Makefile changes made to pass the auth0 variables to the script. I'm looking for a better way to do that: definitely open to suggestions.

I'll keep PR #902 open to have code specific comments there.

I especially like the idea of having a filter on commander as that would allow us to have a minimum set of integration tests for a quick pass, and still allow us to run the full suite at a future time.

from auth0-cli.

sergiught avatar sergiught commented on July 4, 2024

Closing this down now that we have #902 merged in 💪🏻

from auth0-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.