Comments (5)
Hey @m3talsmith 👋🏻
Thanks for taking the time to raise this! We can definitely improve the contributing guidelines and the test setup. One important thing we're missing there is the fact that we require a machine to machine application already created on the test tenant that has been authorized to request access tokens for the Management API and has all the required permissions. Only then we can leverage the client's credentials to authenticate through the Auth0 CLI.
We could also take this opportunity to uniform the env var naming to AUTH0_DOMAIN
, AUTH0_CLIENT_ID
and AUTH0_CLIENT_SECRET
so it's aligned with some of our other repos, for example: https://github.com/auth0/terraform-provider-auth0/blob/main/CONTRIBUTING.md#running-the-tests. This would make switching projects and running tests easier.
A further improvement would be the addition of another make command that would only run a single/subset of the integration tests, for example: commander test --verbose --filter "016" test/integration/users-test-cases.yaml
, commander being the utility we use for our integration tests.
These combined would make for a much more improved CONTRIBUTING guidelines. Happy to know your thoughts on this and discuss further.
from auth0-cli.
The error is spawned from the suite run script.
This may be able to be fixed by exporting those variables in the makefile before running the script.
from auth0-cli.
I appreciate the sensitivity of these env variables. Perhaps we could change the CONTRIBUTING doc to reflect steps on setting them personally, avoiding the need to generate them.
from auth0-cli.
Thanks @sergiught ! I think we are both on the same page here. There were some minor Makefile
changes made to pass the auth0 variables to the script. I'm looking for a better way to do that: definitely open to suggestions.
I'll keep PR #902 open to have code specific comments there.
I especially like the idea of having a filter on commander
as that would allow us to have a minimum set of integration tests for a quick pass, and still allow us to run the full suite at a future time.
from auth0-cli.
Closing this down now that we have #902 merged in 💪🏻
from auth0-cli.
Related Issues (20)
- Can only provide 1 secret to actions HOT 3
- Change default editor for use with Windows environment HOT 4
- a0deploy export and import return error: Invalid token HOT 1
- Client credentials auth failing when no keyring HOT 6
- logs ls --number has no effect HOT 4
- preview and published page does not omit same HTML HOT 5
- auth0 organizations members list org_xxx error when outputting json HOT 1
- Swift Package Index shows it failed tests for visionOS: https://swiftpackageindex.com/auth0/Auth0.swift HOT 1
- Add capability to export logs as type csv not just json. HOT 3
- Generating token via CLI does not work with custom domains
- Unable to create an access token on Gitpod.io with the Auth0 CLI
- auth0 terraform generate command does not create imports for auth0_client_credentials resources
- Unable to create a passwordless user
- tenants list --json returns csv HOT 2
- Custom Prompt Support with "auth0 universal-login customize" command
- Auth0 - Laravel connection
- `auth0 login` should respect the `--domain` flag for personal credentials login
- `auth0 terraform generate` should use `null` instead of `{}` for empty `encryption_key` property of `auth0_client` resources
- unable to login to a different tenant HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from auth0-cli.