autarklabs / aragon-profile-old Goto Github PK

We want an easy way to build and test things in the aragon/aragon repo. This ticket is to figure out how to do that and to write documentation on that

relates to AutarkLabs/aragon-profile#29

Maybe we just throw a button in settings? Or we just add a little button on the identity badge that takes a user to the profile?

1. BasicInformationPanel
2. Cover photo
3. Activity panel
4. organization panel
5. work history

This also covers laying out the grid so it's responsive. The way that elements stack may not be intuitive so if there are any issues with the ordering refer to the designs, and then the design channel.

This should contain:

1. name
2. job title
3. description
4. date
5. show more component (separate ticket for this)

Is it doing anything at the moment? Will ask bpierre on the call today

Right now there are 3 modals:

• add/edit education history
• add/edit work history
• add/edit basic information

the structure is that there's a base layout modal, which has the close button and the business logic and renders the specific modal based on which modal is open.

The logic for this is blocked until @Quazia finishes a working version of isMember with other functionality

a modal that pops up and allows you to edit the fields of the basic information panel

No forms have their input validated now. Sane limits need to be applied - strings lengths, XSS prevention, etc.

Need to coordinate with @Quazia on this one

We'll need:

1. coin balance
2. org name
3. org image

Is this about app information going to be on IPFS?

@rkzel @Schwartz10 need to work together

Currently we return a <div> with "No Profile", but this causes the CSS to look weird:

A discussion around the strategy should take place in this issue.

Just need to figure out what prop to use for this

InformationCard

Does aragon client have an error page we can use?

The idea here is to throw random errors throughout the app in as many places as possible and see how the app reacts. I'm concerned that errors throughout the app are taking different data formats (strings or objects). Ideally, error types are the same throughout the whole app - and we have one function or component that takes props related to the error from state and renders information.

Right now we write the aragon bridge, but we will actually just need the web3 wallet from aragon/aragon

In order to do smaller PRs in the aragon/aragon repo, we need a way to hide the profile functionality, yet expose it in a dev environment

When browser is reopened (after crash or being killed) user can see profile page without data. I'm not sure what is expected, but it probably should be something different?

Steps to reproduce:

1. Be logged in to profiles,
2. Kill the browser and re-open, do not log in to MetaMask,
3. Go to the DAO and open Profile.

What should be displayed is Profile app without data, and clicking on any link ("add work" for example) will result in blank page and lots of errors like the one below:

Uncaught TypeError: Cannot read property 'image' of undefined
at ProfilePicture (ProfilePicture.js:60)

Also, "Log in" button is disabled.

this is a CSS ticket

Once we have the web3 walelt working, we should just be able to delete all of this logic

This ticket does not include the logic for clicking the add/remove buttons within this component. For now we can just console.log something

can we just delete it?

these are the individual tiles that go inside the larger panels.

EducationHistoryTile
WorkHistoryTile

This ticket relates to AutarkLabs/aragon-profile#4

@stellarmagnet will provide more details

1. Go to an account with no education history
2. add an education history
3. save

The prop educationHistoryData is marked as required in EducationHistoryTile, but its value is null.

this takes an ethereum address and calls @Quazia isMember method

Errors are displayed only in console. If something went wrong, error message needs to be displayed on FE.

this is also causing propType errors to appear in the tiles. The tiles should pull from publicProfile and forms pull from forms within 3box state

Could be a mutation issue?

The designs have a "try again" button, to reinvoke the signature if it was cancelled. This isn't implemented yet

I'm not really sure what this entails, or if we're better going off with putting this stuff in the signer panel?

Will have a better idea for this after speaking with bpierre and will update ticket

This is more of a CSS ticket to make sure that the panels are exactly the spacing according to designs

Breaking things :)

This may "work itself out" as we go. Revisit this to see if it needs to be done once other styling is complete.

The idea here is to create a HOC that passes a click handler function to whatever component or render tree gets passed through the HOC

@rkzel this could be a cool one for you to work on

We need to handle if a user is logged out of metamask or their account is locked...etc

returns true if the user is a member of the DAO, false if not