autarklabs / aragon-profile Goto Github PK
View Code? Open in Web Editor NEWComplete node modules for integration 3box profiles into the Aragon client.
Complete node modules for integration 3box profiles into the Aragon client.
We should create a new branch, and remove any webpack or rollup configs. Simply compile the code into ES5 and we'll let aragon client do the bundling
See designs
Right now the padding of all of the panels/boxes is 16px
Lets update to 20px
Call video: https://drive.google.com/drive/folders/1lSocjrj8K5MM-xoXuvaXx_61NcDd034v
Call notes (scattered):
Right now the way they do auth, sign a message for generating a main ID, and then sign a message for each space that you want to open
Doesn’t work for contract wallets
Two different keys for your contract wallets, then you want to enable both of those keys to enable your 3box
For each space that you add, you would need to double sign the first time to add that space
Have an iframe that lives account.3box.io - iframe stores the root seed and derives the key for the main identity and the seed for each space
Iframe has post message API to the app and this is handled by 3box
You want to open 3box, get an overlay over the webpage that says this app wants to get access to your 3box data. Authorize that or don’t authorize that
http://localhost:3000/#/jonnnnnny/profile/
--> the viewMode
calculation breaks here because it sees the /
and then tries to read the eth address after that.
http://localhost:3000/#/jonnnnnny/profile/ should be the same as http://localhost:3000/#/jonnnnnny/profile
Something is wrong with it, not sure quite yet what's going on or where things broke
Not sure what this entails yet. Is this what A1 wants?
will need to sync up with arthur on this one after other tickets are finished. That's why it's an 8 pointer for now.
Must:
npm link
command for local developmentnpm install @openworklabs/aragon-profile
for productionI will be working with pierre from A1 on this later this week (hopefully)
Leaving room for general QA After integrating into the aragon client
This is a larger epic, that might encompass many future tickets (in the next grant cycle too). We're going to have to adjust the current profile UI to fit the design's A1 wants for profiles. Marking this epic to house future tickets related to this.
The InformationCard
component defines many other components within its own definition, such as PopoverCard
.
I'd like to see these moved outside of the component definition, for two reasons:
For now, we can at least move these definitions to the top level of the file, each receiving their own props rather than relying on InformationCard
's props/state. If any of them seem like good candidates for moving to sibling files, that could be nice, too.
@chadoh this was assigned to you previously, but i updated the repo (and had to make a new issue). I think this is going to be pretty complicated, but it might be a good way to learn the code base. Happy to try and pair on this for a bit too.
It's something we could assign to radek too if you prefer
Currently there are technical limitations with regards to adding an organization to a user profile where the user can only add their current DAO as an "organization".
I'd like a document created in Notion that describes the following:
Currently adding an organization requires its address, not name. Since web3 itself is not present, and not supposed to be present within apps, we need to discuss and decide what way is possible and the best.
This is to make sure the types we're expecting are the types we're getting from 3box. If a type is wrong, we should just set it as empty or something
implement #16
(should show no profile state) https://projects.invisionapp.com/d/?origin=v7#/console/17511474/363316804/preview
We can likely use the iframe component the aragon client already uses, and just adjust it to take another prop that will set the allow-same-origin
header to be set in the iframe sandbox. This should be enough
The first step in merging our profiles with native aragon is to build in 3box identity resolution. We're still waiting on designs, and a better understanding of what it actually takes to pull this off + our responsibilities in that effort. Until then, we just have this epic.
After the profile save success or error, show the appropriate modal according to the design
react
, react-dom
, and styled-components
should not be bundled into the published package. Since aragon client has these dependencies, it will create conflicts when two versions are used in the client repo (and hooks will break).npm link
This is just so we can get a version out the door without the organization feature and without a "coming soon" UI
@rkzel I'm concerned that the application errors take different shapes and forms. This ticket is to do a little chaos-monkey
testing on profiles. Insert random errors in different parts of the app (just throw new Error()
throughout different operations) and see how the app responds. We should make clear what an error is in the app and how we handle it. Are errors strings or objects?
Work and education history should be descending order based on End Date, with "Present" being at the top.
If two positions are "Present" or have the same date, do the 2nd rank based on descending order of the start date.
This relates to aragon/client#855, so track issue status there with respect to implementation
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.