aullman / opentok-meet Goto Github PK

Should have a homepage that lets you choose a room and a button that lets you switch rooms for mobile.

a few streams failed to connect and it seemed to throw the whole layout engine off. screenshot provided. the top desktop screen was set to be primary using the stretch button.

This is so that we can point to a specific environment for TNW demo.

Something like:

https://meet.tokbox.com/?apiKey=...&secret=...

Should generate a room using that apiKey and secret. Then when looking up a room we should check if the apiKey and secret are specified, if they are then we use that.

Hey!

I tried meet.tokbox.com with ie11 and Windows 8.1. I already had some beta installed of your plugin, and it automatically updated. After that, a window saying "please restart your browser" (or something like that) window appeard, with an "okay" button in it.

When pressing the button, nothing happened. Is that normal?

if you place your cursor at the very first character in the editor and then hit backspace, some browsers will navigate back. it also happens if you are just trying to delete everything and are mashing the backspace just to get rid of everything (which is how i found the issue).

on other sites, some pages ask you whether you want to navigate away or not, i'm not sure how thats triggered, but i think that might be appropriate here.

this is my node.js version
/usr/local/node.js/bin/node -v
v0.10.33

error info:

TypeError: Cannot read property 'sessionId' of undefined
at /home/opensource/opentok-meet/app.js:125:40
at /home/opensource/opentok-meet/node_modules/opentok/lib/opentok.js:332:21
at Request._callback (/home/opensource/opentok-meet/node_modules/opentok/lib/client.js:48:14)
at Request.self.callback (/home/opensource/opentok-meet/node_modules/opentok/node_modules/request/request.js:373:22)
at Request.emit (events.js:98:17)
at Request. (/home/opensource/opentok-meet/node_modules/opentok/node_modules/request/request.js:1318:14)
at Request.emit (events.js:117:20)
at IncomingMessage. (/home/opensource/opentok-meet/node_modules/opentok/node_modules/request/request.js:1266:12)
at IncomingMessage.emit (events.js:117:20)
at _stream_readable.js:943:16

Right now it doesn't change the video dimensions. Just need to call layout again on streamPropertyChanged.

Right now you have to click the red "Screen Share" button in the app to stop screen sharing. Clicking Chrome's "Stop Screensharing" button just freezes the screensharing, it doesn't remove it from the UI.

This is an issue with the "dishes" room and will become an issue if we put this in meeting rooms. If you get disconnected there is no messaging, it just shows the spinning wheel. It should tell you that you've been disconnected and give you a reconnect button, or attempt to automatically reconnect.

The addition of the SD and HD separate buttons has made too wide.

Right now when you click it it goes to that URL inside the app which breaks everything. Instead it should either:

1. Launch the URL in a new window.
2. Copy the URL to your clipboard.

OpenTok supports screensharing officially now and with Firefox. Need to update this codebase.

Right now to get screen sharing to work you need to create your own screensharing extension and register it with your domain. Instructions can be found at: https://tokbox.com/opentok/tutorials/screen-sharing/js/#chrome-extension

Then you will need to replace the screensharing extension ID here: https://github.com/aullman/opentok-meet/blob/master/public/js/controllers.js#L70

It would be better if you could just add the extension ID to the config and there was documentation for setting it up in the README.

Windows 8.1, ie11

Not sure if this is supported, but the access to the camera was never asked... I was able to enter a meet.tokbox session only with mic (that worked great), but no video.

Needless to say, there is a camera installed, accessed by Skype, Chrome, FF, etc...

I have created .key and .crt files in the same directory.
But by creating a new room shows the error as mentioned here.
"1500 "Session.publish :: undefined"
OT.exception :: title: Unable to Publish (1500) msg: Session.publish :: undefined

How to solve it..?

It doesn't show up on the subscribing side. I think this is since adding the new IE javascript. I don't think it's publishing the Screen Publisher.

Request from Gustavo: change the color/blink whiteboard button if there is something in the whiteboard.

Windows 8.1, ie11
The "allow access to mic" window has a menu with all the devices configured. My computer is in spanish, so all the microphone devices start with "Micrófono XXX". The first "o" char is messed up in the dialog

Attaching screenshot

Right now if you click the "here" link it replaces the current page.

This looks like a bug in the OpenTok Plugin.

This project really needs some unit and end to end tests. Look at how Angular do it using Protractor for e2e and Karma/Jasmine for unit tests.

to the cordova app...

Right now the sessionId and token are hard-coded. Should load them from meet.tokbox.com.

When you click the "Start Archive" button you get.

ReferenceError: room is not defined
at h.RoomCtrl.$scope.startArchiving (https://meet.tokbox.com/js/controllers.js:91:30)
at https://meet.tokbox.com/js/lib/angular/angular.min.js:172:432
at https://meet.tokbox.com/js/lib/angular/angular.min.js:189:390
at h.$eval (https://meet.tokbox.com/js/lib/angular/angular.min.js:109:104)
at h.$apply (https://meet.tokbox.com/js/lib/angular/angular.min.js:109:382)
at HTMLInputElement. (https://meet.tokbox.com/js/lib/angular/angular.min.js:189:372)
at HTMLInputElement.n.event.dispatch (https://meet.tokbox.com/js/lib/jquery/dist/jquery.min.js:3:6309)
at HTMLInputElement.r.handle (https://meet.tokbox.com/js/lib/jquery/dist/jquery.min.js:3:3084)

It's only 2.8 right now.
https://codeclimate.com/github/aullman/opentok-meet

Built opentok-whiteboard today. Would be cool to get it into opentok-meet.

I am working on a mobile app with OpenTok and when I trying to run the gulp task to build for mobile I was getting errors with common-js-helpers. It looks like the Cordova side of this repo uses https://github.com/opentok/common-js-helpers.git but that is not available. Is that a private repo? Is that really needed for a mobile app?

Thanks!

Need to do some more investigating but I spent a few minutes and couldn't get the cordova app to work anymore. It doesn't seem to publish or subscribe...

The other day I found that sometimes when somebody is presenting (like during all hands meetings) and there are a 5 or 6 other participants, we observe that the presenter stream struggles to keep up with bitrate because it is competing with the subscriber streams he's seeing as well,
Would be possible to add new "presenter mode", where the person that is presenting clicks that button and automatically switch all the subscribers into restricted frame rate mode?
I think that will give us much better experiences in scenarios where there is a high priority stream over the rest.

for internal testing use at tokbox, we need to add a small disclaimer to the UI with a message along the lines of "this application is used for testing and stabilization of new platform features, you may also use opentokrtc.com for a similar experience that will not be used for testing"

https://codeclimate.com/github/aullman/opentok-meet/code?sort=covered_percent&sort_direction=desc

The layout gets funky when there is a screen being shared.

just wondering.

Right now you have to quit the app and open it again with custom url

Again, Windows 8.1 and ie11.

I have a dual monitor, and launched ie11 in one screen, but the "allow access to mic" appeared in the other screen. Attaching screenshot

This button would turn video off for yourself and everyone else. Can be useful if trying to conserve bandwidth on mobile.

Need to update them to match the new colour palette.

Get the buttons to show up. Right now they're covered by the subscribers. Unfortunately might need a permanent bar at the bottom. Buttons to include:

Add "Join" Button - pops up UI to let you join another room
Add "Hangup"/"Connect" Buttons - session.disconnect() session.connect()
Add "Unpublish" Button - session.unpublish()

Add custom URL handling to the cordova app so that eg. if you go to: otMeet://{room} the app launches and takes you into that room.

because it supports archiving now 😄

Right now you have to manually edit OpenTokMeet-Info.plist and add

    <key>CFBundleURLTypes</key>
    <array>
        <dict>
            <key>CFBundleTypeRole</key>
            <string>Viewer</string>
            <key>CFBundleURLIconFile</key>
            <string>Icon-72</string>
            <key>CFBundleURLName</key>
            <string>com.tokbox.meet</string>
            <key>CFBundleURLSchemes</key>
            <array>
                <string>otmeet</string>
            </array>
        </dict>
    </array>
    <key>UIStatusBarHidden</key>
    <true/>

I think if I made a plugin I could add these plist changes in that.

Right now /archives and /rooms are publicly accessible. Shouldn't be available to everyone, should add some auth.
http://blog.modulus.io/nodejs-and-express-basic-authentication

The animated GIF loading image looks pixelated on a retina display. Could use the ionicons loaders.

For cordova or Android on Chrome the publisher should be portrait when the device is portrait.

Black on a black background doesn't work too well.

Hey, Adam

Probably is not a hangout's issue, but there are some green stripes on the bottom of the video when playing the recorded video... Attached image with the problem