atsid / express-jefferson Goto Github PK

If the return type of the delegate middleware is not a promise and next() has not been called, then the promise proxy should invoke next()

In the code example under routes in Configuration it reads past instead of post.

We've migrated our JS coding standards to use a modified AirBnb ruleset. We should migrate the .eslint we use in newer projects here.

http://expressjs.com/api.html#app.disable

http://expressjs.com/api.html#app.get

There's a lot of boilerplate in the text of the config file itself that can be streamlined out, namely the route name and the 'path, method, and middleware' keys.

{
    routes: {
        '/things': {
            get: [retrieveThings]
            post: [createThing]
        },
        '/things/:id': {
            get: [getThing],
            put: [editThing]
            patch: [editThing]
        }
    }
}

Coffeescript fat arrow functions result in fn.length === 0. This breaks promise detection.

Let's add a 'parameteResolvers' config section that invokes app.param() http://expressjs.com/4x/api.html#app.param

{
    parameterResolvers: [{
         parameter: "id",
         resolver: (req, res, next, id) => User.findById(id).then((found) => {
             res.foundUser = found;
             next();
         });
    }],
    routes: {
        getUser: {
            method: 'GET'
            path: "/:id",
            middleware: [ // asssume req.foundUser is populated ] 
        }
    }
}

We've noticed some interesting traffic patterns on one of our applications within the last month where users are scripting against the same API endpoint every 10 seconds. We should add the capability to throttle consumers of APIs to prevent abuse patterns like this.

https://github.com/jhurliman/node-rate-limiter

http://expressjs.com/api.html#app.engine

This would allow smaller applications to simplify their boilerplate considerably, by removing manual app creation.

Ideas:

• New config section

regexRoutes: [
   {   regex: /my_regex/, middleware: [] } 
]

• Aliasing

aliases: {
   myRegex: /my_regex/
},
routes: {
    'alias::myRegex': {
         get: []
    }
}

http://expressjs.com/api.html#app.locals

e.g.

subchains: {
    processAndTransmit: [
        processEntity,
        addLinksToEntity,
        transmitEntity,
    ]
},
routes: {
    getBeer: {
        getBeer,
        'processAndTransmit'
    }
}

http://expressjs.com/api.html#app.all

https://codeclimate.com/github/atsid/express-jefferson/src/jefferson.aliasing.test.js

• The proxy should emit an error when the delegate is null
• Jefferson errors should indicate which middleware is causing errors by throwing an error that includes the middleware index.