atabel / eslint-plugin-tape Goto Github PK

Since t.end() is not required when t.plan() is called, the following test should be excluded by test-ended.

test('Mapper.insert()', t => {

  t.plan(5);

  t.throws(
    () => Mapper.insert(),
    TypeError,
    'throws `TypeError` synchronously with no arguments'
  );

  t.resolvesTo(
    Mapper.insert(null), null,
    'resolves `null` to `null`'
  );

  t.resolvesToDeep(
    Mapper.insert([]), [],
    'resolves empty array to empty array'
  );

  t.resolvesToDeep(
    Mapper.insert([null, null]), [],
    'resolves array of `null` values to an empty array'
  );

  t.resolvesToDeep(
    Mapper.insert(null, null), [],
    'resolves multiple `null` value arguments to an empty array'
  );
});

resolvesToDeep is a custom test I've monkey patched into tape.

When using test.createStream() the following error is throw:

Error: TypeError: Cannot read property 'params' of undefined
Occurred while linting xxxx/xxxxx/xxx
at Object.CallExpression (xxxxxx/node_modules/eslint-plugin-tape/rules/use-t.js:15:21)
at predefinedRules.(anonymous function) (xxxx/node_modules/eslint-plugin-tape/create-tape-rule.js:122:27)
at listeners.(anonymous function).forEach.listener (xxxxxx/node_modules/eslint/lib/util/safe-emitter.js:45:58)
at Array.forEach ()
at Object.emit (xxxxx/node_modules/eslint/lib/util/safe-emitter.js:45:38)

Using test.onFinish() raises two eslint errors:

• Unknown test modifier and
• Test was not ended

Since onFinish is an official method, that is passed a function (not a callback – so does not need to be ended) neither of these errors should be raised by the plugin.