at-point / mote_sms Goto Github PK

Just noticed in the log:

DEPRECATION WARNING:#deliveris deprecated and will be removed in Rails 5. Use#deliver_nowto deliver immediately or#deliver_laterto deliver through Active Job. (called from deliver at /Users/xxx/.rvm/gems/ruby-2.2.2/bundler/gems/mote_sms-bf78de17e24a/lib/mote_sms/transports/action_mailer_transport.rb:45)

Hey @lgavillet can you please review the following changes:

c8b652a...master

• Removal of SslTransport
• Introduction of HttpClient class instead, which is a small wrapper
• Handles overriding of fingerprint SHA1 using ENV changes, so we don't need to release a new gem
• Use SHA1 as fingerprint
• How to handle overriding or adding CA certificates using ENV too, any proposals?

At the moment the server certificates are not verified, which is bad: https://github.com/at-point/mote_sms/blob/master/lib/mote_sms/transports/mobile_technics_transport.rb#L132

1. Add option to change SSL verification settings
2. Add certificate pinning for mobile technics hosts