Code Monkey home page Code Monkey logo

Comments (5)

A-Lamia avatar A-Lamia commented on June 5, 2024

Hey thanks for the kind words and feed back, astrolight and mars are both getting a revisit soon as they need some better tuning, as for contrast though astrolight actually has the best contrast ratio out of all 3 of the themes is there somethings specific that is bothering you or you are wanting that you can't find ?

As some one who does not like light themes it would be nice to have some feed back on what you are looking for :)

NOTE: I do plan on making more themes so maybe my next light theme can be something that you like a little more, examples are also welcome :)

from astrotheme.

borisrorsvort avatar borisrorsvort commented on June 5, 2024

@A-Lamia Iโ€™m very surprised you say that astrolight has the best contrast ratio. Looking at this screenshot. The dark theme is so much more readable.
Capture dโ€™eฬcran 2023-07-23 aฬ€ 22 19 04

The best light theme I know is the one from GitHub. https://github.com/callstack/linaria/blob/520ba8da095dd879bb694ced1d9d388a3a8ac1ee/packages/shaker/src/plugins/shaker-plugin.ts

But even the nvim GitHub theme project seem to not be a able to make it identical.

from astrotheme.

A-Lamia avatar A-Lamia commented on June 5, 2024

@borisrorsvort did you perhaps send me a wrong link ?

And my comment on it having better contrast is based on a contrast algorithm for checking the perceptual contrast level between the background and text. ๐Ÿ˜€ I asked for an example because the issue may not be contrast but something else like chroma.

EDIT: Lmao, I have dark mode on you meant literally github.

from astrotheme.

A-Lamia avatar A-Lamia commented on June 5, 2024

Ok I think I understand what I'm looking it, this is a maximum contrast type of theme, it's the equivalent of having astro dark set to #000000.

By default dark themes will seem to have more contrast even at lower perceptual levels because the text it self is the brightest point and it has higher chroma value.

I'll look at exploring a high contrast light theme ๐Ÿ˜€

from astrotheme.

github-actions avatar github-actions commented on June 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

from astrotheme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.