Comments (6)
Hey, thanks for trying to use the plugin, and for reporting this!
As you noticed, I just started this, it's not even on the npm repository yet!
So far I focused on expect support only as it was my direct need. I'll fix this soon and report on this issue.
from chai-immutable.
Yes, I noticed you just started it, but I ran into it googling for chai integration with Immutable.js and I figured I'd give you the feedback. Thanks for looking into this!
from chai-immutable.
And I thank you for your feedback :-)
I'll let you know as soon as I can guarantee more stability on this. Stay tuned!
from chai-immutable.
Hey @faassen!
1bcfae6 adds support for assert.equal
. Before that, assert.strictEqual
and assert.deepEqual
would have worked since they both use the overridden base assertions, but now it's consistent across TDD and BDD interfaces.
Could you try it on your side to confirm it works as you want? I am not publishing a new version into npm until you do so, so you have to install the package from GitHub instead of npm packages: npm uninstall && npm install astorije/chai-immutable
.
I am leaving this issue open until I add support of assert.sizeOf
. After that I think I can close this issue. Do you see another assertion we could benefit from in the TDD interface?
from chai-immutable.
Actually, adding support for assert.sizeOf
was really straightforward so I did it right after, so that when you confirm you're okay with this I can publish into npm.
I close the issue because it seems to me that everything is covered for now. I'll reopen if you tell me that it doesn't match your expectations or doesn't work or needs more assertions.
from chai-immutable.
Well actually (bis), I just published this support in version 0.3.0
. My questions are still valid, but that'd be great if you can open a new issue instead of re-opening this one.
Thanks!
from chai-immutable.
Related Issues (20)
- Add support for custom messages HOT 1
- Support reference comparison HOT 8
- [email protected]" has incorrect peer dependency "immutable@^3.0.0". HOT 4
- latest immutablejs support(Is this library even alive?) HOT 5
- Dependency Dashboard
- Publish new version! HOT 3
- Replace JSCS with ESLint
- Use ES6 in the documentation HOT 1
- `not` in assertions is ignored HOT 4
- Publish version HOT 3
- App crash if receive an REMOTE_WIDGET_DRAGGING or UPDATE_WIDGET before mural is fully loaded HOT 2
- Add `.deep.include` for deep equality comparisons
- Add support for deep flag for the keys assertion
- Drop support of Node v0.10 and v0.12
- Support Chai v4's `.deep.property`
- Write comprehensive tests for `.not.property` HOT 2
- Feature request: comparison of Maps via include HOT 3
- npm WARN [email protected] requires a peer of chai@>= 2.0.0 < 4 but none was installed. HOT 9
- Investigate potential remaining items for Chai v4 support HOT 8
- Cannot find module 'immutable' HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chai-immutable.