Code Monkey home page Code Monkey logo

Comments (6)

astorije avatar astorije commented on June 15, 2024

Hey, thanks for trying to use the plugin, and for reporting this!

As you noticed, I just started this, it's not even on the npm repository yet!
So far I focused on expect support only as it was my direct need. I'll fix this soon and report on this issue.

from chai-immutable.

faassen avatar faassen commented on June 15, 2024

Yes, I noticed you just started it, but I ran into it googling for chai integration with Immutable.js and I figured I'd give you the feedback. Thanks for looking into this!

from chai-immutable.

astorije avatar astorije commented on June 15, 2024

And I thank you for your feedback :-)
I'll let you know as soon as I can guarantee more stability on this. Stay tuned!

from chai-immutable.

astorije avatar astorije commented on June 15, 2024

Hey @faassen!

1bcfae6 adds support for assert.equal. Before that, assert.strictEqual and assert.deepEqual would have worked since they both use the overridden base assertions, but now it's consistent across TDD and BDD interfaces.
Could you try it on your side to confirm it works as you want? I am not publishing a new version into npm until you do so, so you have to install the package from GitHub instead of npm packages: npm uninstall && npm install astorije/chai-immutable.

I am leaving this issue open until I add support of assert.sizeOf. After that I think I can close this issue. Do you see another assertion we could benefit from in the TDD interface?

from chai-immutable.

astorije avatar astorije commented on June 15, 2024

Actually, adding support for assert.sizeOf was really straightforward so I did it right after, so that when you confirm you're okay with this I can publish into npm.

I close the issue because it seems to me that everything is covered for now. I'll reopen if you tell me that it doesn't match your expectations or doesn't work or needs more assertions.

from chai-immutable.

astorije avatar astorije commented on June 15, 2024

Well actually (bis), I just published this support in version 0.3.0. My questions are still valid, but that'd be great if you can open a new issue instead of re-opening this one.

Thanks!

from chai-immutable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.