Comments (8)
@astorije no problem, I'll give it a try tomorrow when I have chance to test it :)
from chai-immutable.
@astorije yep I'd agree, I believe it's due to the way the object is created for comparison and something has changed in Chai.
from chai-immutable.
Is there any update on version 2?
from chai-immutable.
Hi @probedb! I stiiiill haven't finished this, I'm sorry. I'm almost there, there are a couple things left I want to look at before publishing this. Sorry about this!
In the meantime, I have just published v2.0.0-alpha.2
with the latest master
. It is compatible with Chai v4 and requires Node v6+. Could you try it (npm install --save-dev chai-immutable@next
or yarn add --dev chai-immutable@next
) and let me know if you notice anything wrong with it?
Thanks!
from chai-immutable.
@probedb, any luck?
from chai-immutable.
Hey @probedb, I have just released v2.0.0-rc.2 which hopefully is the last step before full Chai v4 support (finally!). Mind giving it a shot and letting me know if it works as expected for you?
from chai-immutable.
Sorry @astorije ended up busy! I've updated to 2.0.0-rc.2 and chai 4.1.2 and the only issues I have are: when doing:
expect(callback.args[0][0]).to.eql(new Error('something went wrong'))
I get:
AssertionError: expected [Error: something went wrong] to deeply equal [Error: something went wrong]
+ expected - actual
But I've had this before with error objects, there's 13 errors like this after the update.
from chai-immutable.
I suspect this is unrelated to chai-immutable
(or immutable
itself), therefore not with the v2 either. Do you concur?
from chai-immutable.
Related Issues (20)
- Add support for custom messages HOT 1
- Support reference comparison HOT 8
- [email protected]" has incorrect peer dependency "immutable@^3.0.0". HOT 4
- latest immutablejs support(Is this library even alive?) HOT 5
- Dependency Dashboard
- Publish new version! HOT 3
- Replace JSCS with ESLint
- Use ES6 in the documentation HOT 1
- `not` in assertions is ignored HOT 4
- Publish version HOT 3
- App crash if receive an REMOTE_WIDGET_DRAGGING or UPDATE_WIDGET before mural is fully loaded HOT 2
- Add `.deep.include` for deep equality comparisons
- Add support for deep flag for the keys assertion
- Drop support of Node v0.10 and v0.12
- Support Chai v4's `.deep.property`
- Write comprehensive tests for `.not.property` HOT 2
- Feature request: comparison of Maps via include HOT 3
- npm WARN [email protected] requires a peer of chai@>= 2.0.0 < 4 but none was installed. HOT 9
- Cannot find module 'immutable' HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chai-immutable.