asizikov / asyncsuffix Goto Github PK

Use this snippet instead:

private static bool IsTestMethod(IDeclaredElement declaredElement)
{
var utm = declaredElement.GetSolution().GetComponent();
return (declaredElement is IMethod || declaredElement is IProperty) && utm.IsElementOfKind(declaredElement, UnitTestElementKind.Test);
}

Plugin suggests to rename WebAPI actions which is not completely correct. WebAPI action name should not reflect the way how it is executed.

Example: I get a suggestion to rename CityController.Get(...) action to "GetAsync"

ReSharper has been updated recently and now ignores AsyncSuffix (no suggestions at all :( )

https://twitter.com/rducom/status/663656924844580864

If method name is something like Foo_Bar_Baz() ignore it.

Please add support for Resharper 2017.2 (wave >=9).

Thanks :)

As an option make this feature configurable

[Test]
public async Task FooWhenBoo()
{
   ///
}

AsyncSuffix plugin for ReSharper doesn't work with ReSharper's InspectCode command line tool. Maybe the "R# platform zone markers" must be fixed (see https://youtrack.jetbrains.com/issue/RSRP-436208).

The plugin is not available for R# 2017.1. Please add support for the new version.

Async Suffix package does not have ReSharper 2016.2 support (the newest version).

Tag builds should be published

Allow marking of custom types with an attribute to consider them "Task types".

From what I observed it should be enough to add an || type.HasAnAttributeThatSaysSo() to https://github.com/asizikov/AsyncSuffix/blob/master/AsyncSuffix/Analyzer/TaskExtensions.cs#L9. Admittedly, I would not know how to implement that method.

1. returnType.GetTypeElement().IsDescendantOf()

var valueProperty = storage.BindToContextLive(lifetime, ContextRange.ApplicationWide)
.GetValueProperty();

    private static bool IsTestType(IDeclaredElement declaredElement)
    {
      var utm = declaredElement.GetSolution().GetComponent<IUnitTestElementStuff>();
      return declaredElement is ITypeElement && utm.IsElementOfKind(declaredElement, UnitTestElementKind.TestContainer);
    }

    private static bool IsTestMethod(IDeclaredElement declaredElement)
    {
      var utm = declaredElement.GetSolution().GetComponent<IUnitTestElementStuff>();
      return (declaredElement is IMethod || declaredElement is IProperty) && utm.IsElementOfKind(declaredElement, UnitTestElementKind.Test);
    }

For clients of particular type only public method names matters. There is no need to suggest Async suffix for private methods. For example I have public methods which checks for arguments or states and throws exceptions immediately (these methods don't have 'async' keyword for 'fail-fast' reasons). And these methods delegate actual work to some private methods like "DoSomeActionInternal" or something like that. These method are hidden from outer client so it's pretty annoying to have suffix suggestions.
It would be nice to have some settings to turn off these suggestions for private methods.

Update AsyncMethodNameUtil

returnType.GetTypeElement().IsDescendantOf(customType);

For .nuspec tags space is a valid tag delimiter. However, you arranged commas:

<tags>async method, naming, task</tags>

As result, they are parsed incorrectly:

Please add support for ReSharper 2018.2.

Thanks

For now I just compare the end of the method name with 'Async' string. That method works ok when the suffix is just missing. However in case of typo it will produce ugly method name:

MethodAsyn() -> MethodAsynAsync().

  public Task Method |

Suggest MethodAsync name here