Code Monkey home page Code Monkey logo

ashita's Introduction

ashita
Ashita Discord Server link link

Ashita Issue Tracker

Welcome to the public Ashita issue tracker!

Here you can report bugs that you may be experiencing with Ashita, its addons/plugins, or its launcher. You can also find other information for common issues and such that others may be experiencing with Ashita as well. Please be sure to give this readme a full look over before submitting new bug reports or questions. It is always good practice to search before submitting things as your issue may already be resolved.

Looking for help/information? Be sure to check the wiki: https://github.com/AshitaXI/Ashita/wiki

Reporting Bugs

When reporting a bug, GitHub will present you with a template that we ask users to follow and fill out. This helps us not have to ask common questions inside of every ticket by having you already provide them in your main report. Please be sure to fill out the information as best as possible and where applicable. (Failure to fill out the information, or not following the directions in the template may lead to your issue being closed without response.)

To help us best help you, it is important that your bug report be as detailed as possible. Aside from filling out the template, including as much additional information as you can helps us diagnose your problem easier and faster. Additional information can be things such as screenshots, video recordings, crash dumps, etc. Anything that you think may help with fixing your issue.

Feature Requests

Want to request a feature? Make a bug report and remove the whole template. Instead of filling out the template, include information about your feature request. Information that should be included in your feature request would be things such as:

  • What part of Ashita is the feature for?
    • Ashita.dll hook.
    • Ashita.exe launcher.
    • A specific addon/plugin. (If so, which one?)
    • Other? (Website, Discord bot, etc. let us know what specifically.)
  • Description of the request.

ashita's People

Contributors

atom0s avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

johan-sorman

ashita's Issues

Add Support For New Gamepad Guid Registry Key

Feature Description

Tonight's (11.09.2023) retail update introduced several changes to the way the game client works with gamepads, as well as changes to the gamepad tool itself. The main feature of interest with this change is that the client can now specifically lock to a selected controller by its GUID.

The manner in which this has been implemented has added a new registry key padguid000 which will need to be added to Ashita to ensure it is also overridden by our boot configuration scripts.

Additional controller work may also be needed/desired depending on how other changes were implemented by SE.

Expanding the chatlog crashes the game.[BUG]

Ashita Version (Type /ashita in-game to get this.)
Ashita v4.1.0.2

FFXI Version (Type /version in-game to get this.)
Horizon FFXI

Windows Version (ie. Start > About Your PC)
Windows 11

Describe The Bug
When expanding the chatlog, the game will crash.

Steps To Reproduce
Happens whenever I open the chat window.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved.

[BUG] IDirect3DDevice8:CreatePixelShader Does not work

Ashita Version (Type /ashita in-game to get this.)
4.0.0.6

FFXI Version (Type /version in-game to get this.)
unknown

Windows Version (ie. Start > About Your PC)
19044.2846

Describe The Bug
The function IDirect3DDevice8:CreatePixelShader() does not work. It is not passing the handle outarg to the C function.

Additional Information
Line 604 of idirect3ddevice8.lua should be changed from

local res       = self.lpVtbl.CreatePixelShader(self, pFunction);

to

local res       = self.lpVtbl.CreatePixelShader(self, pFunction, handle);

Moghouse Buttons not working[BUG]

Ashita Version (Type /ashita in-game to get this.)
Ashita v4.1.0.2

FFXI Version (Type /version in-game to get this.)
Horizon FFXI

Windows Version (ie. Start > About Your PC)
Windows 11

Describe The Bug
Talked to both the nomad moogle in Mhara, and in the moghouse. Was able to select the moogle and open the moghouse menu, but when clicking enter on any of the buttons, none of them would open. The sound will signal but nothing opens.

Steps To Reproduce
Zoned in and out of the moghouse. Turned off simplelog. Was still unable to access the options in the moghouse.

Screenshots

Capture

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved.

Addons plugin crash [BUG]

Ashita Version (Type /ashita in-game to get this.)
v4.0.0.6

FFXI Version (Type /version in-game to get this.)
30221206_0

Windows Version (ie. Start > About Your PC)
10 Pro 22H2
19045.2251

Describe The Bug
The addons plugin crashes on zone ins sometimes, this time to HP#1 in western adoulin

Steps To Reproduce
Unfortunately hard to reproduce but has happened several times always after zoning to a HP crystal, this time I saved the log so I could post here, hopefully the log helps I know it is not much information. I do have the entire log saved but this is a quick screenshot of the crash/error

Screenshots

image

Add Support For Item Articles

Feature Description

A request has been made to expose item article id information to the ResourceParser and to be exposed into the IItem interface.

[BUG] onevent addon crash

Describe The Bug
After calling 'removeall' or any variant, the events table is assigned as a generic lua table on line 153. Subsequently, the next incoming text event will attempt to call 'events:ieach' on it and crash. Line 153 should be changed to assign a table using sugar libs.

addons threw an exception in event Present

Ashita Version (Type /ashita in-game to get this.)
v4.0.0.2

FFXI Version (Type /version in-game to get this.)
30211005_0 (note that /version did not work in-game, but /ver did)

Windows Version (ie. Start > About Your PC)
Windows 10 Pro 21H1

Describe The Bug
Please give a clear, full description of the bug.

addons plugin crashing. I have managed to get it to happen relatively consistently with just equipmon loaded. I have had similar issues before equipmon was available so there may be other addons that cause the issue. I have not tried to isolate other addons.

Steps To Reproduce
Please give a clear, full list of steps to reproduce the bug, if applicable.

the picture provided was produced by logging in without equipmon loaded (have experienced crash on login with equipmon in default.txt along with other addons), unloading all addons (/addon unloadall), loading equipmon, exiting moghouse, then entering moghouse.. crash occurred when entering moghouse.

Screenshots
If applicable, add screenshots to help explain your problem.

image

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved

The crash seems to occur most often when zoning, but it has also happened when accessing the auction house. I don't have any details other than I was at the AH when it happened.

Recast not registering Cascade JA [BUG]

Ashita Version (Type /ashita in-game to get this.)
4.0.0.2

FFXI Version (Type /version in-game to get this.)
30211103_1

Windows Version (ie. Start > About Your PC)
10 Home 21H1 build 19043.1348

Describe The Bug
When using the BLM job ability Cascade, recast does not display the name of the ability, but it does display the correct recast time.

Steps To Reproduce
Have recast loaded, be on BLM main, use Cascade.

Screenshots
This third displayed JA is cascade, the recast time is correct.
Igotudis_2021 11 16_214348

Additional Information
N/A

Silent Addon and Silent Alias boot options not working [BUG]

Ashita Version (Type /ashita in-game to get this.)
4.0.0.4

FFXI Version (Type /version in-game to get this.)
30211103_2

Windows Version (ie. Start > About Your PC)
10 Home, 21H1, Build 19043.1348

Describe The Bug
Setting the 'addons.silent' and 'aliases.silent' options to '1' in the boot file is still allowing addon loads/unloads and alias related messages to appear in the game chat log.

Steps To Reproduce
Set either or both the 'addons.silent' and 'aliases.silent' parameters in the boot file to '1'
Log into game, upon initial load any/all addons or aliases that are present in your startup script will show in the game chat log
You can also manually unload/load an addon after logged into the game to verify the messages will show in the game chat log
You can also manipulate aliases in the game chat to verify the messages will show in the game chat log

Screenshots
Request if needed

Additional Information
I did the same things above to the 'plugins.silent' and 'keyboard.silentbinds' options in the boot file and those both appear to be working as intended upon load in from startup script or through manual manipulation of plugins/binds while in game.

[BUG] Addon development: strange e.mode in text_in event

Ashita Version (Type /ashita in-game to get this.)
v4.0.0.4

FFXI Version (Type /version in-game to get this.)
30211225_1

Windows Version (ie. Start > About Your PC)
Windows 10 Enterprise LTSC version 1809 build 17763.2452

Describe The Bug
Some messages appear with weird e.mode instead of the expected one. I've seen this happen after loading a zone or loading/unloading/reloading any addon or plugin. This last several seconds before going back to normal until the next zone/loading/etc...
When this happens, the messages are still correctly displayed by the game (proper chat window and color).

Steps To Reproduce
Add the following in an addon:

ashita.events.register('text_in', 'text_in_callback1', function (e)
      if (e.injected) then
            return
      end
      -- tested with a simple print(e.mode) and the issue occurs too
      e.message_modified = "Mode " .. e.mode .. ": " .. e.message
end);

Then change zone or unload or load or reload an addon or plugin.

Screenshots
All Play-On-line Games Screenshot 2022 01 13 - 19 13 31 73

Additional Information
All Play-On-line Games Screenshot 2022 01 13 - 19 00 31 26

All Play-On-line Games Screenshot 2022 01 13 - 19 18 38 99

All Play-On-line Games Screenshot 2022 01 13 - 19 19 09 50

All Play-On-line Games Screenshot 2022 01 13 - 19 00 54 35

All Play-On-line Games Screenshot 2022 01 13 - 19 10 53 63

Convert `int64_t / uint64_t` Returns In Addons To `uint8_t*` Pointers

Addon / Plugin Description

Due to Lua's limitations in handling integer numbers prior to Lua 5.3, it is impossible for int64_t and uint64_t values to be returned into Lua and hold their true full values. Ashita accounts for this with some return values from the SDK / API but not all of them are adjusted.

This is a note / reminder to finish converting the other 64bit returns to instead return uint8_t* pointers that the user can then use with the respective ashita.mem.read/write calls or with LuaJIT's FFI.

Sending account id. And waiting until close window

**Date & Time:3.24.2020

**Windows Version:win7 X64

**Ashita Version (Type /aver in-game to get this.):v3

**FFXI Version (Type /ver in-game to get this.):finally (last updated )

Addon / Plugin Name (If applicable.):

Additional Information :
It can open retail and injected but
If selecting private several or commands (ffxi-bootmod\pol.exe --server 108.56.171.15 )
It can login but stop at sending account id...till close window.
It can't start the game
/Screenshots / Crashdumps:

Equipmon ammo count no updating [BUG]

Ashita Version (Type /ashita in-game to get this.)
v4.0.0.2

FFXI Version (Type /version in-game to get this.)
version 30211103_1

Windows Version (ie. Start > About Your PC)
10 Home 21H1 19043.1348

Describe The Bug
Doing some random fishing and equipmon does not update the count on my little worms.

Steps To Reproduce
just enable ammo count for equipmon and go fish

Screenshots

Beane_2021 11 11_120214

Additional Information
I assume other ammo items such as throwing items wont update either, I will check and if for some reason they do I will add comment on this issue

[BUG] itemwatch does not support new wardrobes

Describe The Bug
itemwatch cannot find items in wardrobe 5-8.

Steps To Reproduce
load itemwatch, add an item in wardrobe 5-8.

Near line 360, for x = 0, 12 should be changed to for x = 0, 16.

Bellhop crashing client with name entry[BUG]

Ashita Version (Type /ashita in-game to get this.)
4.0.0.2

FFXI Version (Type /version in-game to get this.)
version 30211103_1

Windows Version (ie. Start > About Your PC)
10 Home 21H1 19043.1288

Describe The Bug
I was trying to create an item type group but anytime I make an entry of name type and then load the plugin it crashes the client. When trying to replicate the doc example exactly i was also unable to add the wildcard type but that threw an exception error and did not crash the client. I was able to add an entry with id type and it loaded correctly. When trying to narrow down the name type conflict i tried multiple types of item names, single word, multiple word, with +1, etc. I also tried a two word item name using an underscore instead of a blank space although the example doc showed a blank space. All of these item name options just described crashed the client immediately.

Steps To Reproduce
Update the bellhop settings xml file to include an entry of name type with any item name and load the plugin
Examples:
This will crash:

<itemtypes>
<type name="Trash">
	<entry name="Pebble" />
</type>
</itemtypes>

This will throw an error but not crash (see screenshot):

<itemtypes>
<type name="Trash">
	<entry wildcard="W*Crystal" />
</type>
</itemtypes>

This will work:

<itemtypes>
<type name="Trash">
	<entry id="17296" />
</type>
</itemtypes>

Screenshots
This is the error that the wildcard type puked out:

Beane_2021 11 11_181029

Additional Information
Not sure if this helps but this also works:

<itemtypes>
<type name="Trash">
</type>
</itemtypes>

Addons plugin and client crash

Ashita Version (Type /ashita in-game to get this.)
4.1.0.0

FFXI Version (Type /version in-game to get this.)
30221224_0 - latest retail after 1/9/2023 update

Windows Version (ie. Start > About Your PC)
Windows 10 Pro 22H2 19045.2364

Describe The Bug
Addons throwing an exception when unloading some addons. Game hangs and client crashes. It seems to be related to addons that display.

Steps To Reproduce
To try to isolate the problem I loaded Ashita with the provided default.txt and minimal changes to example-retail.ini (no pivot, no sandbox). The only modifications were to name, script, 0001 and 0002 values. I ran the following commands:

  • /addon list
  • /addon load recast
  • /addon unload recast (nothing on cooldown so no display)
  • /addon reload checker
  • /addon unload move
  • /addon unload checker
  • /addon unload fps (also tried tparty as a separate experiment)

When unloading fps or tparty the exception is triggered and the client crashes. Also crashes with /addon reload tparty when tparty is already loaded.

Screenshots
image

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved.

Add Ability To Copy Chat Input Line

Feature Description

Feature requested by: Sykx#3634

The request is to be able to easily copy the current chat input line where the player is typing into chat.
Ideally, default bound to CTRL+C

This would basically be the reverse of the /paste command, ideally named /copy

Statustimers[BUG]

Ashita Version (Type /ashita in-game to get this.)
V4

FFXI Version (Type /version in-game to get this.)
30230704_2

Windows Version (ie. Start > About Your PC)

10 home
Describe The Bug
Please give a clear, full description of the bug.
Status timers is not showing anything outside my own.Target name is showing but nothing else.As per watching video I see both target and subtarget but I am not getting both either or option.I can click target name icon and lock it but again no timers only shows mine.
Steps To Reproduce
Please give a clear, full list of steps to reproduce the bug, if applicable.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved.

[BUG] Pet ability recasts not working after pet is released

Ashita Version (Type /ashita in-game to get this.)
v4.0.0.4

FFXI Version (Type /version in-game to get this.)
30211225_1

Windows Version (ie. Start > About Your PC)
W10 Version 20H2

Describe The Bug
Pet ability recast names are not returned by resource manager after the pet is dismissed. The snips below are from the recast addon in v4.

Steps To Reproduce
/load addon recast
Change to SMN, then summon and use a Blood Pact. Note the ability timer.
Release the pet. Note the ability timer name changes to (Unknown)

Screenshots
Before dismissing:
image
After dismissing:
image
(The 3 second recast is the "Release" command)

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved.

Constants to avoid magic numbers

Looking over existing addons for v3 I see them littered with magic numbers everywhere. Even in the example addon for v4, it's full of them.

Here is a good example:

if (e.id == 0x5D) then
    -- Look for /panic emotes and replace them with /wave instead.. (All via FFI)
    local ffi = require('ffi');
    local ptr = ffi.cast('uint8_t*', e.data_modified_raw);

    -- Replace the emote..
    if (ptr[0x0A] == 29) then
        ptr[0x0A] = 8;
    end        
end

If not for the comment above telling me what 0x5D meant, I would have no idea. As a software engineer new to developing addons for Ashita, this gives me pause. I imagine many people have had an interest in developing addons, seen the sheer amount of unexplained hexcodes in existing addons, and backed away slowly.

So why not introduce constants for this? Rather than 0x5D, packets.EMOTE? These kinds of features and obfuscations have helped FFXIV's Dalamud plugin library to flourish with new development.

Chatmon is extra chatty [BUG]

Ashita Version (Type /ashita in-game to get this.)
4.0.0.2

FFXI Version (Type /version in-game to get this.)
version 30211103_1

Windows Version (ie. Start > About Your PC)
10 Home 21H1 19043.1288

Describe The Bug
Most times but not all the time Chatmon will play the inventory full message upon initial log in and/or zones. I of course verified that my inventory was not full. Another thing I noticed that is semi related is Chatmon was prompting the you're being talked about audio almost every single kill at an apex party working on exemplar points.

Steps To Reproduce
For the first situation just have chatmon loaded to default settings and log in, then zone a couple times.

For the other situation I went out and tried to narrow down what was going on, I think it might be related to earning exemplar points but after killing mulltiple lv of mobs to eliminate the exemplar point theory I can't seem to narrow it down. I can only say for sure that it happens on various types of apex mobs and DI dragons. I can also say that it has nothing to do with giving the kill shot as last night I was on brd at apex camp and it was near 100% of the time but i never killed anything myself.

Screenshots
N/A

Additional Information
For the inventory full message is there way to make the check frequency pause all together during zone in/log in perhaps?

[BUG] Ashita v4 with Sandbox sends "Unknown" client version when connecting to Wings

Ashita Version (Type /ashita in-game to get this.)
Ashita_v4_-Alpha-06.10.2021 and Sandbox_v4-Alpha-_06.10.2021

FFXI Version (Type /version in-game to get this.)
30190305_0, but it's the custom Wings package

Windows Version (ie. Start > About Your PC)
Windows 10 Pro 20H2 19042.1052

Describe The Bug
I'm trying to use sandbox to connect to Wings (yes, I know...) but get kicked off with FFXI-3101 after selecting a character.

Steps To Reproduce
Create an Ashita profile with the necessary sandbox paths for Wings, try to log in with sandbox enabled.
wings_local.ini.txt

Screenshots
n/a

Additional Information
I have a local server setup and am able to reproduce the issue that way. When sandbox is enabled, the client version is apparently being sent as "Unknown". When sandbox is disabled, the client version is being sent as "30190305_0". I don't know if this is an error on my end because I don't know how the client version is obtained or how to debug this further. Let me know if there's anything you'd like me to try.

Screenshot not hiding equipmon [BUG]

Ashita Version (Type /ashita in-game to get this.)
v4.0.0.2

FFXI Version (Type /version in-game to get this.)
30211005_0

Windows Version (ie. Start > About Your PC)
10 Home 21H1 19043.1288

Describe The Bug
When using /screenshot hide with the addon equipmon loaded, the equipmon overlay still shows on screenshot taken.

Steps To Reproduce
Make sure to have the addon equipmon loaded, then in game type: /screenshot hide

Screenshots
This screenshot was taken while messing around with the repeater double quote issue the other day, i had equipmon, clock, and minimap loaded at the time. I was about to delete the file since I didnt upload for the other issue and noticed that equipmon overlay still showing up. I was able to replicate easily.

Beane_2021 11 08_144743

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved

Repeater Addon [BUG]

Ashita Version (Type /ashita in-game to get this.)
Ashita v4.0.0.2

FFXI Version (Type /version in-game to get this.)
version 30211005_0 (only /ver worked)

Windows Version (ie. Start > About Your PC)
Windows 10 Home 21H1

Describe The Bug
When using the set command for an item, the double quotes are dropped and it will not work in game because of not having the required double quotes around the item name.

Steps To Reproduce
In game use the set command for an item such as: /rp set /item "Silt Pouch" <me>
Then attempt to start with: /rp start
Then addon will not save/use the double quotes properly and the item will not be used.

Screenshots
Very simple to replicate so no screenshots were taken

Additional Information
This might be an issue in the chat library

Is it possible to copy the game text to the clipboard to make automatic translations?

Good morning, I don't know if the request is right but I apologize in advance in case I am doing it wrong.
I am asking if it is possible an addon/plugin that takes the text of the game as it appears to put it for example in the clipboard, so as to use external programs that automatically translate the text in the clipboard to other languages. For example there is something similar for Elder Scrolls Online that at each dialog the text goes into the clipboard and an external program automatically translates all the text that comes into the clipboard.
Something amazing there is for Final Fantasy XIV that automatically takes care of translating the text into the desired language and it is this: https://github.com/NightlyRevenger/TataruHelper

I have never played Final Fantasy XI and would like to start it by understanding the plot as best I can since I am not very good at English. I don't necessarily want something complex like TataruHelper, but if there is a possibility to create an addon/plugin that simply takes the text whenever it appears in game (from dialogues) and puts it in the clipboard would be of great help to me.
Thank you very much in advance!

Went to move the Y axis of the map on a larger resolution and the map disappeared. now every time i load/unload or even restart the game, i cannot see the map

Ashita Version (Type /ashita in-game to get this.)

FFXI Version (Type /version in-game to get this.)

Windows Version (ie. Start > About Your PC)

Describe The Bug
Please give a clear, full description of the bug.

Steps To Reproduce
Please give a clear, full list of steps to reproduce the bug, if applicable.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved.

[BUG] Disabling Mouse Unhooking does not work in v4

Ashita Version
v4.0.0.2

FFXI Version (Type /version in-game to get this.)
version 30190305_0

Windows Version (ie. Start > About Your PC)
Windows 10 Pro 21H1 build 19043.1237
Experience Pack 120.2212.3530.0

Describe The Bug
When mouse.unhook is set to 0, the mouse will jump to a menu when opened like you'd expect, but moving the mouse at all shows that it's actually back where it originally was. Hardware mouse is not enabled, and no plugins or addons are installed. Using /ashita, I can verify that mouse.unhook is off.

Steps To Reproduce

  1. set mouse.unhook = 0
  2. open configuration on the title screen or something else in game where the mouse jumps to an open window
  3. move mouse, it should retain where it was originally when you would expect it to be where the new menu opened up.

Screenshots

jump.mp4

Additional Information

  • This was tested with the menu resolution matching the game resolution and when set to something larger
  • Running on the WingsXI private server
  • This did function correctly in Ashita v3

Please let me know if I can add anything else!

Points addon causes addon plugin to fail when entering dynams

Ashita Version (Type /ashita in-game to get this.)
Ashita v4.1.0.0

FFXI Version (Type /version in-game to get this.)
On catseye pserver (/version does not show version)

Windows Version (ie. Start > About Your PC)
Windows 10 home os build 19044.2486 x64

Describe The Bug
Please give a clear, full description of the bug.
Upon entry to any dynamis the addons plug in throws an error and unloads and then the game crashes out. Did not have this issue on Sunday when we did dynamis city runs.

Game crash appears to be dynamis beaucidie and unloading the addon only. Dynamis Jeuno and bastok were tested and still recieve the error but the game does not crash.

Error reads as follows:
[Ashita] addons threw an exception in event Present.
Exception: EXEPTION_ACCESS_VIOLATION (C0000005).
[Ptr: 5C94105]

If I unload points it throws a new error as follows:
Addons threw an exception in event HandleCommand.
Exception: EXEPTION_ACCESS_VIOLATION (C0000005).
[Ptr: 58D7D105].

Both cause the game to crash. Dynamis crash is almost instant.
Unload crash happens shortly there after.

Steps To Reproduce
Please give a clear, full list of steps to reproduce the bug, if applicable.

I have points addon in the script so it load on start up.
I zone into dynamis and it throws the error.

I have taken it off scripts and manually loaded it in dynamis with no issue. If I leave dynamis still no issue. If I reenter dynamis the error shows up.

I came to the conclusion is was the points addon by removing each line from my script one at a time then loading into dynamis beaucidine as that is where I noticed the issue. Tried the manual loading and unloading as a work around which failed.

Screenshots
I have a screen shot on my pc but I am filling this out on my phone will add or can provide if need. Text box displays the first error listed.

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved.

[BUG] Resource Parser For Action Messages Yields Bad Strings

Ashita Version (Type /ashita in-game to get this.)

  • 4.0.0.4

FFXI Version (Type /version in-game to get this.)

  • 30220603_0

Windows Version (ie. Start > About Your PC)

  • Windows 10

Describe The Bug

Requesting action.messages strings from the ResourceManager yields bad results. The string lengths are being incorrectly handled if the string contains a mid-string null terminator which can happen on some tokenized entries.

Steps To Reproduce

Request string '1' from action.messages

Screenshots

  • N/A

Additional Information

This issue will potentially spill over to any other string DAT being parsed that contains tokenized entries with a 00 value in the token(s). Easy fix though, will get to it soon.

[BUG] Chatlog Becomes Blank/Empty After Large Amounts of Colored Output

Ashita Version (Type /ashita in-game to get this.)
4.1.0.2

FFXI Version (Type /version in-game to get this.)
Horizon

Windows Version (ie. Start > About Your PC)
Windows 10 Pro

Describe The Bug
Have been trying to pin down what was causing my chat to go blank after playing for a bit. Seemed a bit random at first but saw a post by Thorny on discord about how the chat works. (If it fails to read chat history once, it no longer reads chat from drive) Made me try to think about what could cause some kind of corruption of that process. SimpleLog has its own issues and no longer running that stopped it from happening randomly. I think the main reason for it causing blank chat has something to do with how Ashita is adding chat to the log though. I can replicate blanking out chat by reloading a LAC lua that adds command aliases to ashita on load and unload. (lua based on these profiles and files https://github.com/GetAwayCoxn/Luashitacast-Profiles) When loaded it creates 30+ aliases through a loop for every command added to a table. When reloading, it removes those 30+ aliases and then adds them back, adding 60+ lines of chat very quickly. This seems to be the culprit. I don't have an issue with the chat window when logging in, but if I have to reload the lua because of gear changes, it seems to have a fairly high risk of blanking chat.

Steps To Reproduce
Load one of the Luas from https://github.com/GetAwayCoxn/Luashitacast-Profiles with the common files. Use '/lac load' to reload the profile and then expand the chat window. It does not seem to always blank on one reload, so might need to do a second time. Pretty rare that a second time doesn't clear the chat.
When coroutine.sleep(.1) is added in the SetAlias function though, I can reload multiple times with the aliases being added just a bit slower and it does not seem to corrupt the chat.

Additional Information
I do understand I am running on Ashita for Horizon and this might not be strictly an Ashita issue, but thought I would at least put in a report since I seem to have found the cause. Only other person in Discord I have seem so far talking about this issue noted two different private servers as well, so again, not 100% sure if this can be replicated on retail.

Extremely minor FPS addon issue [BUG]

Ashita Version (Type /ashita in-game to get this.)
4.0.0.2

FFXI Version (Type /version in-game to get this.)
version 30211103_1

Windows Version (ie. Start > About Your PC)
10 Home 21H1 19043.1288

Describe The Bug
Not even really sure if this is bug or working as intended. Version 3 and 4 both have the default.txt scripts binding F12 to "/fps show"
In v3 people are used to that cycling between showing and not showing. In v4 it does not behave the same way, maybe by design? If it is supposed to cycle, then this is a very minor bug. If it is not supposed to cycle like it did in v3 then I would suggest changing the default.txt to bind F12 to "/fps" instead as that cycles just fine and you will avoid a bunch of random comments on discord about how to make the red numbers go away when you release this to the masses.

Steps To Reproduce
Load via default.txt script, then push F12 a couple of times.

Screenshots
n/a

Additional Information
n/a

[BUG] IDirect3DDevice8:GetVertexShaderConstant returns incorrectly sized array.

Ashita Version (Type /ashita in-game to get this.)
4.1.0.2

FFXI Version (Type /version in-game to get this.)
unknown

Windows Version (ie. Start > About Your PC)
19044.2965

Describe The Bug
The function IDirect3DDevice8:GetVertexShaderConstant returns an array 4 times as large as it should. The constant registers are 128 bits, but the function allocates 16 floats (512 bits) per register.

Additional Information
line 561 of idirect3d8device.lua should be changed from

local data  = ffi.new('float[?]', ConstantCount * 4 * 4);

to

local data  = ffi.new('float[?]', ConstantCount * 4);

[BUG] Japanese text displayed as garbled characters

Ashita Version (Type /ashita in-game to get this.)
v4.1.0.2

FFXI Version (Type /version in-game to get this.)
Latest retail. (/version didn't work in-game).

Windows Version (ie. Start > About Your PC)
Windows 10 Home 22H2
OS build 19045.3448
64bit

Describe The Bug
In IMGUI components at least, Japanese text is not displayed correctly. It appears as garbled characters.

Steps To Reproduce
Option 1:
Run client in Japanese.
Install tCrossBar (https://github.com/ThornyFFXI/tCrossBar) and open the bindings window to see a list of spells/abilities. They will all have garbled characters.
Alternatively, install HXUI (https://github.com/tirem/HXUI) and cast a spell to see the cast bar. The name appears in the bottom left and it will be garbled.

Option2:
It might be quicker to reproduce by simplying grabbing a spell name from AshitaCore:GetResourceManager and using index 1 (2 in lua) to force the Japanese name rather than english. I assume you don't even need to change the client language if you do this.

Screenshots
See below. The label field is displaying the Japanese text. The Action drop down is displaying the English. The macro field is also using Japanese in the quotes.
pol 2023-10-02 21-37-07

Additional Information
Obviously I don't know how Ashita is coded internally, but I did fix a similar issue in Thorny's tRenderer (used for tCrossBar and tHotBar) by simply adding a setLocale call, which ensures char -> wchar are parsed correctly (e.g when you call swprintf_s or similar method).

https://github.com/ThornyFFXI/tRenderer/pull/1/files

#include <locale.h>
// Ensure we convert japanese text correctly when we call swprintf_s
setlocale(LC_ALL, "");

It'd be really interesting to see if that's all that is needed to fix it for IMGUI as well. It feels like a long shot but I was surprised it worked for tRenderer, so we might be lucky.

I don't mind testing a version of Ashita with that added to verify if it works.

FWIW I'd also be happy to contribute to the development and investigate myself, but I understand you don't know me + the source is closed so I appreciate you probably don't want to do that.

Pass Additional Command Line Arguments Directly To Bootloader

Feature Description

Several users have requested that the command line injector pass any additional arguments to the bootloader / game executable as normal command line arguments. For example, if the user launches their configuration like:

ashita-cli.exe atom0s.ini --user test --pass test

This would launch the atom0s.ini configuration as normal, but would add --user test --pass test to the command arguments that are part of the ini file when launching the loader.

The same for when launching retail, where the user could launch with the following from cli:

ashita-cli.exe retail.ini /game eAZcFcB

Too Many Open Files

I get the error Too Many Open Files randomly about 3-5 times daily for different addons, such as minimap, mobdb, luashitacast, etc.

Screenshot 2023-04-05 090625

Treasure pool item menu index correlation with menu cursor position

Feature Description
Please give a full description of your feature request.

Items in the treasure pool are assigned an index upon entering the treasure pool from 0 to 9 that increments by 1 each time a new item enters the pool. This index isn't tied to its place in the menu at all. While we have a pointer location to which menu line is being hovered, there doesn't seem to be a means to correlate the menu cursor position with the treasure pool item index.

Without correlating the menu cursor position with the index, as soon as an item leaves the treasure pool, there is a desync of menu cursor position and index until zoning.

Add Coroutine Returns To `ashita.tasks` Functions

Addon / Plugin Description

When creating a task from Ashita's ashita.tasks. addon functions, the actual created task/coroutine is not returned. It would be ideal to return the object so that users can easier control the coroutine (when applicable) such as killing it from outside the function.

For example:

local co = ashita.tasks.once(1, function ()
    -- do stuff here..
end);

co:kill(); -- Kill the coroutine, similar to coroutine.kill() from within the task function.

Or allow coroutine,kill() to accept an optional parameter of an existing coroutine/task.

Ashita config window not working properly (font not readable)

Hello! First and foremost, thank you very much for the Ashita project ๐Ÿ™‚

So I'm playing HorizonXI with Ashita, when I open the ashita config window (as well as any addon that displays ashita "windows"), I get this error with the font letters (see the attached image)... does anybody know how to fix it? I'm running ashita in a virtualized W11 with Parallels (running on a Mac)... Thank you!

error ashita

[BUG] Have to manually /unload addon /load addon to make positional settings save

Ashita Version (Type /ashita in-game to get this.)
4.0.02

FFXI Version (Type /version in-game to get this.)
Topaz private server

Windows Version (ie. Start > About Your PC)
8.1

Describe The Bug
Settings for addons positions don't save until you manually /unload addonname /load addonname (and as #3 says, you have to do this twice).

Steps To Reproduce
Install a new addon. Load it, move it's position, log off the game. When you log back in, the settings don't save. You have to manaally load it, then unload it (and as #3 shows, you have to do this twice to make it save your settings).

Add Support For Japanese Text (ImGui)

Feature Description

The current setup for Ashita does not properly support ImGui's ability to render UTF8 text. The two built-in fonts both do not contain the needed glyphs and the default font setup does not include the needed glyph ranges for proper UTF8 support.

The following would be ideal to implement/fix in a future update:

  • ImGui: Add a default UTF-8 compatible font to be included with Ashita.
  • ImGui: Add the proper glyph ranges to the fonts able to render UTF-8.
  • ImGui: Ensure rendering from Ashita's Japanese string resources is valid/working.

This same issue carries over to the built-in font rendering of Ashita. The current font system dose not include any of the extended glyphs needed to render Japanese/UTF-8 text. This may not be ideal to implement in the current font system though due to how it works. (Perhaps wait until a newer system is added, such as GDI+ or D2D?)

Related issue: #46

[BUG] I cannot Log in to HorizonXI

Ashita Version (Type /ashita in-game to get this.)
4.0.0.2

FFXI Version (Type /version in-game to get this.)
HorizonXI

Windows Version (ie. Start > About Your PC)
Windows 10 22H2

Describe The Bug
Please give a clear, full description of the bug.
Cannot log in even with correct username and password.
Steps To Reproduce
Please give a clear, full list of steps to reproduce the bug, if applicable.
Installed the HorizonXI game, launched it, got the screen below, wanted to type in username and password, even if I typed it correctly, it just infinite loop.
Screenshots
If applicable, add screenshots to help explain your problem.
image

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved.

[BUG] Saving addon settings

Ashita Version (Type /ashita in-game to get this.)
4.0.02

FFXI Version (Type /version in-game to get this.)
Topaz private server

Windows Version (ie. Start > About Your PC)
8.1

Describe The Bug
Saving positional settings is a bit buggy.

Steps To Reproduce
Load an addon. Move it's position anywhere. Unload addon - > reload addon. It now resets back to the default settings. Move addon again -> Unload addon - > reload addon, it now properly saves settings.

[BUG] Alt + Tab

Ashita Version (Type /ashita in-game to get this.)
4.0.06
interface 4.14

FFXI Version (Type /version in-game to get this.)
30221103_1?
retail up to date

Windows Version (ie. Start > About Your PC)
10

Describe The Bug
Alt tabbing seems to be buggy(it was fixed in a much earlier version of V4). It shows the weird windows 98 UI when you hold alt+tab while FFXI is the the focus, instead of the windows10 one

Imgui crash[BUG]

Ashita Version (Type /ashita in-game to get this.)
4.0.0.6

FFXI Version (Type /version in-game to get this.)
Unknown

Windows Version (ie. Start > About Your PC)
Windows 10, build 19044.2846

Describe The Bug
Getting a crash related to imgui sporadically (every few days). The addons plugin will throw an exception and unload.

addons threw an exception in event Present.  Exception: EXCEPTION_ACCESS_VIOLATION (C0000005). [PTR: 6C8F336E]

Following this, I am able to reload addons, but any calls to the imgui api will crash addons again with the same error until I restart the client.

Steps To Reproduce
No known way to reproduce the initial state; it has happened while there was no user input, and no imgui window on screen (although hxui configures its settings menu every frame, even if it's not displayed).
Once the initial crash has happened, any imgui api call will reproduce it, such as:

imgui.PushStyleColor(ImGuiCol_WindowBg, { 0, 0.06, .16, .9 });

Screenshots
imgui crash

Default.txt Script not Loading [BUG]

Ashita Version (Type /ashita in-game to get this.)
4.0.0.4

FFXI Version (Type /version in-game to get this.)
30211204_0

Windows Version (ie. Start > About Your PC)
Windows 10 Pro, 21H2

Describe The Bug
Loading up the game, the argument under script in the boot .ini for script doesn't seem to be loaded; Tried a custom script as well as leaving it to default.txt

Steps To Reproduce
Leave default.txt and open the game

Screenshots
Will provide if requested; not sure what to screenshot

Additional Information
Please include any additional information you feel could help explain the bug/problem and get it resolved.

Steal tracker

Addon / Plugin Description

Would like an addon that can tell what has been stolen from in Dynamis - If possible. Thank you!

[BUG] Supplies

Ashita Version (Type /ashita in-game to get this.)
v4.0.0.6

FFXI Version (Type /version in-game to get this.)
nothing happens. Chains of Promathia?

Windows Version (ie. Start > About Your PC)
Windows 10 Home
21H2

Describe The Bug
I am of the Bastok nation. I took a supplies mission to Ronfaure, but did not go there before my nation lost that region. The M. guards (of my nation) do not take back the supplies, and the guard (not of my nation) at the outpost of course wont take it either. I can't accept a new mission, because I still have the supplies from the impossible mission. If it's not a bug, do I have to hold on to them and not do supplies missions until my nation takes that region back?

Steps To Reproduce
I had accepted the supplies from a Bastok M. guard, maybe at the North Gate. When I returned to the Gate (and by then my nation had lost the region for my supplies mission): my Rank went from 1 to 2, I accepted a new Mission for my Nation (not the supplies kind), and I donated a stack of Crystals to the M. guard. I don't know if that mixed up the flags, and stuck me with the old Ronfaure supplies. They won't take it back now.

Screenshots
n/a

Additional Information
n/a

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.