ashdavies / rx-tasks Goto Github PK

Hey Ash the compile statement in the readme is wrong - it should be:

compile 'io.ashdavies.rx:rx-tasks:1.1.3'

Hi.
Do you have any plans to update to RxJava3?

I see that you consider to deprecate the library completely in favour of coroutines ( #23 ), but I'd say the are many projects that continue using RxJava and don't plan/cannot migrate to coroutines.

Thanks

I was using 1.2.0 previously but after upgrading to 2.0.0 I get an IAE when wrapping a Task<Void> in a Completable. Not sure if other Source types are affected. Anyway, here's my code that worked fine in 1.2.0 but crashes in 2.0.0:

val aFirestoreInsertionTask: Task<Void> = ...

RxTasks.completable(aFirestoreInsertionTask)
            .subscribeOn(Schedulers.io())
            .observeOn(AndroidSchedulers.mainThread())
            .subscribe(...)

  java.lang.IllegalArgumentException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter void
        at io.ashdavies.rx.rxtasks.CompletableEmitterSuccessListener.onSuccess(CompletableEmitterSuccessListener.kt)
        at io.ashdavies.rx.rxtasks.CompletableEmitterSuccessListener.onSuccess(CompletableEmitterSuccessListener.kt:6)
        at com.google.android.gms.tasks.zzj.run(Unknown Source)
        at android.os.Handler.handleCallback(Handler.java:746)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:148)
        at android.app.ActivityThread.main(ActivityThread.java:5443)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)

I have tried including the new version of this library in my project, but it cannot be resolved. Version 2.0.0 can be found just fine.

Doing a little poking around, it doesn't appear that 2.1.0 has been made available via Maven, nor has the Maven metadata been updated. Perhaps I'm wrong, and am missing something?

I'm wondering what is the 'org.jetbrains.kotlin:kotlin-scripting-jvm:1.3.11' dependency used for and do I need it on my runtime classpath when I use this library.

I downloaded this repository, commented out that dependency and ran ./gradlew clean assemble and build succeeded, so maybe it's not needed?

Edit: also executed all the tests and they ran fine.

It pulls in dependencies with known security vulnerabilities, which I'd prefer to avoid: https://nvd.nist.gov/vuln/search/results?form_type=Advanced&results_type=overview&search_type=all&cpe_vendor=cpe%3A%2F%3Ajetbrains&cpe_product=cpe%3A%2F%3Ajetbrains%3Akotlin

I've come across an issue using the fusedlocationprovider task with this library - it can emit null values.

I think the only way around this would be to wrap null values with some kind of optional in the library?

Some further documentation for usage with Kotlin could be beneficial (#11)

As per Bintray it should be 'io.ashdavies.rx:rx-tasks:1.1.1' (https://goo.gl/yhjRTu). Also, any reason to use minSdk 19 (https://goo.gl/3c5hec)? It kind of makes no sense to me and can be perfectly lowered to 14 or 15 for example.

In order to specify the thread that a task should be executed on before conversion to an Observable, a thread executor must be provided.

Tasks API Documentation
https://developers.google.com/android/guides/tasks#threading

[Ref: #16]

The current README has been updated to reflect the extension methods on Task, e.g. toSingle() but there's no public release including it. Any plans to do so in the near future?

Currently the task results are always delivered on the main thread, which is okay. It's easy enough to switch back off using observeOn, but it would be nice to be able to optionally avoid this thread jump if you know you're going right back onto the IO or computation scheduler to process results.

I can submit a PR for this if you like. I was thinking overloads of RxTasks (and corresponding extensions for Kotlin).

Because the SingleTaskOnSubscribe and CompletableTaskOnSubscribe are internal, it prevents the extension functions in TaskExtensions from being available outside of the module. This, at least, on Kotlin 1.2.21.

Implementing the extensions instead using the public RxTasks functions resolves the issue.