ashaffer / dift Goto Github PK

I'm using dift in Deku now because it's way easier and way less broken :)

In the spirit of keeping things pure, I'm trying to avoid needing to store the DOM element on the vnode and just using indexes. It's a little hard to do with the current move effect because it only passes in the position where it needs to be moved to, and not where it needs to be moved from.

It'd be kind of nice to have something like:

function effect (type, prev, next, pos, prevPos) {
  // blah
}

That way I could just move the element in the DOM using it's current index rather than storing the vnode. You'd need to be keeping track of the current state of the list, but you know the code way better than me. If you can point me in the right direction, and this is something you'd like, I'm happy to open a PR.

I have a case for a list of 10 elements, swapping list[1] and list[8] to each other

var tmp = list[1]
list[1] = list[8]
list[8] = tmp

Library incorrectly detects everything between 1 and 8 idx as moved and produces 8 MOVE effects, with prev = next for [2-7] elements.
Elements in between has the same indices and it should produce UPDATE for them.