ashaffer / check-browser Goto Github PK

Getting "false" when using your library

const isSupported = checkBrowser({
    msie: 9,
    msedge: 14,
    firefox: 44,
    chrome: 44,
    safari: 9,
    opera: 41,
    ios: 9,
    android: 4.4,
    others: true,
  })

For the following 3 user agents

Mozilla/5.0 (iPad; CPU OS 10_0_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) Mobile/14A456 [FBAN/FBIOS;FBAV/68.0.0.49.70;FBBV/41924288;FBRV/0;FBDV/iPad4,1;FBMD/iPad;FBSN/iOS;FBSV/10.0.2;FBSS/2;FBCR/;FBID/tablet;FBLC/en_US;FBOP/5]

Mozilla/5.0 (iPhone; CPU iPhone OS 9_3_4 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Mobile/13G35

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12) AppleWebKit/602.1.50 (KHTML, like Gecko)

but "true" when using the "bowser" library directly.

const isSupported = bowser.check({
    msie: '9',
    msedge: '14',
    firefox: '44',
    chrome: '44',
    safari: '9',
    opera: '41',
    ios: '9',
    android: '4.4',
  }, false)

Because your code checks to see if it is listed, and it is listed, but the version returned from bowser is "undefined", so there is no match with your version check (I think). I moved to just use their library directly but wanted to let you know.