ash-jc-allen / laravel-config-validator Goto Github PK

There might be times when we only want rules to be run in specific environments.

As an example, we might want to use stricter rules in production rather than local.

Is it possible to thow an exception on missing validation rules. This ensures that all keys have some validations set and that not keys have been added accidentaly that have no rules set

At the moment, the config validator will automatically search the config/validation folder for validator files. It might be useful to be able to pass in a folder path for anyone who wants to put their validation files in a different location.

Hi! First of all I want to say thanks so much your job and this package.
I have a problem with path configuration data.
By default laravel storage data 'config' path, it's ok for everyone, but in my case complicated.
I want to set data another path
For example 'app/Configuration/...'
I suggest changing hydrateConfigValueArray or another part codes.
Inject some interface for storing configuration data, which knows how get any values.
What do you think about this thought?
I will make PR, if you like this idea.

I get errors by start run Laravel Dusk in a local environment
Is there a possibility to deactivate config validator temporary without remove from composer.json?
Or Did I have configure dusk ?

The config is correct but changed while dusk runs
$php artisan dusk Environment modified. Restarting server... .... Environment modified. Restarting server...

PHPUnit tests will need to be written for the package.

It would be nice to have a command that creates the layout validation file for you.

As an example, we could maybe something along the lines of the following to create a validation file for config/auth.php:

php artisan config:make-validation auth

This could create a config/validation/auth.php file with the following contents:

<?php

use AshAllenDesign\ConfigValidator\App\Services\Rule;

return [
    Rule::make('')->rules([]),
];

Provide the option to pass custom messages into the Rule object when building it. This might be needed in places where developers don't want to rely on the default Laravel validation messages.

Add a facade for the ConfigValidator class.

Add the moment, rules can only be passed in as a string (example - required). We will also need the functionality to handle Rule objects.

https://laravel.com/docs/8.x/validation#using-rule-objects

It would be nice to have a command which can be run to validate the config quickly.

Maybe something along the lines of:

php artisan config:validate

We could maybe extend this to only validate certain config files. For example, to validate the auth.php config file, we could run something like:

php artisan config:validate --config=auth

Add the documentation and README.

It'd be nice to be able to pass in the names of the config files to validate. That way we wouldn't need to validate every config file if it's not needed.

In my application config, I have a config item that needs to be an array of values, with at least one value in it:

'names' => array_filter(explode(',', env('NAMES', ''))),

I wanted to create a validation rule for it like this:

Rule::make('migrate_from')->rules(['array', 'min:1']),

When I run config:validate, I get this exception:

   Illuminate\View\ViewException 

  htmlspecialchars(): Argument #1 ($string) must be of type string, array given (View: /path/to/app/vendor/ashallendesign/laravel-config-validator/resources/views/validate-config.blade.php)

  at /path/to/app/vendor/illuminate/support/helpers.php:119
    115▕         if ($value instanceof Htmlable) {
    116▕             return $value->toHtml();
    117▕         }
    118▕
  ➜ 119▕         return htmlspecialchars($value ?? '', ENT_QUOTES, 'UTF-8', $doubleEncode);
    120▕     }
    121▕ }
    122▕
    123▕ if (! function_exists('env')) {

  1   /path/to/app/vendor/illuminate/view/Engines/PhpEngine.php:60
      Illuminate\View\Engines\CompilerEngine::handleViewException(Object(TypeError))

  2   /path/to/app/vendor/illuminate/support/helpers.php:119
      TypeError::("htmlspecialchars(): Argument #1 ($string) must be of type string, array given")

I traced this to this line in the view:

<b>{{ config($configField) }}</b>

To make it work, I replaced that line with this:

<b>{{ json_encode(config($configField, JSON_PRETTY_PRINT)) }}</b>

I'm not sure whether my fix is a good way to do it (and I would submit it as a PR), or whether there is a better way. On one hand, this way will always work and will show a nice output for all kinds of config values (including simple and associative arrays). On the other hand, it changes how regular string values appear (by putting quotes around them).

Thoughts?