arxanas / lint381 Goto Github PK

Comments like // *** remove this comment are double tagged

Presently class members named compare are thought to be instances of calling compare on a string.

i.e.
struct S{ int compare }
S s;
s.compare = 2; //this is flagged

It should flag this in a header file:

using namespace std;

But not this:

class Foo {
    using namespace std;
}

This can be done by counting the brace-indentation level.

So this doesn't trigger errors, presumably because #include <streambuf> looks like a use of streambuf.

#include <streambuf>

using std::streambuf;

// don't use streambuf

Inline Vim support would be nice if only to retaliate against the Emacs support already present.

I use Syntastic as my syntax checker; I think it's reasonable to assume a lot of Vimmers do as well.

Some issues to consider:

• Syntastic has pretty in-depth methods of declaring a new syntax checker, which typically seem to involve getting them merged upstream. That's likely not going to happen for lint381.
• Assuming that users have to copy/paste a chunk of code, where should they put it? .vimrc or an ftplugin?
• How do we detect if we should lint381 the current C/C++ file? (The answer is most likely that we always do it assuming that lint381 is installed and the syntax-checking code is present, and to stop doing this we uninstall one or both.)
• How fast is lint381? It may be that running it synchronously is too slow.

if I have defined an exception:
struct DoTheException {};

It should not be flagged if I have a catch that looks like this:
catch(DoTheException)

If instead I do this it is not flagged, but catching by reference in this case is nonsense:
catch(DoTheException&)

/***** Island Class *****/ would be flagged.

It's reasonable to assume that the first and last sequences of tokens in any header file for this class should be #ifndef FOO_H #define FOO_H and #endif.

sizeof(char) is defined to be equal to 1 in the C standard, so its use is redundant. Flag uses of it for C and import the linter into C++ (see cpp.py for what that means).