[BUG] Spain/Nordic region: sometimes Non-English subtitles dosen't show right on specific languages. about plugin.video.hbogoeu HOT 12 CLOSED

Hello @rocknrollnor , without a full debug log in don t have enough info to answer this. Subtitles have been extensively tested and worked on all tested content. Also, the way subtitles are processed depends on the region.
Did you also make a comparison with the official client for the same show/episode time frame?

What follows is not only directed at you but anyone reporting an issue because I'm getting tired of having to explain the same thing most of the time, and ask additionally for logs most of the time when what is required when reporting an issue is clearly stated.
Full unedited and uncut debug logs are always required for a good reason, if a user reporting an issue has the skill and experience necessary to read a log correctly and arbitrarily decide if the log is useful or not then probably has the skill, expertise, and experience(regarding the add-on) necessary to fix the problem in the first place and can provide a fix directly instead of reporting the issue.

from plugin.video.hbogoeu.

Hi!
Note taken about the log.

Tested again today. Some series/movies works, others don't. All good in the official client.
The srt-files to this episodes/movies has wrong/missing timestamps contra the ttml-files.

kodi.log

from plugin.video.hbogoeu.

Hello,
ok, so the problem is some ttml files for the Spain/Nordic region don't get converted correctly by the ttml2srt converter.
I will investigate, have to find out what the problem is with those files. Can you please provide what s the exact show, episode, and time frame where it happens.

from plugin.video.hbogoeu.

For example "Phil Spector" movie, at 02:07 or "1992" S01E01 at 01:26.

from plugin.video.hbogoeu.

Progress regarding this issue can be followed on pull request #158 , please test the test version published there and report back with debug logs.

from plugin.video.hbogoeu.

kodi.log

from plugin.video.hbogoeu.

@rocknrollnor does the problem persist with the test version in the pull request?

EDIT: nevermind I see in the log that it fails. I Will let you know when a new test version is ready. Unfortunately, I don't have access to the region in question so I can't test directly can only rely on sent logs to debug the changes.

from plugin.video.hbogoeu.

No problem, I can do that. Thank you for your time.

from plugin.video.hbogoeu.

Fixed in #158

from plugin.video.hbogoeu.

@all-contributors please add @rocknrollnor for bug

from plugin.video.hbogoeu.

@arvvoid

I've put up a pull request to add @rocknrollnor! 🎉

from plugin.video.hbogoeu.

Fixed and release in https://github.com/arvvoid/plugin.video.hbogoeu/releases/tag/2.6.0

from plugin.video.hbogoeu.