Code Monkey home page Code Monkey logo

openchord's People

Contributors

artutra avatar dependabot[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

openchord's Issues

Import chordsheet from web

Its hard to manually add a song with "copy/paste" from already existing songs on the web.

It would be useful if you could select a website in a dropdown, search for musics there, and import to your local songbook.

The search screen:

The preview before save:

Online search doesn't work anymore

It has been a while that online search feature doesn't work anymore.
Only shows a indicator, like it was searching but no results appears.

Chords overlapping

Describe the bug
When there are multiple chords and there is no more lyrics below, the chords ovelap

To Reproduce
Render this:
This chords will overlap [C] [Dm] [F#]
Screenshots
image

Suggestion
Add spaces on the lyrics

New Option: Nashville Number System as chord notation style

Great app so far! Thanks a lot! :)

At the moment i like the Nashville Number System as alternative chord notation. So i have a suggestion:

Describe the solution you'd like

Is it possible to add a switch in the menu with the transpose settings to change notation styles.
(similar to the options in this app: https://songbook-pro.com/)

So when there is a key defined in the file you get numbers instead of chord names and the key displayed at the top.

Additional context

{key: ...} or {k: ...} or {ok: ...} The key of the song written as a key with enharmonic preference and an optional "m" to indicate minor. - alphabetic, e.g. Bb or Em

Add to a playlist folder from a song (create an icon)

Currently to add a song to a playlist, one need to go to a playlist folder and add a particular song from there. A more direct and practical approach is to be able to add a particular song from the song list directly to a particular folder by an icon press.

ChordPro directive lost in chord over lyrics mode and back

Describe the bug
In songedit mode, chordpro directive such as {start_of_verse} ... {end_of_verse} are gone when going from chord over lyrics to chordpro

To Reproduce
Steps to reproduce the behavior:

  1. Go to a 'song'
  2. Go to 'edit mode'
  3. Switch to 'chord over lyrics'
  4. Do some edit
  5. Go back to chordpro mode

Expected behavior
Directive should be preserve or alternatively, editing in chord over lyrics is avoided and should only serve as preview. Some weird behavior also occurs when switching back and forth between chordpro and chord over lyrics mode several times (e.g: increase in vertical spacing)

Blank lines are not kept in SongView

Describe the bug
According to the original ChordSheetJS, one can just use blank line to separate verses instead of {start_of_verse} {end_of_verse} delimiter. This is not the case here, it seems like the CustomHtmlDivFormatter is ignoring the blank line such that

chord[A]pro
// Blank line
chord[B]pro

is render as

      A
chordpro
      B    // Blank line ignored 
chordpro

To Reproduce
Steps to reproduce the behavior:

  1. Go to SongList
  2. Click on + button
  3. Create a Chordpro or ChordSheet using blank line as verse separator
  4. Save and see result

Expected behavior
Should be similar to this https://martijnversluis.github.io/ChordFiddle/ when using blank line

Install errors with Node v12+ on Win10

By npm install I got the following error on the latest update

......
 error C2039: 'NamedPropertyG
etterCallback': is not a member of 'v8'
......

By a simple google search, it seems like downgrading Node to v10 would solve this issue. Did you get the same issue? which Node version is needed to build the project?

Thanks again.

Prevent screen block when on song tabs view

Describe the bug
Screen blocks on android and it's hard for me to use the app while playing the guitar

To Reproduce
Steps to reproduce the behavior:

  1. Go to any downoaded song
  2. Wait 1 minute
  3. Screen blocks

Expected behavior
Screen shouldn't block

Smartphone (please complete the following information):

  • Device: Samsung galaxy s20+
  • OS: android
  • App Version latest

Change the style, color, size of each chordpro component

Now, if I change the text size, only the whole content size change.

  • I would like to be able to choose a different size and style (bold/italic) for each components of a chordpro: meta, chord, tab, title, subtitle.
  • I would be nice to be able to choose also the color of these components

Extended features

  • Add a reset button to come back to the default style
  • Set the style per song
  • Modify the default style in the settings

Wrong chord position

Hi Artutra,

I just saw that some chords are in the wrong position. Examples: Bb7/D (should be shifted down), B/C# is really strange, B/D# is also somehow shifted. And I think most of the slash chord. Is it intended to be like this or some bug in the chord generation?

Thank again
Regards

Slide mode on song screen

The auto scroll is a usefull feature to scroll the pages without touching te device. But sometimes a manual pagination is needed when the auto scroll speed can't be really precise.
The idea is to touch on the bottom side of the screen to make the page scroll down exacly the height of the screen.
iPhone X-XS – 1

Previous/Next page button

In some cases, the song is too quick or too slow to follow the auto scroll speed.

It could be useful if the app have 2 buttons on screen to move to next/previous page of the song.

Add ukelele chords display for the songs

Is your feature request related to a problem? Please describe.
Add ukelele chords display for the songs

Describe the solution you'd like
Switch between guitar and ukelele chord display like ultimate guitar

Render responsive tabs

The tabs only works on big screens. Small screens break the lines on the wrong place.

It would be useful if the tabs could render in any screen size and still works properly

32730930-3dcee57c-c867-11e7-8285-d9a091557f31

Autoscroll on song screen

Its harder to play guitar when you have to slide every page.

A simple and common solution is an auto scrolling feature on the song screen.
It shold show a slider on the bottom of the screen that set the scroll y speed

Chords missing

All chords with the syntax similar of C/A or C#/G are missing

Import/Export .openchord files

In order to ensure the personal content, it would be very usefull if the app has a import/export data feature to backup/restore songs.

To export, each song could be a TXT file and a ZIP file to group all.
To import, could be a single TXT file or a folder with 2 or more TXT files.

Autoscroll slidebar covers the song lyrics

The autoscroll slidebar is covering the last lines of the song lyrics.

Reproducing the error
Pick a song, touch on the engine button, select "auto scroll" and play.
Go to the last lines and see the bar covering the lyrics.

Expected behavior
The scroll must show the last lines of the lyrics even when the bar is active.

Smartphone:

  • Device: Samsung S10e
  • OS: Android 10
  • App Version 0.3.1

Screenshot_20200518-103211_OpenChord
Screenshot_20200518-103218_OpenChord

Some chords don't appear correctly

Describe the bug
In some unusual chords, it shows a "empty" figure.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a music
  2. Click on the chord
  3. See a "empty" figure

Expected behavior
The correct chord is shown on the figure.

Smartphone (please complete the following information):

  • Device: Samsung S10e
  • OS: Android 10
  • App Version: 0.3.1

Screenshots
chord

Lines breaking in the middle of words

Describe the bug
The lines are breaking on the wrong place. The words are breaking in the middle.

Expected behavior
The words should always follow the chords without line breaking

Screenshots
image
The word "Recife" is breaking

Manage playlists

Allow to create playlists, add songs to playlist, reorder songs, remove songs and remove playlists

Allow user to create/edit any song

Its useful to manually edit the song as you like.

A "plus" button should open a screen where you can type the artist name and edit the song with ChordPro format or Chords over lyrics notation

Example:

Songs in playlists not sorted

The songs in the playlist aren't sorted.
They are shown in music creation order.

It could easier to sort by name.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.