artsy / kaws Goto Github PK

This issue provides visibility into Renovate updates and their statuses. Learn more

Pending Approval

These branches will be created by Renovate only once you click their checkbox below.

• chore(deps): pin dep algoliasearch from 4.10.5 to v
• chore(deps): update dep @sentry/node from 4.6.4 to v4.6.6
• chore(deps): update dep @types/elasticsearch from 5.0.36 to v5.0.40
• chore(deps): update dep @types/lodash from 4.14.116 to v4.14.182
• chore(deps): update dep @types/mongodb-uri from 0.9.0 to v0.9.1
• chore(deps): update dep node-fetch from 2.6.1 to v2.6.7
• chore(deps): update dep reflect-metadata from 0.1.12 to v0.1.13
• chore(deps): update dep release-it from 7.6.1 to v7.6.3
• chore(deps): update dep @types/node from 12.12.11 to v12.20.52
• chore(deps): update dep algoliasearch from 4.10.5 to v4.13.1
• chore(deps): update dep aws-sdk from 2.1033.0 to v2.1137.0
• chore(deps): update dep body-parser from 1.18.3 to v1.20.0
• chore(deps): update dep csv-parser from 2.1.0 to v2.3.5
• chore(deps): update dep danger from 4.0.2 to v4.4.10
• chore(deps): update dep dd-trace from 0.6.0 to v0.36.3 (dd-trace, @types/dd-trace)
• chore(deps): update dep dotenv from 8.2.0 to v8.6.0
• chore(deps): update dep elasticsearch from 15.3.1 to v15.5.0
• chore(deps): update dep husky from 1.1.2 to v1.3.1
• chore(deps): update dep mongodb from 3.6.0 to v3.7.3
• chore(deps): update dep morgan from 1.9.1 to v1.10.0 (morgan, @types/morgan)
• chore(deps): update dep nodemon from 1.18.10 to v1.19.4
• chore(deps): update dep prettier from 2.1.2 to v2.6.2
• chore(deps): update dep slugify from 1.3.4 to v1.6.5
• chore(deps): update dep tslint from 6.0.0 to v6.1.3
• chore(deps): update dep tslint-config-prettier from 1.15.0 to v1.18.0
• chore(deps): update dep typeorm from 0.2.25 to v0.3.6
• chore(deps): update dep @sentry/node from 4.6.4 to v6
• chore(deps): update dep @types/jest from 23.3.14 to v27
• chore(deps): update dep @types/node from 12.12.11 to v17
• chore(deps): update dep csv-parser from 2.1.0 to v3
• chore(deps): update dep danger from 4.0.2 to v11
• chore(deps): update dep dd-trace from 0.6.0 to v2
• chore(deps): update dep dotenv from 8.2.0 to v16
• chore(deps): update dep elasticsearch from 15.3.1 to v16
• chore(deps): update dep googleapis from 92.0.0 to v100
• chore(deps): update dep graphql-yoga from 1.18.3 to v2
• chore(deps): update dep husky from 1.1.2 to v8
• chore(deps): update dep jest from 23.6.0 to v28
• chore(deps): update dep lint-staged from 7.3.0 to v12
• chore(deps): update dep mongodb from 3.6.0 to v4
• chore(deps): update dep node-fetch from 2.6.1 to v3
• chore(deps): update dep nodemon from 1.18.10 to v2
• chore(deps): update dep release-it from 7.6.1 to v15
• chore(deps): update dep ts-jest from 23.10.5 to v28
• chore(deps): update dep ts-node from 7.0.1 to v10
• chore(deps): update dep turndown from 5.0.3 to v7
• chore(deps): update dep type-graphql from 0.17.6 to v1

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update codecov orb from 1.2.5 to v3
• chore(deps): update yarn orb from 5.1.3 to v6

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

We'll probably need to paginate etc

Currently, the database and related methods are being stubbed. Since we're having an integration test anyway that runs a query against the schema (so not super unit-y), we should be able to assert database functionality is working. So actually save and retrieve objetcs, etc.

After pairing with @xtina-starr on some kaws work yesterday, a few pieces of feedback came up:

• Currently one needs to remember to run yarn build before running yarn start, which is too easy to forget. One should really only need to run yarn start and be up and running.
• Because kaws has server code, you may want to leverage a start script, like the one in Force, so that when running from vscode’s terminal you automatically get the debugger connected.

I wasn't getting updates to the GraphQL Playground (even when restarting the server), when modifying the schema. Turns out I needed to run yarn dev instead of yarn start.

I think yarn start is the more conventional command to support.

I was making changes to the schema and not seeing them reflected using yarn dev until I killed and restarted the process.

This is so that when retrieving collections for KAWS (for example), we can just retrieve a few, and not all of them. Especially if you want to also retrieve artworks for each collection (hitting ES), we should be careful not to overfetch.