artsy / energy-legacy Goto Github PK

Update wording

https://rink.hockeyapp.net/manage/apps/74977/app_versions/15/crash_reasons/48107878

Folio Beta, works in released version

This screen should have something like "I Did, Try Again" so I can make it retry.

PLEASE NOTE: This issue has the intention to give a head start on the overall structure. The following content hasn't been fully scoped yet. It's missing design for landscape orientation, iPhone and specifically for these images, there are no dimensions, final copy, finalized assets, and transitions.

Accessing Settings

Sync

Presentation Mode

Background

Email

Logout

Overview

Views

Accessing Settings

• side panel
• COPY: Hides sensitive information when showing artworks to clients.

Sync

• sync content view
• COPY: Sync artworks, documents and information to Folio that you've added in CMS. Given the size of images, before syncing, please make sure you have a strong Wi-Fi connection.

Presentation Mode

• edit presentation mode view
• COPY: When Presentation Mode is enabled, all the information and features toggled ON will be hidden. Features toggled OFF will be visible.

Background

• change background view

Email

• email settings view
• COPY: This signature will be displayed together with any signature specified in your iOS Mail settings.

• email subject editing for one artwork
• COPY: In this field, you can use %a to indicate where you want the artist's name to be placed and %t for the artwork title.

• email subject editing for multiple artworks from multiple artists

• email subject editing for multiple artworks form same artist
• COPY: In this field, you can use %a to indicate where you want the artist's name to be placed.ced.

Try in IB

There's some overlap in their functionalities.

reported by Thomas Fuchs gallery via Maja — View in room is rendering artworks as much larger (in comparison to the virtual bench) than force does/they would be in reality.

It appears this may be related to the fact that the works are added initially with CM as dimensions and appear as though they are to scale with what it would be if the centimeters numbers were inches

Artwork example entered in CM: Thomas Fuchs Gallery / Jochen Hein, Kochende See I, 2015

• force: https://www.artsy.net/artwork/jochen-hein-kochende-see-i
• cms: https://cms.artsy.net/artworks/jochen-hein-kochende-see-i/edit?current_partner_id=galerie-thomas-fuchs

Force screenshot:

Folio (iPhone screenshot):

Artwork example entered in IN: Mitchell Innes & Nash /

• force: https://www.artsy.net/artwork/julije-knifer-20-28-dot-iv-78-1
• cms: https://cms.artsy.net/artworks/julije-knifer-20-28-dot-iv-78-1/edit?current_partner_id=mitchell-innes-and-nash

Force screenshot:

Folio (iphone) screenshot:

Haven't confirmed, but seen it on a device.

It seems that the app target does not get integrated correctly, which lead to the ‘embed frameworks’ script not being added and run. It’s probably a good idea to make the app target explicit in the Podfile.

Reviving this issue in this newer repo — we should support multiple artists attached to artworks as we do in force/volt by ensuring:

• both artist names are included on the individual artwork view and in artwork grid view in shows and albums
• a given artwork is included in any of the artist's sections with which it is associated

ie: https://www.artsy.net/artwork/richard-hoeck-1997

Folio:

Volt:

Force:

I expect something like I don't have access.

String is getting cut off for inventory IDs that include ampersands.

Overview

VIDEO: https://www.dropbox.com/s/pj115cgylztciff/folio_ipad_P_settings-side-panel.mov?dl=0

Views

Accessing Settings

• side panel
• COPY: Hides sensitive information when showing artworks to clients.

Sync

• sync content view
• COPY: Sync artworks, documents and information to Folio that you've added in CMS. Given the size of images, before syncing, please make sure you have a strong Wi-Fi connection.

Presentation Mode

• edit presentation mode view
• COPY: When Presentation Mode is enabled, all the information and features toggled ON will be hidden. Features toggled OFF will be visible.

Background

• change background view

Email

• email settings view
• COPY: This signature will be displayed together with any signature specified in your iOS Mail settings.

• email subject editing for one artwork
• COPY: In this field, you can use %a to indicate where you want the artist's name to be placed and %t for the artwork title.

• email subject editing for multiple artworks from multiple artists

• email subject editing for multiple artworks form same artist
• COPY: In this field, you can use %a to indicate where you want the artist's name to be placed.

Logout

• logout when only side panel is present

• logout when settings views are fully exposed

Landscape

Constraints and distances shown above apply also in landscape view.

Version: 2.4.0 (2015.08.11) | sy.art.folio

Stacktrace

Document;mimeType;Document.m;72
AREmailComposer;attachDocumentsToEmail;AREmailComposer.m;226
NSArray(ObjectiveSugar);each:;NSArray+ObjectiveSugar.m;51
AREmailComposer;attachDocumentsToEmail;AREmailComposer.m;224
AREmailComposer;emailArtworksFromViewController:withEmailSettings:;AREmailComposer.m;32

Link to HockeyApp

• https://rink.hockeyapp.net/manage/apps/74977/crash_reasons/45019141

Must be flipped from show -> hide; etc

I only have a default location, it's not showing up.

Version: 2.4.0 (2015.08.11) | sy.art.folio

Stacktrace (first of multiple)

NSManagedObject(ActiveRecord);executeFetchRequest:inContext:;NSManagedObject+ActiveRecord.m;191
NSManagedObject(ActiveRecord);findByAttribute:withValue:inContext:;NSManagedObject+ActiveRecord.m;689
ARSlugResolver;mapSlugsToArtworksForArtworkContainerArray:;ARSlugResolver.m;86
NSSet(ObjectiveSugar);each:;NSSet+ObjectiveSugar.m;31
ARSlugResolver;mapSlugsToArtworksForArtworkContainerArray:;ARSlugResolver.m;85
NSArray(ObjectiveSugar);each:;NSArray+ObjectiveSugar.m;51
ARSlugResolver;mapSlugsToArtworksForArtworkContainerArray:;ARSlugResolver.m;81
ARSlugResolver;resolveSlugsForShows;ARSlugResolver.m;69
ARSlugResolver;resolveAllSlugs;ARSlugResolver.m;23
ARSync;performSync:;ARSync.m;74

Reason

* Terminating app due to uncaught exception 'NSGenericException', reason: '* Collection <__NSCFSet: 0x170477d80> was mutated while being enumerated.'

Link to HockeyApp

• https://rink.hockeyapp.net/manage/apps/74977/crash_reasons/45051142

@alloy if you want a break from Eigen, you can take a look at this, I think you'd enjoy how the pattern of how sync works.

Otherwise I'm going to try give it a look early this week.

Version: 2.4.2 (2015.09.23) | sy.art.folio

Stacktrace

ARSpotlightExporter;itemForArtist:;ARSpotlightExporter.m;102
NSArray(ObjectiveSugar);map:;NSArray+ObjectiveSugar.m;99
ARSpotlightExporter;artistResults;ARSpotlightExporter.m;90
ARSpotlightExporter;updateCache;ARSpotlightExporter.m;37

Reason

* Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '* -[NSURL initFileURLWithPath:]: nil string parameter'

Link to HockeyApp

• https://rink.hockeyapp.net/manage/apps/74977/crash_reasons/48107878

Data model already exists (_SyncLog) 🎉

@sarahscott Jun 24th — If you login as a private collector, ARTopVC will show a 'Shows' tab instead of 'Locations'. Upon killing the app and reopening it, ARTopVC correctly displays the 'Locations' title.

I think this has to do with ARTopVC starting up from the initial setup coordinator without knowing the partner is a collector.

• xcode-select --install hasn't been ran yet
• bundler not installed
• nokogiri isn't installed, which is less of a problem with a check for xcode-select
• need to do a check for Artsy+OSSUIFonts header imports

GCC_TREAT_WARNINGS_AS_ERRORS = NO; is bad.

iPad-only for now

Version: 2.4.0 (2015.08.11) | sy.art.folio

Stacktrace

ARRouter;newPartnerLocationArtworksRequestWithPartnerID:locationID:page:;ARRouter.m;268
ARLocationArtworksDownloader;operationTree:operationForObject:continuation:failure:;ARLocationArtworksDownloader.m;22
ARPagingDownloaderOperation;getNextPage;ARPagingDownloaderOperation.m;39

Reason

* Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '* -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[2]'

Link to HockeyApp

• https://rink.hockeyapp.net/manage/apps/74977/crash_reasons/44315529

• Talk to @jorystiefel about thumbnails
• Add artists to search (https://github.com/artsy/energy/blob/master/Classes/Spotlight/ARSpotlightExporter.m#L68)
• Verify artworks work
• Add support for shows
• Verify that routing works as expected

Reproducible in simulator and on hardware:

I checked the destination path for the simulator and the thumbnails are actually being generated, which is good news.

In the interim, I think there should be a label letting users know they probably shouldn't try a sync unless they have a great network connection.

If a partner has no works with prices, published work, or confidential notes, what should be shown in the Edit Presentation Mode view? Should the presentation mode setting buttons be visible/disabled in the master settings menu at all in this case?

@lucaderosso @garrengotthardt

Also include linting for keys, specifically that we're not shipping oss stuff.
Example to work from; https://github.com/fastlane/examples/tree/master/ProductHunt/

/cc @ArtsyBecca @lucaderosso @garrengotthardt

• A fair that the partner is showing in is opening in a week, send a notification that they should sync a week before.
• You have sync'd Folio, but haven't opened the app in ~30 days.

This is somewhat related to issues with imageless artworks. I think it would be helpful to look into placeholders for items that should be adjusted in CMS (i.e. 'There are no images associated with this artwork' or 'There are no artworks assoc. with this show' messaging).

Useful for this particular issue:
https://github.com/artsy/energy/blob/master/Classes/Contexts/Finding%20and%20Searching/NSFetchRequest+ARModels.m#L17

Version: 2.4.0 (2015.08.11) | sy.art.folio

Stacktrace

ARModernArtworkInfoViewController;aspectRatioConstraintForImageView:image:;ARModernArtworkInfoViewController.m;100
ARModernArtworkInfoViewController;updateWithArtwork:;ARModernArtworkInfoViewController.m;92
NSArray(ObjectiveSugar);each:;NSArray+ObjectiveSugar.m;51
ARModernArtworkInfoViewController;updateWithArtwork:;ARModernArtworkInfoViewController.m;85
ARModernArtworkInfoViewController;viewWillAppear:;ARModernArtworkInfoViewController.m;55

Reason

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Multiplier is not finite! That's illegal. multiplier:nan'

Link to HockeyApp

• https://rink.hockeyapp.net/manage/apps/74977/crash_reasons/44548461

#43

#40

Related to #37