artezon / telegraph-image-downloader Goto Github PK

Hi, the is a great software that able to download all the pictures from telegraph link.
Unfortunately if I provide a link that contains word in another language like chinese and it will fail
Any workarounds?
Thank you very much!!

the word in chinese cannot be pasted properly (may be the issue)

Hello
i tried to launche .py script on Raspberry PI 2B but i get:

File "download.py", line 115 SyntaxError: Non-ASCII character '\xe2' in file download.py on line 115, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

Reading the link i added on the top of py file all the coding lines in the examples (one by one). But , for example, with utf-8 i get this error:

File "download.py", line 137 if this_failed == 0: print(f' Downloading... {percent}%', end='\r', flush=True) ^ SyntaxError: invalid syntax

Hello, my friend faced today a bug in a script and asked for fix, I helped him to solve it and come back to this repo to report.

Bug that he encounter related to wrongly detected encoding of html, he got crash when he tried to get title with regex, see this line.

For that fix I changed line to check regex match first and exit from program if it = None
Just add a check before calling .group because re.search result either re.Match or None.

Secondly I diminished bug that related to encoding isssue, for that I use https://pypi.org/project/charset-normalizer/ library.
I imported from charset_normalizer import from_bytes and changed code in line 132 into:

                encoding_fix = str(from_bytes(requests.get(url).content).best())
                html = list(str(bs(encoding_fix, features='html.parser')).split('\n'))

But it's not ideal code, since in very rare case .best() may produce None too if encoding is too weird, but that occurrence is < 0.5%. While charset-normalizer is best python lib for encoding guessing it also can fail sometimes. At least I encounter it for myself when tried to detect file names within eastern zip archives.

Hello
There is a link on telegra.ph with images linked to lh3.googleusercontent.com google storage and your script went in error when try to download image. But if i copy/paste the link into browser it show the image perfectly.

Here you are one of that links not downloaded:
https://lh5.googleusercontent.com/6ZVrJWQlQ5JieOpMfPtGNPER0o17NOyyNfwth7U9rge6GT3zdo6iWzzbqw0eqISAfPF6Cyj093Pz_Y_qnTogtRueHmHG85H_YAlJxz_pM-Ifnoh4JZuIJ5xxJzqJbh7Vk0RrhntD

Thanks