arrbee / diff-match-patch-c Goto Github PK

Currently, the library can only be built on Windows if one uses Mingw (and presumably Cygwin). It would be nice to have other build options utilizing Visual Studio (if possible).

This may not be possible, as Visual Studio still lacks full support for C99, not to mention C11 .

I'd be willing to take this on, since I use windows as my primary operating system.

While I am still actively debugging this, it would be nice to get a second set of eyes on this:

Take file a

a
bcde

Then file b

A
bcdefghijklmnopqrs

The process works as expected:

> "a\x0abcde\x0a"
-"a", +"A", ="\x0abcde", +"fghijklmno", ="\x0a"
< "A\x0abcdefghijklmnopqrs\x0a"

But if you add one more character to the second line of file b (note the trailing t)

A
bcdefghijklmnopqrst

The third iteration of diff_cleanup_merge() will never hit i != -1

As I've stated, I'm actively debugging this, but just thought you might want to know.

Is this project still active?

To the best of my knowledge, all string types used throughout the library are standard ASCII character types. Since this is a library based on string manipulation, we should probably figure out a way to use UTF-8 (Unicode) or UCS (Wide character) strings instead.

According to this site, using UTF-8 for unicode strings would probably be the best solution, as it is already compatible with ASCII encodings, and is more memory efficient than wide characters.