Code Monkey home page Code Monkey logo

Comments (8)

BlackstoneEngineering avatar BlackstoneEngineering commented on July 20, 2024

I think it is a fair assumption that all pins can be digital IO. This assumption is an underlying assumption made in the mbed SDK, so having a ping that cannot do GPIO would be an SDK implementation error, not a test case?

@sg- care to comment on this one?

from ci-test-shield.

sg- avatar sg- commented on July 20, 2024

My previous though was that a resistor ladder would provide the coverage needed and avoid this case where analog pins are not digital capable

from ci-test-shield.

BlackstoneEngineering avatar BlackstoneEngineering commented on July 20, 2024

Will consider changing to resistor ladder for next revision. But how often is it the case that a pin can do analog in but not digital out?

from ci-test-shield.

maclobdell avatar maclobdell commented on July 20, 2024

I think that most mcus these days probably do offer both analog and digital capabilities on the same pin. But there are definitely potential cases where they do not - most probably on high-precision ADCs. In my opinion, a simple circuit that isolates the feature under test (analogin, not analogin + digitalout) would be preferred.

from ci-test-shield.

BlackstoneEngineering avatar BlackstoneEngineering commented on July 20, 2024

I do not disagree, the problem is we're pretty far down the path to getting these produced, making any HW changes would delay the release of the CI Test Shield by 1-2 months. Is this worth it?

Also, wouldnt adding a resistor ladder across A0-5 messup the analogout test? Or are you proposing a resistor ladder across A0-3 with A4-5 being loopback?

from ci-test-shield.

BlackstoneEngineering avatar BlackstoneEngineering commented on July 20, 2024

As a solution I have added the 'assumptions' tests, which will check the assumptions made in the tests. In this case the TESTS/assumptions/analogin/analogin.cpp test will check that the AnalogIn pins can be used as DigitalOut pins. If not then the assumption fails, as does the entire test. Is this an acceptable solution?

from ci-test-shield.

BlackstoneEngineering avatar BlackstoneEngineering commented on July 20, 2024

@maclobdell are the assumptions tests an acceptable solution?

from ci-test-shield.

BlackstoneEngineering avatar BlackstoneEngineering commented on July 20, 2024

Marking as resolved.

from ci-test-shield.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.