arminhammer / node-cidr Goto Github PK

I think there is an error in the Subnetv4.includes method:

You can verify by testing:

new Subnetv4('1.2.3.4/32').includes(new IPv4('1.2.3.4'));

The expected result would be true. The actual result is false

According to me the gateway and broadcast address should be included:

ip.asInt >= this.gateway.asInt && ip.asInt <= this.broadcast.asInt

Thanks for having a look!

Because you are referencing "typings": "src/index.ts" in your package.json but don't provide this file in the built, npm deployed version, the definitions aren't loaded and overshadow the "types": "dist/index.d.ts"

Possible solutions:

• Provide the index.ts file in src
• Remove the "typings": "src/index.ts" from the package.json