Code Monkey home page Code Monkey logo

classicthemerestorer's People

Contributors

3deshka avatar aris-t2 avatar cobinja avatar cye3s avatar hawkeye116477 avatar igorruckert avatar internalerror503 avatar klofutar avatar kolanich avatar ma2moto avatar mdr-ksk avatar mikkcz avatar poljos avatar quicksaver avatar shyangs avatar spwhitton avatar vlakoff avatar zefling avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

classicthemerestorer's Issues

Pinned tab highlighting not working

Hello,

I'm having an issue with tab highlighting when the title of a pinned tab changes, when using the classic square tab theme (the second option in the dropdown menu).

ffbug

The [titlechanged]:not(:hover) state is bad here.

  • Classic Theme Restorer v1.5.0
  • Firefox/Iceweasel 44 with default theme
  • Arch Linux, Plasma 5 and Oxygen GTK theme

Cheers,
Vittorio

CSS conflict with Tile Tabs

ClassicThemeRestorer messes up the button for Tile Tabs, when it's on the navbar.
The problem is in smallnavbutextra.css.

    #navigator-toolbox #nav-bar #back-button[disabled] > .toolbarbutton-icon,
    #navigator-toolbox #nav-bar .toolbarbutton-menubutton-dropmarker > image,
    #navigator-toolbox #nav-bar .toolbarbutton-menubutton-button .toolbarbutton-icon,
    #navigator-toolbox #nav-bar toolbarbutton[type="menu-button"] > .toolbarbutton-icon,
    #navigator-toolbox #nav-bar .toolbarbutton-1:-moz-any(:hover ,[checked],[open],[type="menu-button"]) > .toolbarbutton-icon,
    #navigator-toolbox #nav-bar .toolbarbutton-1[type="menu-button"] > .toolbarbutton-menubutton-dropmarker::before{
      -moz-appearance: none !important;
      background: none !important;
      background-image: none !important;
      border-radius: 2.5px;
      border-color: transparent !important;
      box-shadow: none !important;
      transition-property: none !important;
      transition-duration: 0ms !important;
    } 

needs to be changed to

    #navigator-toolbox #nav-bar #back-button[disabled] > .toolbarbutton-icon,
    #navigator-toolbox #nav-bar .toolbarbutton-menubutton-dropmarker > image,
    #navigator-toolbox #nav-bar .toolbarbutton-menubutton-button .toolbarbutton-icon,
    #navigator-toolbox #nav-bar toolbarbutton[type="menu-button"] > .toolbarbutton-icon,
    #navigator-toolbox #nav-bar .toolbarbutton-1:-moz-any(:hover ,[checked],[open],[type="menu-button"]) > .toolbarbutton-icon,
    #navigator-toolbox #nav-bar .toolbarbutton-1[type="menu-button"] > .toolbarbutton-menubutton-dropmarker::before{
      -moz-appearance: none !important;
      background: none;
      background-image: none !important;
      border-radius: 2.5px;
      border-color: transparent !important;
      box-shadow: none !important;
      transition-property: none !important;
      transition-duration: 0ms !important;
    } 

The "!important" on "background: none" needs to be removed to fix the problem with the button for Tile Tabs. Right now I've moved every thing to another toolbar and hidden the navbar but it's a pain when I install a new addon and the toolbar button goes right to the navbar.

On CTR 1.4.7, toolbar button badges are now too small and size can't be overridden?

Hello. I use the Cyberfox browser, which uses a customized version of CTR. I updated the browser from 44.0 to 44.0.1, which also updated its CyberCTR (customized version of CTR) to incorporate changes from CTR 1.4.7. Now my toolbar button notification badges are too small, and I can't seem to override that with Stylish or userChrome.css?

I tracked down the offending change to line 403 in winaero/smallnavbutextra.css, the "font-size:60% !important" bit. That part was unchanged from the original addon, so, I don't think it's anything to do with any Cyberfox customizations.

Anyway, I try plugging "#navigator-toolbox #nav-bar toolbarbutton .toolbarbutton-badge-stack .toolbarbutton-badge" into Stylish and play around with the font-size, but, nothing works? Oddly, I can set other properties like background-color if I want, but I can't override the font-size. So, I tried to change it using userChrome.css as well, and still nothing. If I want to change it, I have to edit smallnavbutextra.css, which is not ideal, because I'm sure my change will get overwritten on the next browser update.

I'm using Cyberfox on Windows 7 with a 1920x1080 resolution. I find 80% a more legible font-size. But what I want to know is, is it possible to make that user-configurable without having to edit the addon CSS directly? I don't understand why I couldn't override the font-size with Stylish or userChrome.css, especially when I could set other properties like font-family or background-color.

Enter Read View icon is not present

When Classic Theme Restorer is active, it is not showed the Read View toggle icon.
readview

(in the screenshot it was deactivated, to show the icon...)

FIrefox 44 and nav-bar buttons

In the navigation bar, if "icon+text" enabled, button's width is fixed, and texts under icons are truncated, (the same happens with "icon+text v.2", "icon+text v.3" or "icon+text v.4" options).

  • Classic Theme Restorer v.1.4.6.1 (issue also in v. 1.4.7.x beta)
  • Firefox 44
  • Windows 7 ultimate (64bit)

title bar - tabs on top

If enable "tabs on bottom", some new windows miss the title bar, so is not ossible move the new window.
i.e.
On this site
http://kajamira.blogspot.it/
if you open a link named "Commenti" the new window has not the title bar, and you can not move the window

missing-title-bar

Maybe remove " (Customize UI)" from title

Instead of calling this add-on for "Classic Theme Restorer (Customize UI)" would it not be better to call it "Classic Theme Restorer"?

Also when you deactivate an add-on in Firefox it puts "(disabled)" at the end of the title so it becomes:
"Classic Theme Restorer (Customize UI) 1.3.5 (disabled)" which don't look so nice with the double () ().

Small bug in Squared Tabs Classic v.2 theme

There's a small bug in Squared Tabs Classic v.2 theme. Tabs go 1-2 pixels below the tab bar. It's a minor, but a very annoying glitch for me. I posted a screenshot.

http://s29.postimg.org/xne9sv4rb/Untitled_1.jpg

Could you please fix this? And preferably tell me what to adjust in "tabs_squaredc2.css" file (supposedly it's this file) to get rid of the issue asap, as I'm about to compile my customized version of Firefox.

Thank you for all the effort and a great extension.

Add support for settings sync

It would be great to support syncing settings using Mozilla Sync. It simplifies keeping browsers UI consistent across multiple computers.

Switch tabs with mouse on top of the window

In the latest version of FF beta (47) and Nightly (49) when you move your mouse on top of the window and try to switch to other card/open a new one with MMB, nothing happens. You have to lower the cursor by at least 1 pixel for the click to be detected. Very frustrating. The problem disappears after turning CTR off, but how can one use firefox without it on. I use the australis tabs but it happened on all tabs settings and changing other settings did not get rid of this problem, though I didn't check all of them.
I'd really appreciate any help, thanks!

Classic search bar focus order

If the text cursor is in the URL address text field, I need to <TAB> twice to get the focus of the search text field and have the current text marked.
The first <TAB> seems to focus the search provider selection, since I can open the menu with <ALT>+<DOWN>.

If I remember correctly, this was different, I don't have a reference installation to check right now.

Allow replacing of Windows 10 styled window buttons with native ones

As you know, Firefox 40 contains various tweaks designed to make the browser look better in Windows 10. Unfortunately if a custom theme for window borders is used, these tweaks make Firefox look very ugly compared to other windows. The option "Title/menu/tabs toolbar: remove window color (Windows 10" partially fixes this, but the window buttons (minimise, maximise, close) keep using Firefox's non-native style. Would it be possible to replace these with the native window buttons found on older (<=39) versions of Firefox or Firefox 40 on other Windows versions?

Tab separators missing from australized squared tabs

I'm not sure how long this has been present but I just noticed this after upgrading to Windows 10, which forces the use of white title bars on all windows. The black tab separators are visible with the default curved tabs, but they're missing when switching to the "squared tabs (australized)" option.

untitled

Windows 10, Firefox 39.0

Features CTR will not restore in future builds

This is a small overview of what CTR is not going to add/restore (not even in future builds):

  • discontinued add-ons: contact developers about updating their add-ons
  • tab groups, panorama or similar: use Tab Groups add-on
  • status text popup in add-on/status bar: use Status4Evar add-on
  • automatically shrinkable add-on bar: use Puzzle Toolbars add-on
  • toolbar button styles/shapes: use Classic Toolbar Buttons add-on (Windows)
  • vertical toolbars: use Puzzle Toolbars add-on or Vertical Toolbar add-on
  • vertical tabs or multi-row tabs: use TreeStyleTabs, TabUtilities or TabMixPlus add-ons
  • tab colors like offered by ColorfulTabs add-on: use ColorfulTabs add-on
  • tab appearance from Google Chrome: use FXChrome (complete) theme
  • tab appearance known from MacOS: Windows tab styles with MacOS colors are used instead
  • Firefox 4-28 'splitmenus' inside Firefox buttons appmenu (many conflicts and incompatibilities with MacOS, complete themes, menu events, icons...)

Neither Classic Theme Restorer nor the suggested add-ons will work when Firefox 57 arrives (see #299). There is nothing anybody but Mozilla can do about. Please do not blame add-on developers for the end of these kind of add-ons.

Can't click minimize, close... button

From firefox 40, it seem window buttons is behind the toolbar.
capture
Here is my settings:
capture2

I think you should add an option to change margin value of each toolbar

Small issue with FaviconizeTab extension

I'm using ClassicThemeRestorer with FaviconizeTab extension and stylish style:

@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);

.tabbrowser-tabs tab[faviconized="true"][fadein="true"],
.tabbrowser-tabs tab[faviconized="true"][fadein="true"][selected] {
   min-width: 26px !important;
   margin-left: -1px;
}

.tabbrowser-tabs tab[faviconized="true"][fadein="true"] .tab-icon {
   margin-right: -7px;
}

to achieve something like this:

In new ClassicThemeRestorer version I changed style to:

@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);

.tabbrowser-tabs tab[faviconized="true"][fadein="true"],
.tabbrowser-tabs tab[faviconized="true"][fadein="true"][selected] {
   min-width: 26px !important;
   margin-left: -1px !important;
}

.tabbrowser-tabs tab[faviconized="true"] .tab-icon {
   margin-right: -5px !important;
   margin-left: -5px !important;
}

and all remained same except conneting and loading icons:

they've moved 5px to the left. And I can't realise wich style in new version caused this.

Setting the height of tab bar in the Squared v2 theme makes it impossible for other addons to do so.

With the latest version the height of the tabbar has been set to a fixed value in the Squared v2 tabs theme, unfortunately that breaks the possibility for other addons to change the height of the tabbar.

The concrete example is my addon ThinTabs, which allows to freely modify the height of the tabbar. With that change in the Squared v2 theme it is no longer possible for me to set the height of the tabbar to a (user chosen) value. Though it still works with all other themes, the Squared v2 theme is just the best to use with/for rather small tabs.

Also, the CTR update 1.2.6 on my machine contains this in the tabs_squaredc2.css file:

/* fix tab size for some add-ons/cases */
.tab-background-start[selected=true]::after,
.tab-background-start[selected=true]::before,
#tabbrowser-tabs[overflow] .tabbrowser-tab:not([pinned]) .tab-background-start,
#tabbrowser-tabs[overflow] .tabbrowser-tab:not([pinned]) .tab-background-end,
.tab-background-end[selected=true]::after,
.tab-background-end[selected=true]::before,
.tabbrowser-tab .tab-stack .tab-background,
.tabs-newtab-button,
#tabbrowser-tabs,
.tabbrowser-tab,
.tabbrowser-tab .tab-stack,
.tabbrowser-tab .tab-stack > .tab-content{
  min-height:26px !important;
}
#TabsToolbar .tabs-newtab-button,
#TabsToolbar .tabbrowser-tab{
  height: 26px !important;
}

Any chance you can revert that change? Or do you have another idea how to fix this?

CSS specificity quite high

Hi Aris,

I noticed that the specificity of your CSS is quite high (so high that it is actually very hard to override in some cases):

  • For once many of the rules are defined as !important.
  • Furthermore you add your style sheets as AGENT_SHEETs which puts them always last and therefore with a higher specificity.
  • Last but not least your selectors have quite high specificity to start with.

As a real world example I tried to override a ruleset in smallnavbutextra.css.
In the end I had not only to add an overly specific selector but also make my style sheet an AGENT_SHEET as visible in Ede123/greasy-scripts@79cbdc9

So while not exactly a bug or feature request, if you see a chance to lower specificity of some of your CSS it would probably increase compatibility with other add-ons a lot. It's already hard enough to test on all platforms, so it would benefit all parties involved.
(Actually, if nobody made me aware of this issue it would have gone unnoticed, which I assume happens a lot already and is bad for everyone).

Regards,
Eduard

Firefox 29 and 30 with Classic Theme Restorer Bug

Mozilla developers seem to think this is your bug. Using Classic Theme Restorer to restore the tabs to the bottom obscures the two icons in the upper left corner of the tool bar. I have downgraded all computers to Mozilla 28 to avoid having to use Classic Theme Restorer.
screen shot 2014-06-25 at 13 05 08

Firefox Tour stops in introduction when CTR is enabled

Steps to reproduce:

  1. Start any versions Firefox with a new profile
  2. Enable CTR v1.5.1
  3. Start "Firefox Tour". menubar > Help > Firefox Tour

Firefox Tour stops in introduction because UITourTooltip is not displayed.

Could you please fix this? Thank you in advance.

regards,
magicp

[Bugzilla 1265804] E10s: if location bar is not on nav bar, chromehidden windows fail to forward urls when opened through window.open()

I like having the location bar show up in the menu bar to save space and I've noticed an issue when e10s is enabled.

When the location bar is placed in the menu bar it seems that popup windows do not work at all.

https://i.gundam.eu/1461044763.png
This is a fresh profile with only Classic Theme Restorer and the location bar moved to the menu bar.

https://i.gundam.eu/1461046230.png
When the location bar is not in the menu the problem does not occur.
If e10s is disabled the problem does not occur.

I am using FF 47.0a2 developer edition and Classic Theme Restorer 1.5.1beta7.

Classic search bar is not triggered by mouse click on the magnifying glass icon

Hello,
I installed ClassicThemeRestorer to restore the classic search bar and it works really good - thanks a lot.
One deviation I noticed is that I can only trigger the search by pressing return and not by clicking on the magnifiying glass.

FF 43.0 32bit / CTR 1.4.3.1-signed
Reproduced with Windows 7 and Windows XP

When CTR is enabled, main toolbar doesn't have enough right-padding

Using Firefox 40.0.1, and the default theme, the menu button looks like this:

good-spacing

When CTR is enabled (1.3.8), it looks like this:

bad-spacing

I don't think any of CTR's options affect this issue. I'm currently using the following CSS as a workaround:

#nav-bar {
  padding-right: 3px;
}

ClassicThemeRestorer don't include the license file

Not available LICENSE file in source directory structure
Please. Added license and copyright notice.
All source files are without license headers.
Please, add license headers in those files where is missing
Thanks in advance
Regards

Squared Tabs don't work when Firefox Developer Edition is running

If i change to squared tabs (Classic) when two Firefoxes are running (v39 and Developer Edition with different profiles, but Sync on), the Default Fx (v39) don't change tabs layout.
It change everything, tabs position included, but not styles. Sometimes bugs and show some of two styles (default and squared, default on rounded sides, but squared in click area).

CTR v1.3.5-b3 (previously stable version, but i tried to update to see if is working), Fx 39.
If you need more info, please tell me.

[Feature request] Add option to hide identity-icon

Would like to be able to hide the new identify-icon (chrome://browser/skin/identity-icon.svg) that appears int he URL bar in Firefox 45.

Would probably make sense to include the option in "Location bar (2)" by the padlock options.

[v1.4.0beta3] Problem if Tabtitle in Titlelist is activated with long Titles

Hello

First, thank you very much for this GREAT addon!

I have a problem (with v1.4.0beta3), if Tabtitle in Titlelist is activated with long Titles such as in the following example ...

ctr-problem0
ctr-problem1
ctr-problemok

.. then the hole right side is truncated.

Maybe it would be good to have a configurable max length and the rest could be showed with as hovered or scrollable text or something like that.

Greetings
Alpengreis

appbutton and titlebar-button height is increased and affect complete theme

Hi Aris,

I raise an issue as follows...

appbutton and titlebar-button height is increased and affect complete themes. Please refer to the attached image. CTR 1.3.6 or 1.3.7.1 is better for me. Could you investigate this issue? Thank you in advance.

My environment:

  • Windows 10 (64-bit)
  • Firefox 40.0.2 (32 bit)
  • Qute 5++ 1.5.6

Regards,
magicp

classic-theme-restorer

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.