arimacdev / php-sigfox-client Goto Github PK

Currently our auto generated codes are hard to read. because some repository classes have long lines. I suggest to implement a PSR2 pretty printer in this project or in the nikic/PHP-Parser.

There is an exists project tcopestake/PHP-Parser-PSR-2-pretty-printer. But it not splitting long lines into multi lines. And not considering some PSR2 constraints. Work on this project if possible.

I know we are already using the psalm to analyse our sourcecodes. But I noticed that PHPStan is discovering more issues in our project than psalm. So I suggest to integrate PHPStan with level 8. Change the code generater if auto generated codeblocks do not have enough details.

This is only an API client. So do not want to maintain a serializer library inside this project. Let other third party library to handle serializations and deserializations.

Currently this library is converting the whole schema to an array and processing it. So the source-codes of code generator seems pretty ugly. As a solution use a third party library to convert the json schema to typed objects. It will improve the code readability of code generator. I am suggesting to use swaggest/php-swagger2-schema

We do not want to maintain a validation library in our project. Because this is only an API client library. So I am suggesting to use a third party library to do validations in this project. This third party library must validate nested objects too.