servlet-api must have scope provided about dellroad-stuff HOT 11 CLOSED

Actually you have the same issue for spring-test. Its scope should be test
<scope>test</scope> otherwise any user of your API gets test-only dependency in 
his project.

Could you please perform a small release with these changes so that the 
metadata are right? I am ok to help you or provide a patch if you  want me too.

My mistake, it's the spring-aspects.pom which seems weird for spring-test ...

Hi,

First, my apologies. I have never actually used Maven so stupid mistakes are to 
be expected :)

In any case I don't understand what you mean. The pom.xml file that I publish 
with dellroad-stuff does not contain any dependency clauses or any reference to 
the servlet-api stuff:

http://search.maven.org/remotecontent?filepath=org/dellroad/dellroad-stuff/1.0.2
27/dellroad-stuff-1.0.227.pom

Can you provide more specifics about what I need to do?

I got a pom for some repository that looks like this:


<?xml version="1.0" encoding="utf-8"?>

<!--
     Note: this file is constructed by hand (I don't use maven).
     If you see any problems please email archie at dellroad.org.
-->

<!-- $Id: pom.xml 176 2011-10-31 15:18:03Z archie.cobbs $ -->
<project xmlns="http://maven.apache.org/POM/4.0.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>org.dellroad</groupId>
    <artifactId>dellroad-stuff-vaadin</artifactId>
    <version>1.0.284</version>
    <name>Spring Stuff</name>
    <url>http://dellroad-stuff.googlecode.com/</url>

    <licenses>
        <license>
            <name>Apache 2</name>
            <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
            <distribution>repo</distribution>
        </license>
    </licenses>

    <issueManagement>
        <system>Google Code</system>
        <url>http://code.google.com/p/dellroad-stuff/issues</url>
    </issueManagement>

    <scm>
        <connection>scm:svn:http://dellroad-stuff.googlecode.com/svn/trunk</connection>
        <developerConnection>scm:svn:https://dellroad-stuff.googlecode.com/svn/trunk</developerConnection>
        <url>http://dellroad-stuff.googlecode.com/svn/trunk</url>
    </scm>

    <dependencies>
        <dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>slf4j-api</artifactId>
            <version>1.6.3</version>
        </dependency>
        <dependency>
            <groupId>javax.servlet</groupId>
            <artifactId>javax.servlet-api</artifactId>
            <version>3.0.1</version>
        </dependency>
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-context</artifactId>
            <version>3.0.6.RELEASE</version>
        </dependency>
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-aspects</artifactId>
            <version>3.0.6.RELEASE</version>
        </dependency>
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-web</artifactId>
            <version>3.0.6.RELEASE</version>
        </dependency>
    </dependencies>
</project>

I don't know where it's coming from. Maybe we should solve that mystery. On a 
separated note, I can help you to build a proper pom for your next release.

So somebody stuck the dependencies in there... I was to lazy/scared to do so 
myself. So their attempt is understandable.

Take a look at the dependencies in 
http://ivyroundup.googlecode.com/svn/trunk/repo/modules/org.dellroad/dellroad-st
uff/1.0.284/ivy.xml and see if you can convert those into maven dependencies 
which I can add to the pom.

Thanks.

Hi, I created a project by adding your source code and configuration. It 
works..only probem is the "myApplicationBean: MyApplicationBean@58cca9" changes 
everytime I refresh the browser, which according to your specifications it 
should not. Where do you think I made a mistake? Thanks in advance.


 This is my pom file;


<project xmlns="http://maven.apache.org/POM/4.0.0" 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>com.myAppNAme</groupId>
    <artifactId>myAppNAme</artifactId>
    <version>0.0.1-SNAPSHOT</version>
    <repositories>
        <repository>
            <id>vaadin-addons</id>
            <url>http://maven.vaadin.com/vaadin-addons</url>
        </repository>
    </repositories>
    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <maven.compiler.source>1.6</maven.compiler.source>
        <maven.compiler.target>1.6</maven.compiler.target>

        <vaadin.version>6.7.4</vaadin.version>
        <spring.version>3.1.0.RELEASE</spring.version>
        <aspectj.version>1.6.12</aspectj.version>

        <!-- Plugin versions -->
        <aspectj-maven-plugin.version>1.4</aspectj-maven-plugin.version>
        <jetty-maven-plugin.version>8.0.4.v20111024</jetty-maven-plugin.version>
    </properties>

    <dependencies>

        <dependency>
            <groupId>asm</groupId>
            <artifactId>asm-commons</artifactId>
            <version>2.2.3</version>
        </dependency>
        <dependency>
            <groupId>asm</groupId>
            <artifactId>asm</artifactId>
            <version>2.2.3</version>
        </dependency>

        <dependency>
            <groupId>cglib</groupId>
            <artifactId>cglib-nodep</artifactId>
            <version>2.2</version>
        </dependency>
        <dependency>
            <groupId>com.vaadin</groupId>
            <artifactId>vaadin</artifactId>
            <version>${vaadin.version}</version>
        </dependency>
        <dependency>
            <groupId>org.dellroad</groupId>
            <artifactId>dellroad-stuff-vaadin</artifactId>
            <version>1.0.284</version>
        </dependency>
        <dependency>
            <groupId>javax.servlet</groupId>
            <artifactId>javax.servlet-api</artifactId>
            <version>3.0.1</version>
            <scope>provided</scope>

        </dependency>

        <dependency>
            <groupId>log4j</groupId>
            <artifactId>log4j</artifactId>
            <version>1.2.15</version>
        </dependency>

        <dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>slf4j-api</artifactId>
            <version>1.6.3</version>
        </dependency>
        <!-- Spring -->
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-core</artifactId>
            <version>${spring.version}</version>
        </dependency>
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-beans</artifactId>
            <version>${spring.version}</version>
        </dependency>
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-context</artifactId>
            <version>${spring.version}</version>
        </dependency>
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-web</artifactId>
            <version>${spring.version}</version>
        </dependency>
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-aspects</artifactId>
            <version>${spring.version}</version>
        </dependency>
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-tx</artifactId>
            <version>${spring.version}</version>
        </dependency>
        <!-- Required due to a bug in Spring, see https://jira.springsource.org/browse/SPR-6819 -->
        <dependency>
            <groupId>javax.persistence</groupId>
            <artifactId>persistence-api</artifactId>
            <version>1.0</version>
            <optional>true</optional>
        </dependency>
        <!-- AspectJ dependencies -->
        <dependency>
            <groupId>org.aspectj</groupId>
            <artifactId>aspectjrt</artifactId>
            <version>${aspectj.version}</version>
        </dependency>
    </dependencies>

    <build>

        <resources>
            <resource>
                <directory>src/main/resources-${targetprofile}</directory>
                <filtering>false</filtering>
            </resource>
            <resource>
                <directory>src/main/resources</directory>
                <filtering>false</filtering>
            </resource>
        </resources>


        <plugins>
            <plugin>
                <groupId>org.codehaus.mojo</groupId>
                <artifactId>aspectj-maven-plugin</artifactId>
                <version>${aspectj-maven-plugin.version}</version>
                <configuration>
                    <!-- Required as the plugin does not resolve this by default -->
                    <source>${maven.compiler.source}</source>
                    <target>${maven.compiler.target}</target>
                    <aspectLibraries>
                        <aspectLibrary>
                            <groupId>org.springframework</groupId>
                            <artifactId>spring-aspects</artifactId>
                        </aspectLibrary>
                    </aspectLibraries>
                </configuration>
                <executions>
                    <execution>
                        <goals>
                            <goal>compile</goal>
                            <goal>test-compile</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
            <plugin>
                <groupId>org.mortbay.jetty</groupId>
                <artifactId>jetty-maven-plugin</artifactId>
                <version>${jetty-maven-plugin.version}</version>
                <configuration>
                    <scanIntervalSeconds>5</scanIntervalSeconds>
                </configuration>
            </plugin>
        </plugins>

    </build>

    <profiles>
        <profile>
            <id>local</id>
            <activation>
                <property>
                    <name>local</name>
                </property>
            </activation>
            <properties>
                <targetprofile>local</targetprofile>
                <profiledescription>Build for deployment on your LOCAL machine</profiledescription>
            </properties>
        </profile>
    </profiles>


    <packaging>war</packaging>
    <name>myAppNAme</name>
</project>

Hi,

Your issue is hardly related to this request I think. If you want a concrete 
example, have a look to 
https://github.com/archiecobbs/dellroad-stuff-vaadin-spring-demo3

Regarding this question:

   ..."myApplicationBean: MyApplicationBean@58cca9" changes everytime I refresh the browser...

There was a bug in the demo. It should be fixed now.

Regarding the POM stuff, since that is caused by someone else, I'm resolving 
this bug as INVALID.

As a temporary solution the javax.servlet-api dependency can be excluded when 
using spring stuff in your POM:

    <dependency>
      <groupId>org.dellroad</groupId>
      <artifactId>dellroad-stuff-vaadin</artifactId>
      <version>${spring-stuff.version}</version>
      <exclusions>
        <exclusion>
          <groupId>javax.servlet</groupId>
          <artifactId>javax.servlet-api</artifactId>
        </exclusion>
      </exclusions>
    </dependency>

I agree this is caused by somebody else but then transform this issue in an 
improvement to publish the right metadata to Maven. 

Publishing a JAR to the Maven repository  without the related metadata is 
really really wrong (and that's a bug, definitely!). If you don't do it, 
someone else will do it next time (and maybe he'll add the servlet-api 
dependency again without the provided scope).

If you have a Maven build or if you want a way me to help you, let me know.

Agreed. I've created Issue #10 to add maven dependencies.

If you or anyone can come up with a reasonable patch to do that I'll add it.

Thanks.