araxiaonline / mod-auctionator Goto Github PK

I will have market_price data in partnership from wow auction site that collects the data. I will get the script updating weekly on the server this weekend, if you want to use that data.

I am seeing the following warnings when compiling. It do not see any issues with functionality though, so not urgent.

28.76 [ 18%] Built target dbimport
28.82 /azerothcore/modules/mod-auctionator/src/Auctionator.cpp:372:74: warning: unused parameter 'config' [-Wunused-parameter]
28.82 float Auctionator::GetQualityMultiplier(AuctionatorPriceMultiplierConfig config, uint32 quality)
28.82                                                                          ^
28.82 1 warning generated.
28.84 [ 18%] Building CXX object src/server/scripts/CMakeFiles/scripts.dir/cmake_pch.hxx.pch
28.88 [ 18%] Building CXX object modules/CMakeFiles/modules.dir/mod-auctionator/src/AuctionatorCommands.cpp.o
28.90 [ 18%] Building CXX object modules/CMakeFiles/modules.dir/mod-auctionator/src/AuctionatorSeller.cpp.o
28.90 [ 19%] Building CXX object modules/CMakeFiles/modules.dir/mod-auctionator/src/AuctionatorEvents.cpp.o
28.92 [ 19%] Building CXX object modules/CMakeFiles/modules.dir/mod-auctionator/src/Auctionator_loader.cpp.o
28.93 [ 19%] Building CXX object modules/CMakeFiles/modules.dir/mod-auctionator/src/AuctionatorScript.cpp.o
28.94 [ 19%] Building CXX object modules/CMakeFiles/modules.dir/mod-autobalance/src/AutoBalance.cpp.o
28.95 [ 19%] Building CXX object modules/CMakeFiles/modules.dir/mod-autobalance/src/AB_loader.cpp.o
28.97 [ 19%] Building CXX object modules/CMakeFiles/modules.dir/mod-better-item-reloading/src/BIR_loader.cpp.o
29.02 /azerothcore/modules/mod-auctionator/src/AuctionatorCommands.cpp:19:21: warning: 'ChatCommand' is deprecated: std::vector<ChatCommand> should be ChatCommandTable! (using namespace Acore::ChatCommands) [-Wdeprecated-declarations]
29.02         std::vector<ChatCommand> GetCommands() const override
29.02                     ^
29.02 /azerothcore/src/server/game/Chat/ChatCommands/ChatCommand.h:277:21: note: 'ChatCommand' has been explicitly marked deprecated here
29.02 using ChatCommand [[deprecated("std::vector<ChatCommand> should be ChatCommandTable! (using namespace Acore::ChatCommands)")]] = Acore::ChatCommands::ChatCommandBuilder;
29.02                     ^
29.02 /azerothcore/modules/mod-auctionator/src/AuctionatorCommands.cpp:21:32: warning: 'ChatCommand' is deprecated: std::vector<ChatCommand> should be ChatCommandTable! (using namespace Acore::ChatCommands) [-Wdeprecated-declarations]
29.02             return std::vector<ChatCommand>
29.02                                ^
29.02 /azerothcore/src/server/game/Chat/ChatCommands/ChatCommand.h:277:21: note: 'ChatCommand' has been explicitly marked deprecated here
29.02 using ChatCommand [[deprecated("std::vector<ChatCommand> should be ChatCommandTable! (using namespace Acore::ChatCommands)")]] = Acore::ChatCommands::ChatCommandBuilder;
29.02                     ^
29.02 /azerothcore/modules/mod-auctionator/src/AuctionatorCommands.cpp:23:16: warning: 'ChatCommandBuilder' is deprecated: you are using the old-style command format; convert this to the new format ({ name, handler (not a pointer!), permission, Console::(Yes/No) }) [-Wdeprecated-declarations]
29.02                {
29.02                ^
29.02 /azerothcore/src/server/game/Chat/ChatCommands/ChatCommand.h:257:9: note: 'ChatCommandBuilder' has been explicitly marked deprecated here
29.02         ChatCommandBuilder(char const* name, uint32 securityLevel, bool console, TypedHandler* handler, char const*)
29.02         ^
29.02 3 warnings generated.

This line might be responsible for the deviation. Should the argument not be the chosen AH ID?

Quality multiplier is applied here for items without market price

and here for all items

I don't think this is intended; is it a bug? Perhaps the items without market price should just use nator->config->sellerConfig.defaultPrice without qualityMultiplier since it's applied later. Or, maybe don't multiply items that have market prices, i.e.

newItem.buyout = uint32(price * stackSize);
newItem.bid = uint32(bidPrice * stackSize);

I could see either way.

After installation, new CMake and build, my worldserver now is now closing itself at

AzerothCore rev. c9ab7e7e9678 2023-10-17 08:40:55 +0000 (master branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon) ready... [Auctionator]: Auctionator initializing...

The errorlog is empty but there is a crash file created in /crashes which i will add here as well.
Removing the module solves the problem and the server is running just as before.
c9ab7e7e9678_worldserver.exe_[17-10_20-25-11].txt

System Information
Windows 11

Issue
When starting worldserver.exe, initialize data stores stops with the following errors:

Initialize Data Stores...

Some required *.dbc files (2 from 110) not found or not compatible: C:\Azerothcore Moduled w AH Build\bin\RelWithDebInfo\Data/dbc/CharStartOutfit.dbc exists, and has 0 field(s) (expected 77). Extracted file might be from wrong client version or a database-update has been forgotten.

C:\Azerothcore Moduled w AH Build\bin\RelWithDebInfo\Data/dbc/SkillRaceClassInfo.dbc exists, and has 0 field(s) (expected 8). Extracted file might be from wrong client version or a database-update has been forgotten.

The files in question have been altered in order to install All Races All Classes, so I'm unsure if this conflict is expected or unintentional.

Expected Behavior
Module loads data stores and works alongside All Races All Classes.

Solution:
.dbc files were not correctly transferred, this was user-error on my part. Setting up Auctionator now, thanks!

When config is set to disable it still runs in the world server

Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license: https://github.com/azerothcore/azerothcore-wotlk/blob/master/LICENSE-AGPL3

[worldserver]

Auctionator configuration

Auctionator.Enable
    Description: Enable my module and print "Hello World" message at server start
    Default:     0 - Disabled
                 1 - Enabled

Auctionator.Enabled = 0

See world server output:

AzerothCore rev. e863873d4c80 2024-04-03 19:36:53 +0000 (master branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon) ready...
Loading account bound templates...

Loaded 205 companion templates
Loaded 1 faction-specific companion templates
Loaded 246 mount templates
Loaded 73 faction-specific mount templates
[Auctionator]: Auctionator initializing...
[Auctionator] Initializing Auctionator Config
[Auctionator] config->isEnabled: 0
[Auctionator] CharacterIds: 2::1
[Auctionator] Auctionator config initialized
[Auctionator] Event init
[AuctionatorEvents] Initializing events
[Auctionator]: Auctionator disabled.
AC> Starting up Auction House Listing thread...
Calendar deletion of old events.
[Auctionator] - - - - - - - - - - - - - - - - - - - -
[Auctionator] Neutral count: 5100
[Auctionator] Alliance count: 5097
[Auctionator] Horde count: 5100
[Auctionator] UpdatingEvents
[AuctionatorEvents] Executing events
[AuctionatorEvents] Executing event: AllianceSeller
[AuctionatorEvents] Alliance count over max: 5097
[AuctionatorEvents] Executing event: HordeSeller
[AuctionatorEvents] Horde count over max: 5100
[AuctionatorEvents] Executing event: NeutralSeller
[AuctionatorEvents] Neutral count over max: 5100
[Auctionator] ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^

The SQL queries provided in the readme, related to performing a clean setup, are wrong. I don't think I have to explain what I'm talking about but just in case, acore_world.mod_acore_characters.item_instance is not a table.

I also don't think you should include the name of the database in the queries but instead tell the user they have to run it against their characters database. This is something that has been corrected multiple times with AzerothCore because it produces errors for enough people, say if they're not using the "standard" database names.

In case you want to keep it as simple as possible, I would instead suggest doing something like this. There is no reason to use aliases if you have absolutely no use for them.

DELETE FROM `item_instance` WHERE `guid` IN (SELECT `itemguid` FROM `auctionhouse`);
DELETE FROM `auctionhouse`;